diff options
| author | Michael Catanzaro <mcatanzaro@gnome.org> | 2020-03-26 13:36:49 -0500 |
|---|---|---|
| committer | Michael Catanzaro <mcatanzaro@gnome.org> | 2020-03-26 13:36:49 -0500 |
| commit | 21bfda2de1cad9572296e288ac5423d7510155ab (patch) | |
| tree | 77b5c112e14dc84df108b1f9765a1b9d13d8d360 /lib | |
| parent | 1f024599fa764a7d40109f24ed0a8f8b773f4e70 (diff) | |
| download | epiphany-21bfda2de1cad9572296e288ac5423d7510155ab.tar.gz | |
Fix invalid free in ephy_web_application_setup_from_desktop_file()
We are clobbering the GDesktopAppInfo's internal icon here, leading to a
critical later when it gets finalized.
Note: this function is only called when a desktop file basename is
passed to --application-mode. Epiphany will never create such web apps
itself, which is how this went unnoticed for so long, but it's used by
fedora-developer-portal (prior to F32, which switched to Chromium
instead of Epiphany at my request).
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/ephy-web-app-utils.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/ephy-web-app-utils.c b/lib/ephy-web-app-utils.c index 18f165a03..10b30ae20 100644 --- a/lib/ephy-web-app-utils.c +++ b/lib/ephy-web-app-utils.c @@ -510,7 +510,6 @@ ephy_web_application_setup_from_desktop_file (GDesktopAppInfo *desktop_info) if (names) gtk_window_set_default_icon_name (names[0]); } - g_clear_object (&icon); /* We need to re-set this because we have already parsed the * options, which inits GTK+ and sets this as a side effect. |