summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Catanzaro <mcatanzaro@igalia.com>2018-01-06 18:42:26 -0600
committerMichael Catanzaro <mcatanzaro@igalia.com>2018-01-06 18:42:26 -0600
commit5fbe1607b849c4ce49ad76608a09254cc013a217 (patch)
treef537aae39a50fa361e6da2f95803da1d2c828a52
parentf2673183b09293ed53ee418c957e1a4397110035 (diff)
downloadepiphany-5fbe1607b849c4ce49ad76608a09254cc013a217.tar.gz
window: Make policy decision robust to future decision types
The current code will break in the future if any new decision type is introduced that does not correspond to a WebKitNavigationPolicyDecision.
-rw-r--r--src/ephy-window.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/ephy-window.c b/src/ephy-window.c
index 96af17078..a700fab28 100644
--- a/src/ephy-window.c
+++ b/src/ephy-window.c
@@ -2071,7 +2071,8 @@ decide_policy_cb (WebKitWebView *web_view,
WebKitURIRequest *request;
const char *request_uri;
- if (decision_type == WEBKIT_POLICY_DECISION_TYPE_RESPONSE)
+ if (decision_type != WEBKIT_POLICY_DECISION_TYPE_NAVIGATION_ACTION &&
+ decision_type != WEBKIT_POLICY_DECISION_TYPE_NEW_WINDOW_ACTION)
return FALSE;
navigation_decision = WEBKIT_NAVIGATION_POLICY_DECISION (decision);