diff options
| author | Michael Catanzaro <mcatanzaro@redhat.com> | 2023-01-04 13:02:41 -0600 |
|---|---|---|
| committer | Michael Catanzaro <mcatanzaro@redhat.com> | 2023-01-04 13:11:41 -0600 |
| commit | be97f7564aade00d1859bdf77e78b3b093c11ccd (patch) | |
| tree | 63c4376a10892870c3da28668ad19cd25175313d | |
| parent | a25f29061dd4fbf1e2b6035d21993d9c835a7ee3 (diff) | |
| download | epiphany-mcatanzaro/coverity-gnome-43.tar.gz | |
embed-prefs: fix double free on error pathmcatanzaro/coverity-gnome-43
If we fail to create the file monitor for the user JS file, then we free
the error twice by mistake. Uh-oh. Found by Coverity.
| -rw-r--r-- | embed/ephy-embed-prefs.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/embed/ephy-embed-prefs.c b/embed/ephy-embed-prefs.c index 630218689..a219ea54c 100644 --- a/embed/ephy-embed-prefs.c +++ b/embed/ephy-embed-prefs.c @@ -255,12 +255,10 @@ webkit_pref_callback_user_javascript (GSettings *settings, (GAsyncReadyCallback)user_javascript_read_cb, NULL); user_javascript_monitor = g_file_monitor_file (file, G_FILE_MONITOR_NONE, NULL, &error); - if (!user_javascript_monitor) { + if (!user_javascript_monitor) g_warning ("Could not create a file monitor for %s: %s\n", g_file_get_uri (file), error->message); - g_error_free (error); - } else { + else g_signal_connect (user_javascript_monitor, "changed", G_CALLBACK (user_javascript_file_changed), NULL); - } } static void |