| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
We get called for every removed GDK device, so check whether it's of
interest early, instead after throwing a bunch of warnings.
gsd-wacom[1884]: g_signal_handlers_disconnect_matched: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
gsd-wacom[1884]: gsd_wacom_device_get_device_type: assertion 'GSD_IS_WACOM_DEVICE (device)' failed
gsd-wacom[1884]: gsd_wacom_device_get_settings: assertion 'GSD_IS_WACOM_DEVICE (device)' failed
gsd-wacom[1884]: invalid (NULL) pointer instance
https://bugzilla.gnome.org/show_bug.cgi?id=772581
|
|
|
|
|
|
|
| |
We have 2 checks for the same thing within a couple of lines. Merge
those.
https://bugzilla.gnome.org/show_bug.cgi?id=772581
|
|
|
|
|
| |
Several small leaks exist were found and fixed in the wacom plugin after
running valgrind.
|
|
|
|
|
|
|
|
|
|
| |
Most of the wacom plugin code protects X11 calls with gdk_error_trap_push/pop
and prints a warning if something fails. There were two calls that were not
protected, however, and one use of g_error instead of g_warning that would
cause the g-s-d process to die if e.g. the tablet disappears while g-s-d is
trying to work on it.
https://bugzilla.gnome.org/show_bug.cgi?id=765996
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This fixes problems when the system has a platform rfkill device for
Bluetooth and the Bluetooth adapter's rfkill support somehow got
blocked.
https://bugzilla.gnome.org/show_bug.cgi?id=741675
|
|
|
|
|
|
| |
Add helper to re-send an enablement event after it's been sent once to
make sure that unblocking a Bluetooth platform rfkill will also unblock
the Bluetooth adapter that might appear.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Otherwise the mapping may come out wrong if during the initialization
paths it first applies keep-aspect, and later maps to a single monitor.
https://bugzilla.gnome.org/show_bug.cgi?id=753680
|
|
|
|
|
|
|
|
|
|
|
|
| |
When devices are plugged, we may end up emitting
GsdDeviceManager::device-added at a time when not all GdkDevices have been
attached to the GsdDevice, this makes these devices occasionally not being
applied the right keep-aspect/area settings.
Add a GsdDeviceManager::device-changed signal, emitted for the GsdDevice
for those situations, so the late-added devices are ensured to be updated.
https://bugzilla.gnome.org/show_bug.cgi?id=753589
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the introduction of GsDeviceMapper (commit 0810de0f), left-handed
mode became responsibility of this object, which was applied by applying an
extra rotation to the device coordinate matrix.
Later, the device coordinate matrix handling was lifted to mutter, although
the rotation setting was kept in the g-s-d side of the settings split, so
GsdDeviceMapper would listen to the wrong settings, and left-handed mode
became no mans land.
Put the application of this setting back into GsdWacomManager, again
translated to the "Wacom Rotation" device property. Nonetheless, all
settings should move eventually to mutter domain, and this turned again
into modifications to the coordinate matrix.
https://bugzilla.gnome.org/show_bug.cgi?id=749767
|
|
|
|
| |
The device array returned must be freed.
|
|
|
|
|
|
|
| |
Disconnect the signal from plugin_settings when unloading the plugin
so it's not called after the plugin has been freed.
https://bugzilla.gnome.org/show_bug.cgi?id=756958
|
|
|
|
|
|
|
| |
The GSettings callback wasn't calling Xft when the cursor size
configuration changed.
https://bugzilla.gnome.org/show_bug.cgi?id=755431
|
| |
|
| |
|
|
|
|
|
|
|
| |
According to GSettings docs, one must read after connecting to changed::
in order to ensure the handler will trigger in the future.
https://bugzilla.gnome.org/show_bug.cgi?id=753170
|
|
|
|
|
|
|
| |
According to GSettings docs, one must read after connecting to changed::
in order to ensure the handler will trigger in the future.
https://bugzilla.gnome.org/show_bug.cgi?id=753170
|
|
|
|
|
|
|
| |
According to GSettings docs, one must read after connecting to changed::
in order to ensure the handler will trigger in the future.
https://bugzilla.gnome.org/show_bug.cgi?id=753170
|
| |
|
| |
|
|
|
|
|
|
|
| |
No functional changes, this just makes it explicit that these
functions only work on devices driven by the X synaptics driver.
https://bugzilla.gnome.org/show_bug.cgi?id=749818
|
|
|
|
|
|
| |
As a side effect we can now run this on wayland sessions too.
https://bugzilla.gnome.org/show_bug.cgi?id=749818
|
|
|
|
|
|
|
|
|
|
| |
Using GsdDeviceManager allows our device type presence checks work
both on libinput using X sessions and on Wayland sessions.
At the same time we still need to support systems using the synaptics
X driver so let's make that an explicit separate check.
https://bugzilla.gnome.org/show_bug.cgi?id=749818
|
|
|
|
|
|
|
| |
From coverity:
gnome-settings-daemon-3.14.4/plugins/power/gpm-common.c:321:52: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error')
https://bugzilla.gnome.org/show_bug.cgi?id=749882
|
|
|
|
|
|
|
| |
From coverity:
gnome-settings-daemon-3.14.4/plugins/wacom/gsd-wacom-led-helper.c:130: double_free: Calling "g_free" frees pointer "status" which has already been freed.
https://bugzilla.gnome.org/show_bug.cgi?id=749882
|
|
|
|
|
|
|
|
|
|
| |
We can't free "", buffer needs to be set by the command-line options,
but we never check that it got set.
From coverity:
gnome-settings-daemon-3.14.4/plugins/wacom/gsd-wacom-oled-helper.c:415: incorrect_free: "g_free" frees incorrect pointer "buffer".
https://bugzilla.gnome.org/show_bug.cgi?id=749882
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to attempt to reconstruct the ['','',''] default, although
this failed on NULL outputs as we tried to feed NULLs into "as"
variants/settings.
Fix this by just resetting the key when the device gets a NULL
output, we can also make the other path clearer as we can't get
NULLs in edid[] as we previously might.
Based on a patch by Alexandre Rostovtsev <tetromino@gentoo.org>
https://bugzilla.gnome.org/show_bug.cgi?id=749844
|
| |
|
|
|
|
|
|
|
| |
Blacklist 'cups-waiting-for-job-completed' job state reason which
is rather an internal flag for CUPS.
https://bugzilla.redhat.com/show_bug.cgi?id=1207154
|
|
|
|
|
|
|
|
|
|
| |
If atoi() returns a negative value this will be interpreted as an
error but the GError wouldn't be set which would crash us when
printing an error message.
See https://bugzilla.redhat.com/show_bug.cgi?id=1222007
https://bugzilla.gnome.org/show_bug.cgi?id=749440
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doing so causes pkexec to fail[0] if the current user's SHELL doesn't
exist in /etc/shells which happens for the gdm user in some
distributions.
Since we don't need this environment variable in the helper we can
work around that by just unsetting it.
[0] http://cgit.freedesktop.org/polkit/commit/?id=5a388b6ebb095de6dc7f315b651a84fc31d268d7
https://bugzilla.gnome.org/show_bug.cgi?id=748804
|
|
|
|
|
|
|
| |
We'll need to change the environment that we pass on to the helper and
this will make it easier.
https://bugzilla.gnome.org/show_bug.cgi?id=748804
|
|
|
|
| |
Fix up commit 578524da528e554fddfa6cf070554984c0ebfcfd
|
|
|
|
|
|
|
|
|
|
|
| |
GIO's GFileMonitor already delays directory monitor notifications, so
directory-level changes will already be coalesced even if there's a
lot of changes happening.
Monitoring files (which happens for the XML config files) are signalled
immediately now.
https://bugzilla.gnome.org/show_bug.cgi?id=748776
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If one of our idle watches triggers while we're temporarily unidle we
should save and switch to it when that period ends otherwise we would
ignore any idle request transitions in that period and always go back
to the state where we were when becoming temporarily unidle.
This prevents the following bug:
1. Laptop enters sleep
2. Lid open, wake up, idle time gets reset, we enter NORMAL state
3. There's a notification so gnome-shell asks us to go temporarily
unidle while we're in NORMAL state
4. The 15s inactivity watch is triggered and we switch to BLANK
5. The unidle timer is triggered and we switch back to NORMAL since
that's the state we were in when it started
Result is that the screen is left turned ON indefinitely after waking
from sleep if there's a notification when we wake up.
https://bugzilla.gnome.org/show_bug.cgi?id=748849
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change fontconfig timeout from 2 seconds to 200 milliseconds. This should
make font installations to be propagated to applications faster.
Originally I made this quite delayed, to make sure it doesn't fire too
much when people are installing packages, etc, but after many years, I think
that was a very bad choice.
Currently, it takes 4 seconds from when I "mv font.ttf ~/.fonts/" until
apps like gedit switching to it. Hopefully this change saves about
2.3 seconds of that (on average 0.5s was added by g_timeout_add_seconds()).
https://bugzilla.gnome.org/show_bug.cgi?id=748776
|
|
|
|
|
|
|
|
| |
On sane hardware it is mainly unneeded, and the UI on g-c-c is
discoverable enough for the cases where it isn't, so let's avoid
nagging about something mostly superfluous.
https://bugzilla.gnome.org/show_bug.cgi?id=748659
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Touchpad buttons are disabled also if touchpad is disabled using
"Device Enabled" property. Unfortunately some touchpads share those
buttons with trackpoint, which is consequently unusable. Disable
touchpad using "Synaptics Off" property instead to avoid disabling
the buttons.
Remove also some redundant calls to enable/disable touchpad and
make sure syndaemon isn't running if the touchpads are disabled.
https://bugzilla.gnome.org/show_bug.cgi?id=747504
|
|
|
|
| |
We already push above and pop below.
|
|
|
|
|
|
|
| |
We forgot to update this on commit
ca754de5039fed6cb96b883dd8e41d8b22ebeea6 .
https://bugzilla.gnome.org/show_bug.cgi?id=747739
|
|
|
|
|
|
|
|
|
| |
Set a password callback for CUPS returning NULL to not block g-s-d
on password request when handling subscriptions.
We don't have a better solution right now (a better one would be to show
a password dialog to user).
https://bugzilla.gnome.org/show_bug.cgi?id=725440
|
|
|
|
|
|
|
| |
We have to be sure that devices without hardware buttons have tap to
click enabled.
https://bugzilla.gnome.org/show_bug.cgi?id=745601
|