summaryrefslogtreecommitdiff
path: root/support
diff options
context:
space:
mode:
authorElliot Lee <sopwith@src.gnome.org>1999-10-29 19:16:05 +0000
committerElliot Lee <sopwith@src.gnome.org>1999-10-29 19:16:05 +0000
commit8c686af4f60f006d9e25df5f3beb379ca8045a92 (patch)
tree0e91de956d23aae880097567d0b91a11828655e4 /support
parentc4f37e5ec5758b4ac49ac31b3f810846802f6ecc (diff)
downloadgnome-common-8c686af4f60f006d9e25df5f3beb379ca8045a92.tar.gz
builds now. Integrate new popt. Don't install this library. Link
* liboafgnome/: builds now. * support/: Integrate new popt. Don't install this library. * libgnome/Makefile.am: Link ../support/libgnomesupport.la in as part of libgnome.la * */Makefile.am: Reflect this * configure.in: Use AM_PATH_ORBIT macro svn path=/trunk/; revision=984
Diffstat (limited to 'support')
-rw-r--r--support/Makefile.am4
-rw-r--r--support/findme.c21
-rw-r--r--support/popt-gnome.h40
-rw-r--r--support/popt.c332
-rw-r--r--support/poptconfig.c30
-rw-r--r--support/popthelp.c50
-rw-r--r--support/poptint.h48
-rw-r--r--support/poptparse.c105
-rw-r--r--support/system.h55
9 files changed, 417 insertions, 268 deletions
diff --git a/support/Makefile.am b/support/Makefile.am
index 11d68a5..487c4fc 100644
--- a/support/Makefile.am
+++ b/support/Makefile.am
@@ -4,7 +4,7 @@ supportexecincludedir = $(pkglibdir)/include
INCLUDES = -D_GNU_SOURCE
-lib_LTLIBRARIES = libgnomesupport.la
+noinst_LTLIBRARIES = libgnomesupport.la
# it is in _DATA since we don't want `gnomesupport.h' to be part of
# the distributed `.tar.gz' file
@@ -13,7 +13,7 @@ supportexecinclude_DATA = gnomesupport.h
# These are internal headers: they are used only when compiling and
# should not be installed
noinst_HEADERS = gnomesupport-fake.h \
- findme.h poptint.h
+ findme.h poptint.h system.h
# Hmm... should we move `error.h' here.
include_HEADERS = popt-gnome.h
diff --git a/support/findme.c b/support/findme.c
index 4ba4950..6d1b41c 100644
--- a/support/findme.c
+++ b/support/findme.c
@@ -2,24 +2,7 @@
file accompanying popt source distributions, available from
ftp://ftp.redhat.com/pub/code/popt */
-#ifdef HAVE_CONFIG_H
-#include "config.h"
-#endif
-
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
-#ifdef __NeXT
-/* access macros are not declared in non posix mode in unistd.h -
- don't try to use posix on NeXTstep 3.3 ! */
-#include <libc.h>
-#endif
-
-#if HAVE_ALLOCA_H
-# include <alloca.h>
-#endif
-
+#include "system.h"
#include "findme.h"
const char * findProgramPath(const char * argv0) {
@@ -31,7 +14,7 @@ const char * findProgramPath(const char * argv0) {
/* If there is a / in the argv[0], it has to be an absolute
path */
if (strchr(argv0, '/'))
- return strdup(argv0);
+ return xstrdup(argv0);
if (!path) return NULL;
diff --git a/support/popt-gnome.h b/support/popt-gnome.h
index c252e6b..5046fad 100644
--- a/support/popt-gnome.h
+++ b/support/popt-gnome.h
@@ -52,20 +52,20 @@ extern "C" {
#define POPT_CONTEXT_POSIXMEHARDER (1 << 2) /* options can't follow args */
struct poptOption {
- const char * longName; /* may be NULL */
+ /*@observer@*/ /*@null@*/ const char * longName; /* may be NULL */
char shortName; /* may be '\0' */
int argInfo;
- void * arg; /* depends on argInfo */
+ /*@shared@*/ /*@null@*/ void * arg; /* depends on argInfo */
int val; /* 0 means don't return, just update flag */
- const char * descrip; /* description for autohelp -- may be NULL */
- const char * argDescrip; /* argument description for autohelp */
+ /*@shared@*/ /*@null@*/ const char * descrip; /* description for autohelp -- may be NULL */
+ /*@shared@*/ /*@null@*/ const char * argDescrip; /* argument description for autohelp */
};
struct poptAlias {
- const char * longName; /* may be NULL */
+ /*@owned@*/ /*@null@*/ const char * longName; /* may be NULL */
char shortName; /* may be '\0' */
int argc;
- const char ** argv; /* must be free()able */
+ /*@owned@*/ const char ** argv; /* must be free()able */
};
extern struct poptOption poptHelpOptions[];
@@ -85,22 +85,23 @@ typedef void (*poptCallbackType)(poptContext con,
const struct poptOption * opt,
const char * arg, const void * data);
-poptContext poptGetContext(const char * name, int argc, char ** argv,
- const struct poptOption * options, int flags);
+/*@only@*/ poptContext poptGetContext(/*@keep@*/ const char * name,
+ int argc, /*@keep@*/ const char ** argv,
+ /*@keep@*/ const struct poptOption * options, int flags);
void poptResetContext(poptContext con);
/* returns 'val' element, -1 on last item, POPT_ERROR_* on error */
int poptGetNextOpt(poptContext con);
/* returns NULL if no argument is available */
-char * poptGetOptArg(poptContext con);
+/*@observer@*/ /*@null@*/ const char * poptGetOptArg(poptContext con);
/* returns NULL if no more options are available */
-char * poptGetArg(poptContext con);
-const char * poptPeekArg(poptContext con);
-const char ** poptGetArgs(poptContext con);
+/*@observer@*/ /*@null@*/ const char * poptGetArg(poptContext con);
+/*@observer@*/ /*@null@*/ const char * poptPeekArg(poptContext con);
+/*@observer@*/ /*@null@*/ const char ** poptGetArgs(poptContext con);
/* returns the option which caused the most recent error */
-const char * poptBadOption(poptContext con, int flags);
-void poptFreeContext(poptContext con);
-int poptStuffArgs(poptContext con, const char ** argv);
+/*@observer@*/ const char * poptBadOption(poptContext con, int flags);
+void poptFreeContext( /*@only@*/ poptContext con);
+int poptStuffArgs(poptContext con, /*@keep@*/ const char ** argv);
int poptAddAlias(poptContext con, struct poptAlias alias, int flags);
int poptReadConfigFile(poptContext con, const char * fn);
/* like above, but reads /etc/popt and $HOME/.popt along with environment
@@ -108,13 +109,16 @@ int poptReadConfigFile(poptContext con, const char * fn);
int poptReadDefaultConfig(poptContext con, int useEnv);
/* argv should be freed -- this allows ', ", and \ quoting, but ' is treated
the same as " and both may include \ quotes */
-int poptParseArgvString(const char * s, int * argcPtr, char *** argvPtr);
-const char * poptStrerror(const int error);
+int poptDupArgv(int argc, const char **argv,
+ /*@out@*/ int * argcPtr, /*@out@*/ const char *** argvPtr);
+int poptParseArgvString(const char * s,
+ /*@out@*/ int * argcPtr, /*@out@*/ const char *** argvPtr);
+/*@observer@*/ const char *const poptStrerror(const int error);
void poptSetExecPath(poptContext con, const char * path, int allowAbsolute);
void poptPrintHelp(poptContext con, FILE * f, int flags);
void poptPrintUsage(poptContext con, FILE * f, int flags);
void poptSetOtherOptionHelp(poptContext con, const char * text);
-const char * poptGetInvocationName(poptContext con);
+/*@observer@*/ const char * poptGetInvocationName(poptContext con);
#ifdef __cplusplus
}
diff --git a/support/popt.c b/support/popt.c
index 3e8f73e..283cf83 100644
--- a/support/popt.c
+++ b/support/popt.c
@@ -1,26 +1,9 @@
/* (C) 1998 Red Hat Software, Inc. -- Licensing details are in the COPYING
- file accompanying popt source distributions, available from
+ file accompanying popt source distributions, available from
ftp://ftp.redhat.com/pub/code/popt */
-#ifdef HAVE_CONFIG_H
-#include "config.h"
-#endif
-
-#include <errno.h>
-#include <ctype.h>
-#include <fcntl.h>
-#include <limits.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
-
-#if HAVE_ALLOCA_H
-# include <alloca.h>
-#endif
-
+#include "system.h"
#include "findme.h"
-#include "popt-gnome.h"
#include "poptint.h"
#ifndef HAVE_STRERROR
@@ -37,7 +20,7 @@ static char * strerror(int errno) {
void poptSetExecPath(poptContext con, const char * path, int allowAbsolute) {
if (con->execPath) xfree(con->execPath);
- con->execPath = strdup(path);
+ con->execPath = xstrdup(path);
con->execAbsolute = allowAbsolute;
}
@@ -45,7 +28,7 @@ static void invokeCallbacks(poptContext con, const struct poptOption * table,
int post) {
const struct poptOption * opt = table;
poptCallbackType cb;
-
+
while (opt->longName || opt->shortName || opt->arg) {
if ((opt->argInfo & POPT_ARG_MASK) == POPT_ARG_INCLUDE_TABLE) {
invokeCallbacks(con, opt->arg, post);
@@ -60,7 +43,7 @@ static void invokeCallbacks(poptContext con, const struct poptOption * table,
}
}
-poptContext poptGetContext(const char * name, int argc, char ** argv,
+poptContext poptGetContext(const char * name, int argc, const char ** argv,
const struct poptOption * options, int flags) {
poptContext con = malloc(sizeof(*con));
@@ -68,21 +51,26 @@ poptContext poptGetContext(const char * name, int argc, char ** argv,
con->os = con->optionStack;
con->os->argc = argc;
- con->os->argv = (const char **)argv; /* XXX don't change the API */
+ con->os->argv = argv;
+ con->os->argb = NULL;
if (!(flags & POPT_CONTEXT_KEEP_FIRST))
con->os->next = 1; /* skip argv[0] */
- con->leftovers = malloc(sizeof(char *) * (argc + 1));
+ con->leftovers = calloc( (argc + 1), sizeof(char *) );
con->options = options;
- con->finalArgv = malloc(sizeof(*con->finalArgv) * (argc * 2));
- con->finalArgvAlloced = argc * 2;
+ con->aliases = NULL;
+ con->numAliases = 0;
con->flags = flags;
+ con->execs = NULL;
+ con->numExecs = 0;
+ con->finalArgvAlloced = argc * 2;
+ con->finalArgv = calloc( con->finalArgvAlloced, sizeof(*con->finalArgv) );
con->execAbsolute = 1;
if (getenv("POSIXLY_CORRECT") || getenv("POSIX_ME_HARDER"))
con->flags |= POPT_CONTEXT_POSIXMEHARDER;
-
+
if (name)
con->appName = strcpy(malloc(strlen(name) + 1), name);
@@ -91,10 +79,32 @@ poptContext poptGetContext(const char * name, int argc, char ** argv,
return con;
}
+static void cleanOSE(struct optionStackEntry *os)
+{
+ if (os->nextArg) {
+ xfree(os->nextArg);
+ os->nextArg = NULL;
+ }
+ if (os->argv) {
+ xfree(os->argv);
+ os->argv = NULL;
+ }
+ if (os->argb) {
+ PBM_FREE(os->argb);
+ os->argb = NULL;
+ }
+}
+
void poptResetContext(poptContext con) {
int i;
- con->os = con->optionStack;
+ while (con->os > con->optionStack) {
+ cleanOSE(con->os--);
+ }
+ if (con->os->argb) {
+ PBM_FREE(con->os->argb);
+ con->os->argb = NULL;
+ }
con->os->currAlias = NULL;
con->os->nextCharArg = NULL;
con->os->nextArg = NULL;
@@ -105,8 +115,12 @@ void poptResetContext(poptContext con) {
con->restLeftover = 0;
con->doExec = NULL;
- for (i = 0; i < con->finalArgvCount; i++)
- xfree(con->finalArgv[i]);
+ for (i = 0; i < con->finalArgvCount; i++) {
+ if (con->finalArgv[i]) {
+ xfree(con->finalArgv[i]);
+ con->finalArgv[i] = NULL;
+ }
+ }
con->finalArgvCount = 0;
}
@@ -129,7 +143,7 @@ static int handleExec(poptContext con, char * longName, char shortName) {
if (con->flags & POPT_CONTEXT_NO_EXEC)
return 1;
- if (!con->doExec) {
+ if (con->doExec == NULL) {
con->doExec = con->execs + i;
return 1;
}
@@ -146,7 +160,7 @@ static int handleExec(poptContext con, char * longName, char shortName) {
{ char *s = malloc((longName ? strlen(longName) : 0) + 3);
if (longName)
sprintf(s, "--%s", longName);
- else
+ else
sprintf(s, "-%c", shortName);
con->finalArgv[i] = s;
}
@@ -156,13 +170,13 @@ static int handleExec(poptContext con, char * longName, char shortName) {
/* Only one of longName, shortName may be set at a time */
static int handleAlias(poptContext con, const char * longName, char shortName,
- const char * nextCharArg) {
+ /*@keep@*/ const char * nextCharArg) {
int i;
if (con->os->currAlias && con->os->currAlias->longName && longName &&
- !strcmp(con->os->currAlias->longName, longName))
+ !strcmp(con->os->currAlias->longName, longName))
return 0;
- if (con->os->currAlias && shortName &&
+ if (con->os->currAlias && shortName &&
shortName == con->os->currAlias->shortName)
return 0;
@@ -177,8 +191,7 @@ static int handleAlias(poptContext con, const char * longName, char shortName,
if (i < 0) return 0;
- if ((con->os - con->optionStack + 1)
- == POPT_OPTION_DEPTH)
+ if ((con->os - con->optionStack + 1) == POPT_OPTION_DEPTH)
return POPT_ERROR_OPTSTOODEEP;
if (nextCharArg && *nextCharArg)
@@ -187,10 +200,12 @@ static int handleAlias(poptContext con, const char * longName, char shortName,
con->os++;
con->os->next = 0;
con->os->stuffed = 0;
- con->os->nextArg = con->os->nextCharArg = NULL;
+ con->os->nextArg = NULL;
+ con->os->nextCharArg = NULL;
con->os->currAlias = con->aliases + i;
- con->os->argc = con->os->currAlias->argc;
- con->os->argv = con->os->currAlias->argv;
+ poptDupArgv(con->os->currAlias->argc, con->os->currAlias->argv,
+ &con->os->argc, &con->os->argv);
+ con->os->argb = NULL;
return 1;
}
@@ -200,7 +215,7 @@ static void execCommand(poptContext con) {
int pos = 0;
const char * script = con->doExec->script;
- argv = malloc(sizeof(*argv) *
+ argv = malloc(sizeof(*argv) *
(6 + con->numLeftovers + con->finalArgvCount));
if (!con->execAbsolute && strchr(script, '/')) return;
@@ -249,12 +264,12 @@ static void execCommand(poptContext con) {
execvp(argv[0], (char *const *)argv);
}
-static const struct poptOption * findOption(const struct poptOption * table,
- const char * longName,
- char shortName,
- poptCallbackType * callback,
- const void ** callbackData,
- int singleDash) {
+/*@observer@*/ static const struct poptOption *
+findOption(const struct poptOption * table, const char * longName,
+ char shortName,
+ /*@out@*/ poptCallbackType * callback, /*@out@*/ const void ** callbackData,
+ int singleDash)
+{
const struct poptOption * opt = table;
const struct poptOption * opt2;
const struct poptOption * cb = NULL;
@@ -265,7 +280,7 @@ static const struct poptOption * findOption(const struct poptOption * table,
while (opt->longName || opt->shortName || opt->arg) {
if ((opt->argInfo & POPT_ARG_MASK) == POPT_ARG_INCLUDE_TABLE) {
- opt2 = findOption(opt->arg, longName, shortName, callback,
+ opt2 = findOption(opt->arg, longName, shortName, callback,
callbackData, singleDash);
if (opt2) {
if (*callback && !*callbackData)
@@ -274,7 +289,7 @@ static const struct poptOption * findOption(const struct poptOption * table,
}
} else if ((opt->argInfo & POPT_ARG_MASK) == POPT_ARG_CALLBACK) {
cb = opt;
- } else if (longName && opt->longName &&
+ } else if (longName && opt->longName &&
(!singleDash || (opt->argInfo & POPT_ARGFLAG_ONEDASH)) &&
!strcmp(longName, opt->longName)) {
break;
@@ -296,32 +311,101 @@ static const struct poptOption * findOption(const struct poptOption * table,
return opt;
}
+static const char *findNextArg(poptContext con, unsigned argx, int delete)
+{
+ struct optionStackEntry * os = con->os;
+ const char * arg;
+
+ do {
+ int i;
+ arg = NULL;
+ while (os->next == os->argc && os > con->optionStack) os--;
+ if (os->next == os->argc && os == con->optionStack) break;
+ for (i = os->next; i < os->argc; i++) {
+ if (os->argb && PBM_ISSET(i, os->argb)) continue;
+ if (*os->argv[i] == '-') continue;
+ if (--argx > 0) continue;
+ arg = os->argv[i];
+ if (delete) {
+ if (os->argb == NULL) os->argb = PBM_ALLOC(os->argc);
+ PBM_SET(i, os->argb);
+ }
+ break;
+ }
+ if (os > con->optionStack) os--;
+ } while (arg == NULL);
+ return arg;
+}
+
+static /*@only@*/ const char * expandNextArg(poptContext con, const char * s)
+{
+ const char *a;
+ size_t alen;
+ char *t, *te;
+ size_t tn = strlen(s) + 1;
+ char c;
+
+ te = t = malloc(tn);;
+ while ((c = *s++) != '\0') {
+ switch (c) {
+ case '\\': /* escape */
+ c = *s++;
+ break;
+ case '!':
+ if (!(s[0] == '#' && s[1] == ':' && s[2] == '+'))
+ break;
+ if ((a = findNextArg(con, 1, 1)) == NULL)
+ break;
+ s += 3;
+
+ alen = strlen(a);
+ tn += alen;
+ *te = '\0';
+ t = realloc(t, tn);
+ te = t + strlen(t);
+ strncpy(te, a, alen); te += alen;
+ continue;
+ /*@notreached@*/ break;
+ default:
+ break;
+ }
+ *te++ = c;
+ }
+ *te = '\0';
+ t = realloc(t, strlen(t)); /* XXX memory leak, hard to plug */
+ return t;
+}
+
/* returns 'val' element, -1 on last item, POPT_ERROR_* on error */
-int poptGetNextOpt(poptContext con) {
- char * optString, * chptr, * localOptString;
- const char * longArg = NULL;
- const char * origOptString;
- long aLong;
- char * end;
+int poptGetNextOpt(poptContext con)
+{
const struct poptOption * opt = NULL;
int done = 0;
- int i;
- poptCallbackType cb;
- const void * cbData;
- int singleDash;
while (!done) {
- while (!con->os->nextCharArg && con->os->next == con->os->argc
- && con->os > con->optionStack)
- con->os--;
+ const char * origOptString = NULL;
+ poptCallbackType cb = NULL;
+ const void * cbData = NULL;
+ const char * longArg = NULL;
+
+ while (!con->os->nextCharArg && con->os->next == con->os->argc
+ && con->os > con->optionStack) {
+ cleanOSE(con->os--);
+ }
if (!con->os->nextCharArg && con->os->next == con->os->argc) {
invokeCallbacks(con, con->options, 1);
if (con->doExec) execCommand(con);
return -1;
}
+ /* Process next long option */
if (!con->os->nextCharArg) {
-
+ char * localOptString, * optString;
+
+ if (con->os->argb && PBM_ISSET(con->os->next, con->os->argb)) {
+ con->os->next++;
+ continue;
+ }
origOptString = con->os->argv[con->os->next++];
if (con->restLeftover || *origOptString != '-') {
@@ -332,8 +416,8 @@ int poptGetNextOpt(poptContext con) {
}
/* Make a copy we can hack at */
- localOptString = optString =
- strcpy(alloca(strlen(origOptString) + 1),
+ localOptString = optString =
+ strcpy(alloca(strlen(origOptString) + 1),
origOptString);
if (!optString[0])
@@ -343,33 +427,41 @@ int poptGetNextOpt(poptContext con) {
con->restLeftover = 1;
continue;
} else {
+ char *oe;
+ int singleDash;
+
optString++;
if (*optString == '-')
singleDash = 0, optString++;
else
singleDash = 1;
+ /* XXX aliases with arg substitution need "--alias=arg" */
if (handleAlias(con, optString, '\0', NULL))
continue;
if (handleExec(con, optString, '\0'))
continue;
- chptr = optString;
- while (*chptr && *chptr != '=') chptr++;
- if (*chptr == '=') {
- longArg = origOptString + (chptr - localOptString) + 1;
- *chptr = '\0';
+ /* Check for "--long=arg" option. */
+ for (oe = optString; *oe && *oe != '='; oe++)
+ ;
+ if (*oe == '=') {
+ *oe++ = '\0';
+ /* XXX longArg is mapped back to persistent storage. */
+ longArg = origOptString + (oe - localOptString);
}
opt = findOption(con->options, optString, '\0', &cb, &cbData,
singleDash);
- if (!opt && !singleDash) return POPT_ERROR_BADOPT;
+ if (!opt && !singleDash)
+ return POPT_ERROR_BADOPT;
}
if (!opt)
con->os->nextCharArg = origOptString + 1;
}
+ /* Process next short option */
if (con->os->nextCharArg) {
origOptString = con->os->nextCharArg;
@@ -383,9 +475,10 @@ int poptGetNextOpt(poptContext con) {
if (handleExec(con, NULL, *origOptString))
continue;
- opt = findOption(con->options, NULL, *origOptString, &cb,
+ opt = findOption(con->options, NULL, *origOptString, &cb,
&cbData, 0);
- if (!opt) return POPT_ERROR_BADOPT;
+ if (!opt)
+ return POPT_ERROR_BADOPT;
origOptString++;
if (*origOptString)
@@ -395,33 +488,43 @@ int poptGetNextOpt(poptContext con) {
if (opt->arg && (opt->argInfo & POPT_ARG_MASK) == POPT_ARG_NONE) {
*((int *)opt->arg) = 1;
} else if ((opt->argInfo & POPT_ARG_MASK) == POPT_ARG_VAL) {
- if (opt->arg) *((int *) opt->arg) = opt->val;
+ if (opt->arg)
+ *((int *) opt->arg) = opt->val;
} else if ((opt->argInfo & POPT_ARG_MASK) != POPT_ARG_NONE) {
+ if (con->os->nextArg) {
+ xfree(con->os->nextArg);
+ con->os->nextArg = NULL;
+ }
if (longArg) {
- con->os->nextArg = longArg;
+ con->os->nextArg = expandNextArg(con, longArg);
} else if (con->os->nextCharArg) {
- con->os->nextArg = con->os->nextCharArg;
+ con->os->nextArg = expandNextArg(con, con->os->nextCharArg);
con->os->nextCharArg = NULL;
- } else {
- while (con->os->next == con->os->argc &&
- con->os > con->optionStack)
- con->os--;
+ } else {
+ while (con->os->next == con->os->argc &&
+ con->os > con->optionStack) {
+ cleanOSE(con->os--);
+ }
if (con->os->next == con->os->argc)
return POPT_ERROR_NOARG;
- con->os->nextArg = con->os->argv[con->os->next++];
+ con->os->nextArg = expandNextArg(con, con->os->argv[con->os->next++]);
}
if (opt->arg) {
+ long aLong;
+ char *end;
+
switch (opt->argInfo & POPT_ARG_MASK) {
case POPT_ARG_STRING:
- *((const char **) opt->arg) = con->os->nextArg;
+ /* XXX memory leak, hard to plug */
+ *((const char **) opt->arg) = xstrdup(con->os->nextArg);
break;
case POPT_ARG_INT:
case POPT_ARG_LONG:
aLong = strtol(con->os->nextArg, &end, 0);
- if (!(end && *end == '\0'))
+ if (!(end && *end == '\0'))
return POPT_ERROR_BADNUMBER;
if (aLong == LONG_MIN || aLong == LONG_MAX)
@@ -431,14 +534,14 @@ int poptGetNextOpt(poptContext con) {
} else {
if (aLong > INT_MAX || aLong < INT_MIN)
return POPT_ERROR_OVERFLOW;
- *((int *) opt->arg) =aLong;
+ *((int *) opt->arg) = aLong;
}
break;
default:
fprintf(stdout, POPT_("option type (%d) not implemented in popt\n"),
opt->argInfo & POPT_ARG_MASK);
- exit(1);
+ exit(EXIT_FAILURE);
}
}
}
@@ -454,32 +557,32 @@ int poptGetNextOpt(poptContext con) {
sizeof(*con->finalArgv) * con->finalArgvAlloced);
}
- i = con->finalArgvCount++;
{ char *s = malloc((opt->longName ? strlen(opt->longName) : 0) + 3);
if (opt->longName)
sprintf(s, "--%s", opt->longName);
- else
+ else
sprintf(s, "-%c", opt->shortName);
- con->finalArgv[i] = s;
+ con->finalArgv[con->finalArgvCount++] = s;
}
if (opt->arg && (opt->argInfo & POPT_ARG_MASK) != POPT_ARG_NONE
- && (opt->argInfo & POPT_ARG_MASK) != POPT_ARG_VAL)
- con->finalArgv[con->finalArgvCount++] = strdup(con->os->nextArg);
+ && (opt->argInfo & POPT_ARG_MASK) != POPT_ARG_VAL) {
+ con->finalArgv[con->finalArgvCount++] = xstrdup(con->os->nextArg);
+ }
}
return opt->val;
}
-char * poptGetOptArg(poptContext con) {
- char * ret = (char *)con->os->nextArg; /* XXX don't change the API */
+const char * poptGetOptArg(poptContext con) {
+ const char * ret = con->os->nextArg;
con->os->nextArg = NULL;
return ret;
}
-char * poptGetArg(poptContext con) {
+const char * poptGetArg(poptContext con) {
if (con->numLeftovers == con->nextLeftover) return NULL;
- return (char *)con->leftovers[con->nextLeftover++]; /* XXX don't change the API */
+ return con->leftovers[con->nextLeftover++];
}
const char * poptPeekArg(poptContext con) {
@@ -499,6 +602,9 @@ const char ** poptGetArgs(poptContext con) {
void poptFreeContext(poptContext con) {
int i;
+ poptResetContext(con);
+ if (con->os->argb) free(con->os->argb);
+
for (i = 0; i < con->numAliases; i++) {
if (con->aliases[i].longName) xfree(con->aliases[i].longName);
free(con->aliases[i].argv);
@@ -508,9 +614,7 @@ void poptFreeContext(poptContext con) {
if (con->execs[i].longName) xfree(con->execs[i].longName);
xfree(con->execs[i].script);
}
-
- for (i = 0; i < con->finalArgvCount; i++)
- xfree(con->finalArgv[i]);
+ if (con->execs) xfree(con->execs);
free(con->leftovers);
free(con->finalArgv);
@@ -521,7 +625,9 @@ void poptFreeContext(poptContext con) {
free(con);
}
-int poptAddAlias(poptContext con, struct poptAlias newAlias, int flags) {
+int poptAddAlias(poptContext con, struct poptAlias newAlias,
+ /*@unused@*/ int flags)
+{
int aliasNum = con->numAliases++;
struct poptAlias * alias;
@@ -529,16 +635,16 @@ int poptAddAlias(poptContext con, struct poptAlias newAlias, int flags) {
if (!con->aliases)
con->aliases = malloc(sizeof(newAlias) * con->numAliases);
else
- con->aliases = realloc(con->aliases,
+ con->aliases = realloc(con->aliases,
sizeof(newAlias) * con->numAliases);
alias = con->aliases + aliasNum;
-
- *alias = newAlias;
- if (alias->longName)
- alias->longName = strcpy(malloc(strlen(alias->longName) + 1),
- alias->longName);
- else
- alias->longName = NULL;
+
+ alias->longName = (newAlias.longName)
+ ? strcpy(malloc(strlen(newAlias.longName) + 1), newAlias.longName)
+ : NULL;
+ alias->shortName = newAlias.shortName;
+ alias->argc = newAlias.argc;
+ alias->argv = newAlias.argv;
return 0;
}
@@ -560,7 +666,7 @@ const char * poptBadOption(poptContext con, int flags) {
#define POPT_ERROR_BADQUOTE -15 /* only from poptParseArgString() */
#define POPT_ERROR_ERRNO -16 /* only from poptParseArgString() */
-const char * poptStrerror(const int error) {
+const char *const poptStrerror(const int error) {
switch (error) {
case POPT_ERROR_NOARG:
return POPT_("missing argument");
@@ -582,19 +688,21 @@ const char * poptStrerror(const int error) {
}
int poptStuffArgs(poptContext con, const char ** argv) {
- int i;
+ int argc;
if ((con->os - con->optionStack) == POPT_OPTION_DEPTH)
return POPT_ERROR_OPTSTOODEEP;
- for (i = 0; argv[i]; i++);
+ for (argc = 0; argv[argc]; argc++)
+ ;
con->os++;
con->os->next = 0;
- con->os->nextArg = con->os->nextCharArg = NULL;
+ con->os->nextArg = NULL;
+ con->os->nextCharArg = NULL;
con->os->currAlias = NULL;
- con->os->argc = i;
- con->os->argv = argv;
+ poptDupArgv(argc, argv, &con->os->argc, &con->os->argv);
+ con->os->argb = NULL;
con->os->stuffed = 1;
return 0;
diff --git a/support/poptconfig.c b/support/poptconfig.c
index 2b44264..7a1a4c2 100644
--- a/support/poptconfig.c
+++ b/support/poptconfig.c
@@ -2,22 +2,7 @@
file accompanying popt source distributions, available from
ftp://ftp.redhat.com/pub/code/popt */
-#ifdef HAVE_CONFIG_H
-#include "config.h"
-#endif
-
-#include <ctype.h>
-#include <errno.h>
-#include <fcntl.h>
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
-
-#if HAVE_ALLOCA_H
-# include <alloca.h>
-#endif
-
-#include "popt-gnome.h"
+#include "system.h"
#include "poptint.h"
static void configLine(poptContext con, char * line) {
@@ -51,19 +36,19 @@ static void configLine(poptContext con, char * line) {
shortName = opt[1];
if (!strcmp(entryType, "alias")) {
- if (poptParseArgvString(line, &alias.argc, (char ***)&alias.argv)) return;
+ if (poptParseArgvString(line, &alias.argc, &alias.argv)) return;
alias.longName = longName, alias.shortName = shortName;
poptAddAlias(con, alias, 0);
} else if (!strcmp(entryType, "exec")) {
- con->execs = realloc(con->execs,
+ con->execs = realloc(con->execs,
sizeof(*con->execs) * (con->numExecs + 1));
if (longName)
- con->execs[con->numExecs].longName = strdup(longName);
+ con->execs[con->numExecs].longName = xstrdup(longName);
else
con->execs[con->numExecs].longName = NULL;
con->execs[con->numExecs].shortName = shortName;
- con->execs[con->numExecs].script = strdup(line);
+ con->execs[con->numExecs].script = xstrdup(line);
con->numExecs++;
}
@@ -84,7 +69,7 @@ int poptReadConfigFile(poptContext con, const char * fn) {
}
fileLength = lseek(fd, 0, SEEK_END);
- lseek(fd, 0, 0);
+ (void) lseek(fd, 0, 0);
file = alloca(fileLength + 1);
if (read(fd, file, fileLength) != fileLength) {
@@ -122,13 +107,14 @@ int poptReadConfigFile(poptContext con, const char * fn) {
break;
default:
*dst++ = *chptr++;
+ break;
}
}
return 0;
}
-int poptReadDefaultConfig(poptContext con, int useEnv) {
+int poptReadDefaultConfig(poptContext con, /*@unused@*/ int useEnv) {
char * fn, * home;
int rc;
diff --git a/support/popthelp.c b/support/popthelp.c
index fc2764a..c36ecea 100644
--- a/support/popthelp.c
+++ b/support/popthelp.c
@@ -4,25 +4,13 @@
file accompanying popt source distributions, available from
ftp://ftp.redhat.com/pub/code/popt */
-#ifdef HAVE_CONFIG_H
-#include "config.h"
-#endif
-
-#include <ctype.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-
-#ifdef HAVE_ALLOCA_H
-#include <alloca.h>
-#endif
-
-#include "popt-gnome.h"
+#include "system.h"
#include "poptint.h"
-static void displayArgs(poptContext con, enum poptCallbackReason foo,
- struct poptOption * key,
- const char * arg, void * data) {
+static void displayArgs(poptContext con,
+ /*@unused@*/ enum poptCallbackReason foo,
+ struct poptOption * key,
+ /*@unused@*/ const char * arg, /*@unused@*/ void * data) {
if (key->shortName== '?')
poptPrintHelp(con, stdout, 0);
else
@@ -31,14 +19,14 @@ static void displayArgs(poptContext con, enum poptCallbackReason foo,
}
struct poptOption poptHelpOptions[] = {
- { NULL, '\0', POPT_ARG_CALLBACK, (void *)&displayArgs, '\0', NULL },
- { "help", '?', 0, NULL, '?', N_("Show this help message") },
- { "usage", '\0', 0, NULL, 'u', N_("Display brief usage message") },
- { NULL, '\0', 0, NULL, 0 }
+ { NULL, '\0', POPT_ARG_CALLBACK, (void *)&displayArgs, '\0', NULL, NULL },
+ { "help", '?', 0, NULL, '?', N_("Show this help message"), NULL },
+ { "usage", '\0', 0, NULL, 'u', N_("Display brief usage message"), NULL },
+ { NULL, '\0', 0, NULL, 0, NULL, NULL }
} ;
-static const char *
+/*@observer@*/ /*@null@*/ static const char *const
getTableTranslationDomain(const struct poptOption *table)
{
const struct poptOption *opt;
@@ -53,8 +41,9 @@ getTableTranslationDomain(const struct poptOption *table)
return NULL;
}
-static const char * getArgDescrip(const struct poptOption * opt,
- const char *translation_domain) {
+/*@observer@*/ /*@null@*/ static const char *const
+getArgDescrip(const struct poptOption * opt, const char *translation_domain)
+{
if (!(opt->argInfo & POPT_ARG_MASK)) return NULL;
if (opt == (poptHelpOptions + 1) || opt == (poptHelpOptions + 2))
@@ -193,7 +182,7 @@ static int showHelpIntro(poptContext con, FILE * f) {
return len;
}
-void poptPrintHelp(poptContext con, FILE * f, int flags) {
+void poptPrintHelp(poptContext con, FILE * f, /*@unused@*/ int flags) {
int leftColWidth;
showHelpIntro(con, f);
@@ -210,7 +199,7 @@ static int singleOptionUsage(FILE * f, int cursor,
const struct poptOption * opt,
const char *translation_domain) {
int len = 3;
- char shortStr[2];
+ char shortStr[2] = { '\0', '\0' };
const char * item = shortStr;
const char * argDescrip = getArgDescrip(opt, translation_domain);
@@ -268,9 +257,10 @@ static int showShortOptions(const struct poptOption * opt, FILE * f,
char s[300]; /* this is larger then the ascii set, so
it should do just fine */
- if (!str) {
+ s[0] = '\0';
+ if (str == NULL) {
+ memset(s, 0, sizeof(s));
str = s;
- memset(str, 0, sizeof(s));
}
while (opt->longName || opt->shortName || opt->arg) {
@@ -289,7 +279,7 @@ static int showShortOptions(const struct poptOption * opt, FILE * f,
return strlen(s) + 4;
}
-void poptPrintUsage(poptContext con, FILE * f, int flags) {
+void poptPrintUsage(poptContext con, FILE * f, /*@unused@*/ int flags) {
int cursor;
cursor = showHelpIntro(con, f);
@@ -307,5 +297,5 @@ void poptPrintUsage(poptContext con, FILE * f, int flags) {
void poptSetOtherOptionHelp(poptContext con, const char * text) {
if (con->otherHelp) xfree(con->otherHelp);
- con->otherHelp = strdup(text);
+ con->otherHelp = xstrdup(text);
}
diff --git a/support/poptint.h b/support/poptint.h
index 62cc60a..1688095 100644
--- a/support/poptint.h
+++ b/support/poptint.h
@@ -5,13 +5,30 @@
#ifndef H_POPTINT
#define H_POPTINT
+/* Bit mask macros. */
+typedef unsigned int __pbm_bits;
+#define __PBM_NBITS (8 * sizeof (__pbm_bits))
+#define __PBM_IX(d) ((d) / __PBM_NBITS)
+#define __PBM_MASK(d) ((__pbm_bits) 1 << ((d) % __PBM_NBITS))
+typedef struct {
+ __pbm_bits bits[1];
+} pbm_set;
+#define __PBM_BITS(set) ((set)->bits)
+
+#define PBM_ALLOC(d) calloc(__PBM_IX (d) + 1, sizeof(__pbm_bits))
+#define PBM_FREE(s) free(s);
+#define PBM_SET(d, s) (__PBM_BITS (s)[__PBM_IX (d)] |= __PBM_MASK (d))
+#define PBM_CLR(d, s) (__PBM_BITS (s)[__PBM_IX (d)] &= ~__PBM_MASK (d))
+#define PBM_ISSET(d, s) ((__PBM_BITS (s)[__PBM_IX (d)] & __PBM_MASK (d)) != 0)
+
struct optionStackEntry {
int argc;
- const char ** argv;
+ /*@only@*/ const char ** argv;
+ /*@only@*/ pbm_set * argb;
int next;
- const char * nextArg;
- const char * nextCharArg;
- struct poptAlias * currAlias;
+ /*@only@*/ const char * nextArg;
+ /*@keep@*/ const char * nextCharArg;
+ /*@dependent@*/ struct poptAlias * currAlias;
int stuffed;
};
@@ -22,25 +39,26 @@ struct execEntry {
};
struct poptContext_s {
- struct optionStackEntry optionStack[POPT_OPTION_DEPTH], * os;
- const char ** leftovers;
+ struct optionStackEntry optionStack[POPT_OPTION_DEPTH];
+ /*@dependent@*/ struct optionStackEntry * os;
+ /*@owned@*/ const char ** leftovers;
int numLeftovers;
int nextLeftover;
- const struct poptOption * options;
+ /*@keep@*/ const struct poptOption * options;
int restLeftover;
- const char * appName;
- struct poptAlias * aliases;
+ /*@only@*/ const char * appName;
+ /*@only@*/ struct poptAlias * aliases;
int numAliases;
int flags;
struct execEntry * execs;
int numExecs;
- const char ** finalArgv;
+ /*@only@*/ const char ** finalArgv;
int finalArgvCount;
int finalArgvAlloced;
- struct execEntry * doExec;
- const char * execPath;
+ /*@dependent@*/ struct execEntry * doExec;
+ /*@only@*/ const char * execPath;
int execAbsolute;
- const char * otherHelp;
+ /*@only@*/ const char * otherHelp;
};
#define xfree(_a) free((void *)_a)
@@ -49,13 +67,13 @@ struct poptContext_s {
#include <libintl.h>
#endif
-#ifdef HAVE_GETTEXT
+#if defined(HAVE_GETTEXT) && !defined(__LCLINT__)
#define _(foo) gettext(foo)
#else
#define _(foo) (foo)
#endif
-#ifdef HAVE_DGETTEXT
+#if defined(HAVE_DGETTEXT) && !defined(__LCLINT__)
#define D_(dom, str) dgettext(dom, str)
#define POPT_(foo) D_("popt", foo)
#else
diff --git a/support/poptparse.c b/support/poptparse.c
index fa70815..65c948b 100644
--- a/support/poptparse.c
+++ b/support/poptparse.c
@@ -2,53 +2,53 @@
file accompanying popt source distributions, available from
ftp://ftp.redhat.com/pub/code/popt */
-#ifdef HAVE_CONFIG_H
-#include "config.h"
-#endif
+#include "system.h"
+#include "poptint.h"
-#include <ctype.h>
-#include <stdlib.h>
-#include <string.h>
-
-/* AIX requires this to be the first thing in the file. */
-#ifndef __GNUC__
-# if HAVE_ALLOCA_H
-# include <alloca.h>
-# else
-# ifdef _AIX
-#pragma alloca
-# else
-# ifndef alloca /* predefined by HP cc +Olibcalls */
-char *alloca ();
-# endif
-# endif
-# endif
-#elif defined(__GNUC__) && defined(__STRICT_ANSI__)
-#define alloca __builtin_alloca
-#endif
+#define POPT_ARGV_ARRAY_GROW_DELTA 5
-#include "popt-gnome.h"
+int poptDupArgv(int argc, const char **argv,
+ int * argcPtr, const char *** argvPtr)
+{
+ size_t nb = (argc + 1) * sizeof(*argv);
+ const char ** argv2;
+ char * dst;
+ int i;
-#define POPT_ARGV_ARRAY_GROW_DELTA 5
+ for (i = 0; i < argc; i++) {
+ if (argv[i] == NULL)
+ return POPT_ERROR_NOARG;
+ nb += strlen(argv[i]) + 1;
+ }
+
+ dst = malloc(nb);
+ argv2 = (void *) dst;
+ dst += (argc + 1) * sizeof(*argv);
+
+ for (i = 0; i < argc; i++) {
+ argv2[i] = dst;
+ dst += strlen(strcpy(dst, argv[i])) + 1;
+ }
+ argv2[argc] = NULL;
+
+ *argvPtr = argv2;
+ *argcPtr = argc;
+ return 0;
+}
-int poptParseArgvString(const char * s, int * argcPtr, char *** argvPtr) {
- char * buf, * bufStart, * dst;
+int poptParseArgvString(const char * s, int * argcPtr, const char *** argvPtr)
+{
const char * src;
char quote = '\0';
int argvAlloced = POPT_ARGV_ARRAY_GROW_DELTA;
- char ** argv = malloc(sizeof(*argv) * argvAlloced);
- const char ** argv2;
+ const char ** argv = malloc(sizeof(*argv) * argvAlloced);
int argc = 0;
- int i, buflen;
-
- buflen = strlen(s) + 1;
- bufStart = buf = alloca(buflen);
- memset(buf, '\0', buflen);
+ int buflen = strlen(s) + 1;
+ char * buf = memset(alloca(buflen), 0, buflen);
- src = s;
argv[argc] = buf;
- while (*src) {
+ for (src = s; *src; src++) {
if (quote == *src) {
quote = '\0';
} else if (quote) {
@@ -81,33 +81,38 @@ int poptParseArgvString(const char * s, int * argcPtr, char *** argvPtr) {
free(argv);
return POPT_ERROR_BADQUOTE;
}
- /* fallthrough */
+ /*@fallthrough@*/
default:
*buf++ = *src;
+ break;
}
-
- src++;
}
if (strlen(argv[argc])) {
argc++, buf++;
}
- dst = malloc((argc + 1) * sizeof(*argv) + (buf - bufStart));
- argv2 = (void *) dst;
- dst += (argc + 1) * sizeof(*argv);
- memcpy(argv2, argv, argc * sizeof(*argv));
- argv2[argc] = NULL;
- memcpy(dst, bufStart, buf - bufStart);
+#if 0
+ { char * dst = malloc((argc + 1) * sizeof(*argv) + (buf - argv[0]));
+ const char ** argv2 = (void *) dst;
+ int i;
- for (i = 0; i < argc; i++) {
- argv2[i] = dst + (argv[i] - bufStart);
+ dst += (argc + 1) * sizeof(*argv);
+ memcpy(argv2, argv, argc * sizeof(*argv));
+ argv2[argc] = NULL;
+ memcpy(dst, argv[0], buf - argv[0]);
+
+ for (i = 0; i < argc; i++)
+ argv2[i] = dst + (argv[i] - argv[0]);
+
+ *argvPtr = argv2;
+ *argcPtr = argc;
}
+#else
+ (void) poptDupArgv(argc, argv, argcPtr, argvPtr);
+#endif
free(argv);
- *argvPtr = (char **)argv2; /* XXX don't change the API */
- *argcPtr = argc;
-
return 0;
}
diff --git a/support/system.h b/support/system.h
new file mode 100644
index 0000000..0f888f4
--- /dev/null
+++ b/support/system.h
@@ -0,0 +1,55 @@
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include <ctype.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <limits.h>
+
+#if HAVE_MCHECK_H
+#include <mcheck.h>
+#endif
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+#if HAVE_UNISTD_H
+#include <unistd.h>
+#endif
+
+#ifdef __NeXT
+/* access macros are not declared in non posix mode in unistd.h -
+ don't try to use posix on NeXTstep 3.3 ! */
+#include <libc.h>
+#endif
+
+/* AIX requires this to be the first thing in the file. */
+#ifndef __GNUC__
+# if HAVE_ALLOCA_H
+# include <alloca.h>
+# else
+# ifdef _AIX
+#pragma alloca
+# else
+# ifndef alloca /* predefined by HP cc +Olibcalls */
+char *alloca ();
+# endif
+# endif
+# endif
+#elif defined(__GNUC__) && defined(__STRICT_ANSI__)
+#define alloca __builtin_alloca
+#endif
+
+/*@only@*/ char * xstrdup (const char *str);
+
+#if HAVE_MCHECK_H && defined(__GNUC__)
+#define vmefail() (fprintf(stderr, "virtual memory exhausted.\n"), exit(EXIT_FAILURE), NULL)
+#define xstrdup(_str) (strcpy((malloc(strlen(_str)+1) ? : vmefail()), (_str)))
+#else
+#define xstrdup(_str) strdup(_str)
+#endif /* HAVE_MCHECK_H && defined(__GNUC__) */
+
+
+#include "popt-gnome.h"