diff options
| author | Torbjorn Granlund <tege@gmplib.org> | 2011-03-07 00:23:06 +0100 |
|---|---|---|
| committer | Torbjorn Granlund <tege@gmplib.org> | 2011-03-07 00:23:06 +0100 |
| commit | 2ea76943469f654a4f20fd79600d1cb87630b744 (patch) | |
| tree | fa6a6da914788eda218adc9f1a3cbb99642ed7ca /mpn/x86 | |
| parent | 65f541e372ae6f8639720379d905084bbc07cf8c (diff) | |
| download | gmp-2ea76943469f654a4f20fd79600d1cb87630b744.tar.gz | |
Fix out-of-bounds read for n=1.
Diffstat (limited to 'mpn/x86')
| -rw-r--r-- | mpn/x86/atom/sse2/sqr_basecase.asm | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/mpn/x86/atom/sse2/sqr_basecase.asm b/mpn/x86/atom/sse2/sqr_basecase.asm index fbbebaf41..0f76a4d13 100644 --- a/mpn/x86/atom/sse2/sqr_basecase.asm +++ b/mpn/x86/atom/sse2/sqr_basecase.asm @@ -63,6 +63,10 @@ PROLOGUE(mpn_sqr_basecase) lea -1(n), %eax neg n movd (up), %mm7 + + test %eax, %eax + jz L(one) + movd 4(up), %mm0 lea 4(up), up pmuludq %mm7, %mm0 @@ -114,15 +118,12 @@ C jz L(done) jmp L(ol2) C ================================================================ -L(of0): test n, n - jz L(one) - jmp L(xx0) ALIGN(16) L(lm0): movd (up), %mm0 pmuludq %mm7, %mm0 psrlq $32, %mm6 lea 16(rp), rp -L(xx0): paddq %mm0, %mm6 +L(of0): paddq %mm0, %mm6 movd 4(up), %mm0 pmuludq %mm7, %mm0 movd %mm6, (rp) @@ -603,8 +604,7 @@ L(rtn): emms pop %edi ret -L(one): movd -4(up), %mm0 - pmuludq %mm0, %mm0 - movq %mm0, -4(rp) +L(one): pmuludq %mm7, %mm7 + movq %mm7, -4(rp) jmp L(rtn) EPILOGUE() |