diff options
| author | Daniel Boles <dboles@src.gnome.org> | 2017-01-30 20:55:33 +0000 |
|---|---|---|
| committer | Daniel Boles <dboles@src.gnome.org> | 2017-02-02 08:43:13 +0000 |
| commit | 25cf234fc1146a35869c169bade05ad6edeb80e5 (patch) | |
| tree | f740a13a1dc55a91b09dfde484bf3dae1ecf543c | |
| parent | d8c7652475f3c52494606ab554ebcc762dab5beb (diff) | |
| download | glibmm-25cf234fc1146a35869c169bade05ad6edeb80e5.tar.gz | |
Gio::Action: #include <glibmm/variant.h> in hg
Currently, it is included indirectly, via 3 other headers. This is
brittle. Without that, users of action.h would have to manually include
variant.h to use methods returning the forward-declared VariantBase,
which isn’t very helpful. Plus, the header uses types like Variant<>
templates and VariantContainerBase, which were never forward-declared.
Including it directly makes the dependency more obvious and less brittle
and spares us from having to write a bunch more forward-declarations.
https://bugzilla.gnome.org/show_bug.cgi?id=777953
| -rw-r--r-- | gio/src/action.hg | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/gio/src/action.hg b/gio/src/action.hg index b9b59932..067a230c 100644 --- a/gio/src/action.hg +++ b/gio/src/action.hg @@ -18,6 +18,7 @@ _CONFIGINCLUDE(giommconfig.h) #include <glibmm/interface.h> +#include <glibmm/variant.h> #include <glibmm/varianttype.h> #include <gio/gio.h> @@ -29,13 +30,6 @@ _PINCLUDE(gio/gio.h) typedef struct _GActionInterface GActionInterface; #endif /* DOXYGEN_SHOULD_SKIP_THIS */ -namespace Glib -{ - -class VariantBase; - -} - namespace Gio { |