hurd: clean fd and port on thread cancel

HURD_*PORT_USE link fd and port with a stack-stored structure, so on
thread cancel we need to cleanup this.

* hurd/fd-cleanup.c: New file.
* hurd/port-cleanup.c (_hurd_port_use_cleanup): New function.
* hurd/Makefile (routines): Add fd-cleanup.
* sysdeps/hurd/include/hurd.h (__USEPORT_CANCEL): New macro.
* sysdeps/hurd/include/hurd/fd.h (_hurd_fd_port_use_data): New
structure.
(_hurd_fd_port_use_cleanup): New prototype.
(HURD_DPORT_USE_CANCEL, HURD_FD_PORT_USE_CANCEL): New macros.
* sysdeps/hurd/include/hurd/port.h (_hurd_port_use_data): New structure.
(_hurd_port_use_cleanup): New prototype.
(HURD_PORT_USE_CANCEL): New macro.
* hurd/hurd/fd.h (HURD_FD_PORT_USE): Also refer to HURD_FD_PORT_USE_CANCEL.
* hurd/hurd.h (__USEPORT): Also refer to __USEPORT_CANCEL.
* hurd/hurd/port.h (HURD_PORT_USE): Also refer to HURD_PORT_USE_CANCEL.

* hurd/fd-read.c (_hurd_fd_read): Call HURD_FD_PORT_USE_CANCEL instead
of HURD_FD_PORT_USE.
* hurd/fd-write.c (_hurd_fd_write): Likewise.
* sysdeps/mach/hurd/send.c (__send): Call HURD_DPORT_USE_CANCEL instead
of HURD_DPORT_USE.
* sysdeps/mach/hurd/sendmsg.c (__libc_sendmsg): Likewise.
* sysdeps/mach/hurd/sendto.c (__sendto): Likewise.
* sysdeps/mach/hurd/recv.c (__recv): Likewise.
* sysdeps/mach/hurd/recvfrom.c (__recvfrom): Likewise.
* sysdeps/mach/hurd/recvmsg.c (__libc_recvmsg): Call __USEPORT_CANCEL
instead of __USEPORT, and HURD_DPORT_USE_CANCEL instead of
HURD_DPORT_USE.

9 files changed, 94 insertions, 24 deletions

diff --git a/sysdeps/hurd/include/hurd.h b/sysdeps/hurd/include/hurd.h
index d29f580d5b..dc877173b5 100644
--- a/sysdeps/hurd/include/hurd.h
+++ b/sysdeps/hurd/include/hurd.h
@@ -1,5 +1,10 @@
 #ifndef	_HURD_H
 #include_next <hurd.h>
+
+/* Like __USEPORT, but cleans fd on cancel.  */
+#define	__USEPORT_CANCEL(which, expr) \
+  HURD_PORT_USE_CANCEL (&_hurd_ports[INIT_PORT_##which], (expr))
+
 #ifndef _ISOMAC
 libc_hidden_proto (_hurd_exec_paths)
 libc_hidden_proto (_hurd_init)
diff --git a/sysdeps/hurd/include/hurd/fd.h b/sysdeps/hurd/include/hurd/fd.h
index 1f3ac380a0..3a6cdc7f36 100644
--- a/sysdeps/hurd/include/hurd/fd.h
+++ b/sysdeps/hurd/include/hurd/fd.h
@@ -1,6 +1,47 @@
 #ifndef	_HURD_FD_H
 #include_next <hurd/fd.h>
+
 #ifndef _ISOMAC
+#include <libc-lock.h>
+
+struct _hurd_fd_port_use_data
+  {
+     struct hurd_fd *d;
+     struct hurd_userlink ulink, ctty_ulink;
+     io_t port, ctty;
+  };
+
+extern void _hurd_fd_port_use_cleanup (void *arg);
+
+/* Like HURD_DPORT_USE, but cleans fd on cancel.  */
+#define HURD_DPORT_USE_CANCEL(fd, expr) \
+  HURD_FD_USE ((fd), HURD_FD_PORT_USE_CANCEL (descriptor, (expr)))
+
+/* Like HURD_FD_PORT_USE, but cleans fd on cancel.  */
+#define	HURD_FD_PORT_USE_CANCEL(fd, expr)				      \
+  ({ error_t __result;							      \
+     void *__crit = _hurd_critical_section_lock ();			      \
+     struct _hurd_fd_port_use_data __d;					      \
+     io_t port, ctty;							      \
+     __d.d = (fd);							      \
+     __spin_lock (&__d.d->port.lock);					      \
+     if (__d.d->port.port == MACH_PORT_NULL)				      \
+       {								      \
+	 __spin_unlock (&__d.d->port.lock);				      \
+	 _hurd_critical_section_unlock (__crit);			      \
+	 __result = EBADF;						      \
+       }								      \
+     else								      \
+       {								      \
+	 __d.ctty = ctty = _hurd_port_get (&__d.d->ctty, &__d.ctty_ulink);    \
+	 __d.port = port = _hurd_port_locked_get (&__d.d->port, &__d.ulink);  \
+	 __libc_cleanup_push (_hurd_fd_port_use_cleanup, &__d);		      \
+	 _hurd_critical_section_unlock (__crit);			      \
+	 __result = (expr);						      \
+	 __libc_cleanup_pop (1);					      \
+       }								      \
+     __result; })
+
 libc_hidden_proto (_hurd_intern_fd)
 libc_hidden_proto (_hurd_fd_error)
 libc_hidden_proto (_hurd_fd_error_signal)
diff --git a/sysdeps/hurd/include/hurd/port.h b/sysdeps/hurd/include/hurd/port.h
index ca1d2d111a..7828dd6fc1 100644
--- a/sysdeps/hurd/include/hurd/port.h
+++ b/sysdeps/hurd/include/hurd/port.h
@@ -1,6 +1,30 @@
 #ifndef	_HURD_PORT_H
 #include_next <hurd/port.h>
+
 #ifndef _ISOMAC
+struct _hurd_port_use_data
+  {
+     struct hurd_port *p;
+     struct hurd_userlink link;
+     mach_port_t port;
+  };
+
+extern void _hurd_port_use_cleanup (void *arg);
+
+/* Like HURD_PORT_USE, but cleans fd on cancel.  */
+#define	HURD_PORT_USE_CANCEL(portcell, expr)				      \
+  ({ struct _hurd_port_use_data __d;					      \
+     __typeof(expr) __result;						      \
+     void *__crit;							      \
+     __d.p = (portcell);						      \
+     __crit = _hurd_critical_section_lock ();				      \
+     __d.port = port = _hurd_port_get (__d.p, &__d.link);		      \
+     __libc_cleanup_push (_hurd_port_use_cleanup, &__d);		      \
+     _hurd_critical_section_unlock (__crit);				      \
+     __result = (expr);							      \
+     __libc_cleanup_pop (1);						      \
+     __result; })
+
 libc_hidden_proto (_hurd_port_locked_get)
 libc_hidden_proto (_hurd_port_locked_set)
 #ifdef _HURD_PORT_H_HIDDEN_DEF
diff --git a/sysdeps/mach/hurd/recv.c b/sysdeps/mach/hurd/recv.c
index b9ed067265..4fa2f79dcd 100644
--- a/sysdeps/mach/hurd/recv.c
+++ b/sysdeps/mach/hurd/recv.c
@@ -40,12 +40,12 @@ __recv (int fd, void *buf, size_t n, int flags)
   int cancel_oldtype;
 
   cancel_oldtype = LIBC_CANCEL_ASYNC();
-  err = HURD_DPORT_USE (fd, __socket_recv (port, &addrport,
-					       flags, &bufp, &nread,
-					       &ports, &nports,
-					       &cdata, &clen,
-					       &flags,
-					       n));
+  err = HURD_DPORT_USE_CANCEL (fd, __socket_recv (port, &addrport,
+						  flags, &bufp, &nread,
+						  &ports, &nports,
+						  &cdata, &clen,
+						  &flags,
+						  n));
   LIBC_CANCEL_RESET (cancel_oldtype);
 
   if (err == MIG_BAD_ID || err == EOPNOTSUPP)
diff --git a/sysdeps/mach/hurd/recvfrom.c b/sysdeps/mach/hurd/recvfrom.c
index ed3d970722..2cd7092088 100644
--- a/sysdeps/mach/hurd/recvfrom.c
+++ b/sysdeps/mach/hurd/recvfrom.c
@@ -43,12 +43,12 @@ __recvfrom (int fd, void *buf, size_t n, int flags, __SOCKADDR_ARG addrarg,
   int cancel_oldtype;
 
   cancel_oldtype = LIBC_CANCEL_ASYNC();
-  err = HURD_DPORT_USE (fd, __socket_recv (port, &addrport,
-					   flags, &bufp, &nread,
-					   &ports, &nports,
-					   &cdata, &clen,
-					   &flags,
-					   n));
+  err = HURD_DPORT_USE_CANCEL (fd, __socket_recv (port, &addrport,
+						  flags, &bufp, &nread,
+						  &ports, &nports,
+						  &cdata, &clen,
+						  &flags,
+						  n));
   LIBC_CANCEL_RESET (cancel_oldtype);
 
   if (err)
diff --git a/sysdeps/mach/hurd/recvmsg.c b/sysdeps/mach/hurd/recvmsg.c
index 75c5f37f0e..5ac130fed1 100644
--- a/sysdeps/mach/hurd/recvmsg.c
+++ b/sysdeps/mach/hurd/recvmsg.c
@@ -58,7 +58,7 @@ __libc_recvmsg (int fd, struct msghdr *message, int flags)
       while (err == EINTR);
       if (!err)
 	do
-	  err = __USEPORT (AUTH, __auth_user_authenticate (port,
+	  err = __USEPORT_CANCEL (AUTH, __auth_user_authenticate (port,
 					  ref, MACH_MSG_TYPE_MAKE_SEND,
 					  result));
 	while (err == EINTR);
@@ -86,11 +86,11 @@ __libc_recvmsg (int fd, struct msghdr *message, int flags)
 
   buf = data;
   cancel_oldtype = LIBC_CANCEL_ASYNC();
-  err = HURD_DPORT_USE (fd, __socket_recv (port, &aport,
-					   flags, &data, &len,
-					   &ports, &nports,
-					   &cdata, &clen,
-					   &message->msg_flags, amount));
+  err = HURD_DPORT_USE_CANCEL (fd, __socket_recv (port, &aport,
+						  flags, &data, &len,
+						  &ports, &nports,
+						  &cdata, &clen,
+						  &message->msg_flags, amount));
   LIBC_CANCEL_RESET (cancel_oldtype);
   if (err)
     return __hurd_sockfail (fd, flags, err);
diff --git a/sysdeps/mach/hurd/send.c b/sysdeps/mach/hurd/send.c
index 78edbc2ff3..5be6c3a773 100644
--- a/sysdeps/mach/hurd/send.c
+++ b/sysdeps/mach/hurd/send.c
@@ -31,10 +31,10 @@ __send (int fd, const void *buf, size_t n, int flags)
   int cancel_oldtype;
 
   cancel_oldtype = LIBC_CANCEL_ASYNC();
-  err = HURD_DPORT_USE (fd, __socket_send (port, MACH_PORT_NULL,
-					   flags, buf, n,
-					   NULL, MACH_MSG_TYPE_COPY_SEND, 0,
-					   NULL, 0, &wrote));
+  err = HURD_DPORT_USE_CANCEL (fd, __socket_send (port, MACH_PORT_NULL,
+						  flags, buf, n,
+						  NULL, MACH_MSG_TYPE_COPY_SEND, 0,
+						  NULL, 0, &wrote));
   LIBC_CANCEL_RESET (cancel_oldtype);
 
   if (err == MIG_BAD_ID || err == EOPNOTSUPP)
diff --git a/sysdeps/mach/hurd/sendmsg.c b/sysdeps/mach/hurd/sendmsg.c
index 37ab7f3ce0..d8764c1248 100644
--- a/sysdeps/mach/hurd/sendmsg.c
+++ b/sysdeps/mach/hurd/sendmsg.c
@@ -174,7 +174,7 @@ __libc_sendmsg (int fd, const struct msghdr *message, int flags)
 	err = EIEIO;
     }
 
-  err = HURD_DPORT_USE (fd,
+  err = HURD_DPORT_USE_CANCEL (fd,
 			({
 			  if (err)
 			    err = __socket_create_address (port,
diff --git a/sysdeps/mach/hurd/sendto.c b/sysdeps/mach/hurd/sendto.c
index a5faf8ea2e..aab3d3dcae 100644
--- a/sysdeps/mach/hurd/sendto.c
+++ b/sysdeps/mach/hurd/sendto.c
@@ -73,7 +73,7 @@ __sendto (int fd,
       return err_port;
     }
 
-  err = HURD_DPORT_USE (fd,
+  err = HURD_DPORT_USE_CANCEL (fd,
 			({
 			  if (addr != NULL)
 			    err = create_address_port (port, addr, addr_len,