diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2019-02-01 12:22:33 -0800 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2019-02-02 05:36:53 -0800 |
| commit | c69b892fea74b025ca300005f2971f6a872d8497 (patch) | |
| tree | 9d5a7c38ff54981bc6a61f4b8a7d271eb59731ed /sysdeps/x86_64/x32/Makefile | |
| parent | 80647620ced948090360fb6bd62eba4bf1c6436d (diff) | |
| download | glibc-c69b892fea74b025ca300005f2971f6a872d8497.tar.gz | |
x86-64 strncmp family: Properly handle the length parameter [BZ #24097]
On x32, the size_t parameter may be passed in the lower 32 bits of a
64-bit register with the non-zero upper 32 bits. The string/memory
functions written in assembly can only use the lower 32 bits of a
64-bit register as length or must clear the upper 32 bits before using
the full 64-bit register for length.
This pach fixes the strncmp family for x32. Tested on x86-64 and x32.
On x86-64, libc.so is the same with and withou the fix.
[BZ #24097]
CVE-2019-6488
* sysdeps/x86_64/multiarch/strcmp-sse42.S: Use RDX_LP for length.
* sysdeps/x86_64/strcmp.S: Likewise.
* sysdeps/x86_64/x32/Makefile (tests): Add tst-size_t-strncasecmp,
tst-size_t-strncmp and tst-size_t-wcsncmp.
* sysdeps/x86_64/x32/tst-size_t-strncasecmp.c: New file.
* sysdeps/x86_64/x32/tst-size_t-strncmp.c: Likewise.
* sysdeps/x86_64/x32/tst-size_t-wcsncmp.c: Likewise.
(cherry picked from commit ee915088a0231cd421054dbd8abab7aadf331153)
Diffstat (limited to 'sysdeps/x86_64/x32/Makefile')
| -rw-r--r-- | sysdeps/x86_64/x32/Makefile | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sysdeps/x86_64/x32/Makefile b/sysdeps/x86_64/x32/Makefile index abe6ca0670..c10c7a8aab 100644 --- a/sysdeps/x86_64/x32/Makefile +++ b/sysdeps/x86_64/x32/Makefile @@ -7,9 +7,10 @@ endif ifeq ($(subdir),string) tests += tst-size_t-memchr tst-size_t-memcmp tst-size_t-memcpy \ - tst-size_t-memrchr tst-size_t-memset + tst-size_t-memrchr tst-size_t-memset tst-size_t-strncasecmp \ + tst-size_t-strncmp endif ifeq ($(subdir),wcsmbs) -tests += tst-size_t-wmemcmp +tests += tst-size_t-wmemcmp tst-size_t-wcsncmp endif |