diff options
| author | Fangrui Song <maskray@google.com> | 2022-04-26 09:26:22 -0700 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2022-04-26 09:26:22 -0700 |
| commit | 098a657fe449a217cf65c5270d5fbc8d40b5b4e6 (patch) | |
| tree | 3721fb17b7746c4dfbe411439f84699f7e6c17a3 /sysdeps/riscv | |
| parent | e465d97653311c3687aee49de782177353acfe86 (diff) | |
| download | glibc-098a657fe449a217cf65c5270d5fbc8d40b5b4e6.tar.gz | |
elf: Replace PI_STATIC_AND_HIDDEN with opposite HIDDEN_VAR_NEEDS_DYNAMIC_RELOC
PI_STATIC_AND_HIDDEN indicates whether accesses to internal linkage
variables and hidden visibility variables in a shared object (ld.so)
need dynamic relocations (usually R_*_RELATIVE). PI (position
independent) in the macro name is a misnomer: a code sequence using GOT
is typically position-independent as well, but using dynamic relocations
does not meet the requirement.
Not defining PI_STATIC_AND_HIDDEN is legacy and we expect that all new
ports will define PI_STATIC_AND_HIDDEN. Current ports defining
PI_STATIC_AND_HIDDEN are more than the opposite. Change the configure
default.
No functional change.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Diffstat (limited to 'sysdeps/riscv')
| -rw-r--r-- | sysdeps/riscv/configure | 3 | ||||
| -rw-r--r-- | sysdeps/riscv/configure.ac | 2 |
2 files changed, 0 insertions, 5 deletions
diff --git a/sysdeps/riscv/configure b/sysdeps/riscv/configure index 4a56fca94b..2372225a26 100644 --- a/sysdeps/riscv/configure +++ b/sysdeps/riscv/configure @@ -1,9 +1,6 @@ # This file is generated from configure.ac by Autoconf. DO NOT EDIT! # Local configure fragment for sysdeps/riscv/elf. -$as_echo "#define PI_STATIC_AND_HIDDEN 1" >>confdefs.h - - # Check if static linker supports R_RISCV_ALIGN { $as_echo "$as_me:${as_lineno-$LINENO}: checking for R_RISCV_ALIGN linker relaxation support" >&5 $as_echo_n "checking for R_RISCV_ALIGN linker relaxation support... " >&6; } diff --git a/sysdeps/riscv/configure.ac b/sysdeps/riscv/configure.ac index 44a5279903..dbcc216689 100644 --- a/sysdeps/riscv/configure.ac +++ b/sysdeps/riscv/configure.ac @@ -1,8 +1,6 @@ GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory. # Local configure fragment for sysdeps/riscv/elf. -AC_DEFINE(PI_STATIC_AND_HIDDEN) - # Check if static linker supports R_RISCV_ALIGN AC_CACHE_CHECK([for R_RISCV_ALIGN linker relaxation support], [libc_cv_riscv_r_align],[dnl cat > conftest.S <<EOF |