diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2015-10-01 17:15:54 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2015-10-01 17:15:54 +0000 |
| commit | 4b84e2471b5f0c9197073395eb77843c6f23e790 (patch) | |
| tree | 46351643320a86d5bfcdd04a89175e5934ecb65c /sysdeps/ieee754/ldbl-128 | |
| parent | e27fcd027cbdc2f13bf440177c0434eb9ec3dd28 (diff) | |
| download | glibc-4b84e2471b5f0c9197073395eb77843c6f23e790.tar.gz | |
Fix ldbl-128 / ldbl-128ibm lgamma overflow handling (bug 16347, bug 19046).
The ldbl-128 / ldbl-128ibm implementation of lgamma has problems with
its handling of large arguments. It has an overflow threshold that is
correct only for ldbl-128, despite being used for both types - with
diagnostic control macros as a temporary measure to disable warnings
about that constant overflowing for ldbl-128ibm - and it has a
calculation that's roughly x * log(x) - x, resulting in overflows for
arguments that are roughly at most a factor 1/log(threshold) below the
overflow threshold.
This patch fixes both issues, using an overflow threshold appropriate
for the type in question and adding another case for large arguments
that avoids the possible intermediate overflow.
Tested for x86_64, x86, mips64 and powerpc.
[BZ #16347]
[BZ #19046]
* sysdeps/ieee754/ldbl-128/e_lgammal_r.c: Do not include
<libc-internal.h>.
(MAXLGM): Do not use diagnostic control macros.
[LDBL_MANT_DIG == 106] (MAXLGM): Change value to overflow
threshold for ldbl-128ibm.
(__ieee754_lgammal_r): For large arguments, multiply by log - 1
instead of multiplying by log then subtracting.
* math/auto-libm-test-in: Add more tests of lgamma.
* math/auto-libm-test-out: Regenerated.
Diffstat (limited to 'sysdeps/ieee754/ldbl-128')
| -rw-r--r-- | sysdeps/ieee754/ldbl-128/e_lgammal_r.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/sysdeps/ieee754/ldbl-128/e_lgammal_r.c b/sysdeps/ieee754/ldbl-128/e_lgammal_r.c index ab5a96eb11..5b513ea1df 100644 --- a/sysdeps/ieee754/ldbl-128/e_lgammal_r.c +++ b/sysdeps/ieee754/ldbl-128/e_lgammal_r.c @@ -70,17 +70,14 @@ #include <math.h> #include <math_private.h> -#include <libc-internal.h> #include <float.h> -/* BZ#16347: ldbl-128ibm uses this file as is, however the MAXLGM - definition overflows for IBM long double. This directive prevents the - overflow warnings until IBM long double version is fixed. */ static const long double PIL = 3.1415926535897932384626433832795028841972E0L; -DIAG_PUSH_NEEDS_COMMENT; -DIAG_IGNORE_NEEDS_COMMENT (4.6, "-Woverflow"); +#if LDBL_MANT_DIG == 106 +static const long double MAXLGM = 0x5.d53649e2d469dbc1f01e99fd66p+1012L; +#else static const long double MAXLGM = 1.0485738685148938358098967157129705071571E4928L; -DIAG_POP_NEEDS_COMMENT; +#endif static const long double one = 1.0L; static const long double huge = LDBL_MAX; @@ -1035,6 +1032,8 @@ __ieee754_lgammal_r (long double x, int *signgamp) if (x > MAXLGM) return (*signgamp * huge * huge); + if (x > 0x1p120L) + return x * (__logl (x) - 1.0L); q = ls2pi - x; q = (x - 0.5L) * __logl (x) + q; if (x > 1.0e18L) |