summaryrefslogtreecommitdiff
path: root/stdlib
diff options
context:
space:
mode:
authorPaul Eggert <eggert@cs.ucla.edu>2015-03-15 17:06:21 -0700
committerPaul Eggert <eggert@cs.ucla.edu>2015-03-15 17:06:21 -0700
commitcb219290492995bb52fba8c21f9f20afe5604721 (patch)
tree1b72cb9d373857a1faa754e03a3ea82ad6fae8f4 /stdlib
parenta3905fd9de77ffce9d2b6042b512b1816d90a3d2 (diff)
downloadglibc-cb219290492995bb52fba8c21f9f20afe5604721.tar.gz
* stdlib/setenv.c (__add_to_environ): Revert previous change.
Diffstat (limited to 'stdlib')
-rw-r--r--stdlib/setenv.c10
1 files changed, 1 insertions, 9 deletions
diff --git a/stdlib/setenv.c b/stdlib/setenv.c
index 05342367b1..b60c4f0151 100644
--- a/stdlib/setenv.c
+++ b/stdlib/setenv.c
@@ -114,16 +114,8 @@ __add_to_environ (name, value, combined, replace)
{
char **ep;
size_t size;
-
- /* Compute lengths before locking, so that the critical section is
- less of a performance bottleneck. VALLEN is needed only if
- COMBINED is non-null. Also, testing COMBINED instead of VALUE
- causes setenv (..., NULL, ...) to dump core now instead of
- corrupting memory later. */
const size_t namelen = strlen (name);
- size_t vallen;
- if (combined != NULL)
- vallen = strlen (value) + 1;
+ const size_t vallen = value != NULL ? strlen (value) + 1 : 0;
LOCK;