diff options
| author | Fangrui Song <maskray@google.com> | 2021-07-08 14:26:22 -0700 |
|---|---|---|
| committer | Fangrui Song <i@maskray.me> | 2021-08-27 17:26:06 -0700 |
| commit | a21d58a0dcd816bd97b9de328ad1870cc7098d9b (patch) | |
| tree | f9b99f3f585691be44ae52cdd3e0c027f632aec2 /nss/rpc-lookup.c | |
| parent | 2d20ffe431ddd299b50ba250fce43285b9617d31 (diff) | |
| download | glibc-a21d58a0dcd816bd97b9de328ad1870cc7098d9b.tar.gz | |
x86_64: Remove unneeded static PIE check for undefined weak diagnostic
https://sourceware.org/bugzilla/show_bug.cgi?id=21782 dropped an ld
diagnostic for R_X86_64_PC32 referencing an undefined weak symbol in
-pie links. Arguably keeping the diagnostic like other ports is more
correct, since statically resolving movl foo(%rip), %eax to the
link-time zero address produces a corrupted output.
It turns out that --enable-static-pie builds do not depend on the ld
behavior. GCC generates GOT indirection for weak declarations for
-fPIE/-fPIC, so what ld does with the PC-relative relocation doesn't
really matter.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Diffstat (limited to 'nss/rpc-lookup.c')
0 files changed, 0 insertions, 0 deletions