diff options
author | Zack Weinberg <zackw@panix.com> | 2018-02-07 18:42:04 -0500 |
---|---|---|
committer | Zack Weinberg <zackw@panix.com> | 2018-02-21 14:11:05 -0500 |
commit | 9964a14579e5eef925aaa82facc4980f627802fe (patch) | |
tree | 10bab616fb792754708552ee49a3cd914f9c167e /libio/oldiopopen.c | |
parent | 349579047db0fb55a2835ca20dfd646a45b6ac27 (diff) | |
download | glibc-9964a14579e5eef925aaa82facc4980f627802fe.tar.gz |
Mechanically remove _IO_ name aliases for types and constants.
This patch mechanically removes all remaining uses, and the
definitions, of the following libio name aliases:
name replaced with
---- -------------
_IO_FILE FILE
_IO_fpos_t __fpos_t
_IO_fpos64_t __fpos64_t
_IO_size_t size_t
_IO_ssize_t ssize_t or __ssize_t
_IO_off_t off_t
_IO_off64_t off64_t
_IO_pid_t pid_t
_IO_uid_t uid_t
_IO_wint_t wint_t
_IO_va_list va_list or __gnuc_va_list
_IO_BUFSIZ BUFSIZ
_IO_cookie_io_functions_t cookie_io_functions_t
__io_read_fn cookie_read_function_t
__io_write_fn cookie_write_function_t
__io_seek_fn cookie_seek_function_t
__io_close_fn cookie_close_function_t
I used __fpos_t and __fpos64_t instead of fpos_t and fpos64_t because
the definitions of fpos_t and fpos64_t depend on the largefile mode.
I used __ssize_t and __gnuc_va_list in a handful of headers where
namespace cleanliness might be relevant even though they're
internal-use-only. In all other cases, I used the public-namespace
name.
There are a tiny handful of places where I left a use of 'struct _IO_FILE'
alone, because it was being used together with 'struct _IO_FILE_plus'
or 'struct _IO_FILE_complete' in the same arithmetic expression.
Because this patch was almost entirely done with search and replace, I
may have introduced indentation botches. I did proofread the diff,
but I may have missed something.
The ChangeLog below calls out all of the places where this was not a
pure search-and-replace change.
Installed stripped libraries and executables are unchanged by this patch,
except that some assertions in vfscanf.c change line numbers.
* libio/libio.h (_IO_FILE): Delete; all uses changed to FILE.
(_IO_fpos_t): Delete; all uses changed to __fpos_t.
(_IO_fpos64_t): Delete; all uses changed to __fpos64_t.
(_IO_size_t): Delete; all uses changed to size_t.
(_IO_ssize_t): Delete; all uses changed to ssize_t or __ssize_t.
(_IO_off_t): Delete; all uses changed to off_t.
(_IO_off64_t): Delete; all uses changed to off64_t.
(_IO_pid_t): Delete; all uses changed to pid_t.
(_IO_uid_t): Delete; all uses changed to uid_t.
(_IO_wint_t): Delete; all uses changed to wint_t.
(_IO_va_list): Delete; all uses changed to va_list or __gnuc_va_list.
(_IO_BUFSIZ): Delete; all uses changed to BUFSIZ.
(_IO_cookie_io_functions_t): Delete; all uses changed to
cookie_io_functions_t.
(__io_read_fn): Delete; all uses changed to cookie_read_function_t.
(__io_write_fn): Delete; all uses changed to cookie_write_function_t.
(__io_seek_fn): Delete; all uses changed to cookie_seek_function_t.
(__io_close_fn): Delete: all uses changed to cookie_close_function_t.
* libio/iofopncook.c: Remove unnecessary forward declarations.
* libio/iolibio.h: Correct outdated commentary.
* malloc/malloc.c (__malloc_stats): Remove unnecessary casts.
* stdio-common/fxprintf.c (__fxprintf_nocancel):
Remove unnecessary casts.
* stdio-common/getline.c: Use _IO_getdelim directly.
Don't redefine ssize_t.
* stdio-common/printf_fp.c, stdio_common/printf_fphex.c
* stdio-common/printf_size.c: Don't redefine size_t or FILE.
Remove outdated comments.
* stdio-common/vfscanf.c: Don't redefine va_list.
Diffstat (limited to 'libio/oldiopopen.c')
-rw-r--r-- | libio/oldiopopen.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/libio/oldiopopen.c b/libio/oldiopopen.c index 59d404bfa9..42cab4e8f7 100644 --- a/libio/oldiopopen.c +++ b/libio/oldiopopen.c @@ -41,7 +41,7 @@ struct _IO_proc_file { struct _IO_FILE_complete_plus file; /* Following fields must match those in class procbuf (procbuf.h) */ - _IO_pid_t pid; + pid_t pid; struct _IO_proc_file *next; }; typedef struct _IO_proc_file _IO_proc_file; @@ -58,14 +58,14 @@ unlock (void *not_used) } #endif -_IO_FILE * +FILE * attribute_compat_text_section -_IO_old_proc_open (_IO_FILE *fp, const char *command, const char *mode) +_IO_old_proc_open (FILE *fp, const char *command, const char *mode) { volatile int read_or_write; volatile int parent_end, child_end; int pipe_fds[2]; - _IO_pid_t child_pid; + pid_t child_pid; if (_IO_file_is_open (fp)) return NULL; if (__pipe (pipe_fds) < 0) @@ -105,7 +105,7 @@ _IO_old_proc_open (_IO_FILE *fp, const char *command, const char *mode) popen() calls that remain open in the parent process are closed in the new child process." */ for (p = old_proc_file_chain; p; p = p->next) - __close (_IO_fileno ((_IO_FILE *) p)); + __close (_IO_fileno ((FILE *) p)); execl ("/bin/sh", "sh", "-c", command, (char *) 0); _exit (127); @@ -134,7 +134,7 @@ _IO_old_proc_open (_IO_FILE *fp, const char *command, const char *mode) return fp; } -_IO_FILE * +FILE * attribute_compat_text_section _IO_old_popen (const char *command, const char *mode) { @@ -145,7 +145,7 @@ _IO_old_popen (const char *command, const char *mode) _IO_lock_t lock; #endif } *new_f; - _IO_FILE *fp; + FILE *fp; new_f = (struct locked_FILE *) malloc (sizeof (struct locked_FILE)); if (new_f == NULL) @@ -169,12 +169,12 @@ _IO_old_popen (const char *command, const char *mode) int attribute_compat_text_section -_IO_old_proc_close (_IO_FILE *fp) +_IO_old_proc_close (FILE *fp) { /* This is not name-space clean. FIXME! */ int wstatus; _IO_proc_file **ptr = &old_proc_file_chain; - _IO_pid_t wait_pid; + pid_t wait_pid; int status = -1; /* Unlink from old_proc_file_chain. */ |