diff options
author | Mike Frysinger <vapier@gentoo.org> | 2015-08-28 17:08:49 -0400 |
---|---|---|
committer | Mike Frysinger <vapier@gentoo.org> | 2015-08-29 18:16:20 -0400 |
commit | ca6a9ce6151759981cc2efd58e053148c7db2fea (patch) | |
tree | a97a287c715515605e73989d863b5cab4770b7f2 /extra-lib.mk | |
parent | 0acbb93ebb8cf2a646cc2b685cd13b22d52f1e27 (diff) | |
download | glibc-ca6a9ce6151759981cc2efd58e053148c7db2fea.tar.gz |
getmntent: fix memory corruption w/blank lines [BZ #18887]
The fix for BZ #17273 introduced a single byte of memory corruption when
the line is entirely blank. It would walk back past the start of the
buffer if the heap happened to be 0x20 or 0x09 and then write a NUL byte.
buffer = '\n';
end_ptr = buffer;
while (end_ptr[-1] == ' ' || end_ptr[-1] == '\t')
end_ptr--;
*end_ptr = '\0';
Fix that and rework the tests. Adding the testcase for BZ #17273 to the
existing \040 parser does not really make sense as it's unrelated, and
leads to confusing behavior: it implicitly relies on the new entry being
longer than the previous entry (since it just rewinds the FILE*). Split
it out into its own dedicated testcase instead.
(cherry picked from commit b0e805fa0d6fea33745952df7b7f5442ca4c374f)
(cherry picked from commit 3007f797a1a596e954f44879a5a7267966186ba4)
Diffstat (limited to 'extra-lib.mk')
0 files changed, 0 insertions, 0 deletions