diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2015-03-06 04:55:56 -0800 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2015-03-31 17:26:14 -0700 |
| commit | b2aeb9aca202128d1a9e8b8bfc14e763a86d8727 (patch) | |
| tree | 7f3b8715389b33002c72795a25101290c096426f /elf/ifuncdep2.c | |
| parent | 556b3041f288ede13912ff72bdee59139af7257c (diff) | |
| download | glibc-b2aeb9aca202128d1a9e8b8bfc14e763a86d8727.tar.gz | |
Replace __attribute__((visibility("protected")))hjl/pr17711/2.20
With copy relocation, address of protected data defined in the shared
library may be external. Compiler shouldn't asssume protected data will
be local. But due to
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65248
__attribute__((visibility("protected"))) doesn't work correctly, we need
to use asm (".protected xxx") instead.
Cherry-pick from master: e0ed2fb40a0e29c43cf60addc74741dab15f2e05
* elf/ifuncdep2.c (global): Replace
__attribute__((visibility("protected"))) with
asm (".protected global").
* elf/ifuncmod1.c (global): Likewise.
* elf/ifuncmod5.c (global): Likewise.
Diffstat (limited to 'elf/ifuncdep2.c')
| -rw-r--r-- | elf/ifuncdep2.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/elf/ifuncdep2.c b/elf/ifuncdep2.c index 99d19263ae..6e66d318a6 100644 --- a/elf/ifuncdep2.c +++ b/elf/ifuncdep2.c @@ -2,7 +2,13 @@ #include "ifunc-sel.h" -int global __attribute__ ((visibility ("protected"))) = -1; +int global = -1; +/* Can't use __attribute__((visibility("protected"))) until the GCC bug: + + https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65248 + + is fixed. */ +asm (".protected global"); static int one (void) |