diff options
| author | Carlos O'Donell <carlos@systemhalted.org> | 2015-10-08 16:34:53 -0400 |
|---|---|---|
| committer | Carlos O'Donell <carlos@systemhalted.org> | 2015-10-08 16:41:45 -0400 |
| commit | 87701a58e291bd7ac3b407d10a829dac52c9c16e (patch) | |
| tree | 885857388aaeb1248850629cc2a2de40dc2472b2 /NEWS | |
| parent | fd91891a5091b5f54680180dc0c8e91827f63c70 (diff) | |
| download | glibc-87701a58e291bd7ac3b407d10a829dac52c9c16e.tar.gz | |
strcoll: Remove incorrect STRDIFF-based optimization (Bug 18589).
The optimization introduced in commit
f13c2a8dff2329c6692a80176262ceaaf8a6f74e, causes regressions in
sorting for languages that have digraphs that change sort order, like
cs_CZ which sorts ch between h and i.
My analysis shows the fast-forwarding optimization in STRCOLL advances
through a digraph while possibly stopping in the middle which results
in a subsequent skipping of the digraph and incorrect sorting. The
optimization is incorrect as implemented and because of that I'm
removing it for 2.23, and I will also commit this fix for 2.22 where
it was originally introduced.
This patch reverts the optimization, introduces a new bug-strcoll2.c
regression test that tests both cs_CZ.UTF-8 and da_DK.ISO-8859-1 and
ensures they sort one digraph each correctly. The optimization can't be
applied without regressing this test.
Checked on x86_64, bug-strcoll2.c fails without this patch and passes
after. This will also get a fix on 2.22 which has the same bug.
Diffstat (limited to 'NEWS')
| -rw-r--r-- | NEWS | 14 |
1 files changed, 7 insertions, 7 deletions
@@ -13,13 +13,13 @@ Version 2.23 15384, 15786, 15918, 16141, 16296, 16347, 16415, 16517, 16519, 16520, 16521, 16620, 16734, 16973, 16985, 17118, 17243, 17244, 17250, 17441, 17787, 17886, 17887, 17905, 18084, 18086, 18240, 18265, 18370, 18421, - 18480, 18525, 18595, 18610, 18618, 18647, 18661, 18674, 18675, 18681, - 18724, 18757, 18778, 18781, 18787, 18789, 18790, 18795, 18796, 18803, - 18820, 18823, 18824, 18825, 18857, 18863, 18870, 18872, 18873, 18875, - 18887, 18921, 18951, 18952, 18956, 18961, 18966, 18967, 18969, 18970, - 18977, 18980, 18981, 18985, 19003, 19012, 19016, 19018, 19032, 19046, - 19049, 19050, 19059, 19071, 19076, 19077, 19078, 19079, 19085, 19086, - 19088. + 18480, 18525, 18595, 18589, 18610, 18618, 18647, 18661, 18674, 18675, + 18681, 18724, 18757, 18778, 18781, 18787, 18789, 18790, 18795, 18796, + 18803, 18820, 18823, 18824, 18825, 18857, 18863, 18870, 18872, 18873, + 18875, 18887, 18921, 18951, 18952, 18956, 18961, 18966, 18967, 18969, + 18970, 18977, 18980, 18981, 18985, 19003, 19012, 19016, 19018, 19032, + 19046, 19049, 19050, 19059, 19071, 19076, 19077, 19078, 19079, 19085, + 19086, 19088. * The obsolete header <regexp.h> has been removed. Programs that require this header must be updated to use <regex.h> instead. |