diff options
author | Stefan Liebler <stli@linux.ibm.com> | 2018-09-06 14:27:03 +0200 |
---|---|---|
committer | Stefan Liebler <stli@linux.ibm.com> | 2018-09-10 14:29:21 +0200 |
commit | 7118ba34931d27f538c71c1cd355866f8db83f4e (patch) | |
tree | 3541d217a66e583dfadcd318dc50d1913749b8e5 /ChangeLog | |
parent | 1324858a3fd3d0291f9dec45f771881ba7209150 (diff) | |
download | glibc-7118ba34931d27f538c71c1cd355866f8db83f4e.tar.gz |
Fix segfault in maybe_script_execute.
If glibc is built with gcc 8 and -march=z900,
the testcase posix/tst-spawn4-compat crashes with a segfault.
In function maybe_script_execute, the new_argv array is dynamically
initialized on stack with (argc + 1) elements.
The function wants to add _PATH_BSHELL as the first argument
and writes out of bounds of new_argv.
There is an off-by-one because maybe_script_execute fails to count
the terminating NULL when sizing new_argv.
ChangeLog:
* sysdeps/unix/sysv/linux/spawni.c (maybe_script_execute):
Increment size of new_argv by one.
(cherry picked from commit 28669f86f6780a18daca264f32d66b1428c9c6f1)
Diffstat (limited to 'ChangeLog')
-rw-r--r-- | ChangeLog | 5 |
1 files changed, 5 insertions, 0 deletions
@@ -1,3 +1,8 @@ +2018-09-06 Stefan Liebler <stli@linux.ibm.com> + + * sysdeps/unix/sysv/linux/spawni.c (maybe_script_execute): + Increment size of new_argv by one. + 2018-08-27 Martin Kuchta <martin.kuchta@netapp.com> Torvald Riegel <triegel@redhat.com> |