| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
TESTS_ENVIRONMENT is reserved for the user to be able to set when
running the tests. AM_TESTS_ENVIRONMENT is for the tests’ Makefile to
set itself.
https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html
Signed-off-by: Philip Withnall <withnall@endlessm.com>
https://bugzilla.gnome.org/show_bug.cgi?id=782996
|
|
|
|
|
|
|
|
| |
It's unnecessary, and only adds visual noise; we have been fairly
inconsistent in the past, but the semi-colon-less version clearly
dominates in the code base.
https://bugzilla.gnome.org/show_bug.cgi?id=669355
|
|
|
|
|
|
|
| |
Even if the address is correct, it's far more convenient to have a link
to a website.
https://bugzilla.gnome.org/show_bug.cgi?id=776586
|
|
|
|
|
|
|
|
|
|
| |
Signed integer overflow is undefined behaviour: if a compiler
detects signed integer overflow, it is free to compile it to absolutely
anything.
Signed-off-by: Simon McVittie <smcv@debian.org>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=775510
Reviewed-by: Colin Walters
|
|
|
|
|
|
|
| |
rand() is in the C library and some C libraries (uclibc, for example) end up
with rand() defined even if stdlib.h isn't included explicitly.
https://bugzilla.gnome.org/show_bug.cgi?id=774421
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=771591
|
|
|
|
| |
These files are used by the unicode-caseconv test.
|
|
|
|
|
|
|
| |
The function is documented to assume valid input, and doesn't
guarantee behavior with invalid input. So don't test that.
https://bugzilla.gnome.org/show_bug.cgi?id=754636
|
|
|
|
| |
Spitting out the same error for different cases in not helpful.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't need to run binaries we just built in order to successfully
build GLib and friends any more.
Since commit b74e2a7, we don't need to run glib-genmarshal when building
GIO; since commit f9eb9eed, all our tests (including the ones that do
need to run binaries we just built) are only built when running "make
check", instead of unconditionally at every build.
This means that we don't need to check for existing, native binaries
when cross-compiling, and fail the configuration step if they are not
found — which also means that you don't need to natively build GLib for
your toolchain, in order to cross-compile GLib.
We can also use the cross-compilation conditional, and skip those tests
that require a binary we just built in order to build.
https://bugzilla.gnome.org/show_bug.cgi?id=753745
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I searched all files that mention g_test_run, and replaced most
g_print() calls. This avoids interfering with TAP. Exceptions:
* gio/tests/network-monitor: a manual mode that is run by
"./network-monitor --watch" is unaffected
* glib/gtester.c: not a test
* glib/gtestutils.c: not a test
* glib/tests/logging.c: specifically exercising g_print()
* glib/tests/markup-parse.c: a manual mode that is run by
"./markup-parse --cdata-as-text" is unaffected
* glib/tests/testing.c: specifically exercising capture of stdout
in subprocesses
* glib/tests/utils.c: captures a subprocess's stdout
* glib/tests/testglib.c: exercises an assertion failure in g_print()
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=725981
Reviewed-by: Colin Walters <walters@verbum.org>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
|
|
|
|
|
|
|
|
| |
The test is to remove all the odd values with my_hash_callback_remove(),
then iterate over all values and verify that they are even. However,
failing this check would just print "bad!" instead of failing the test.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=725981
Reviewed-by: Colin Walters <walters@verbum.org>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=731929#c2
|
|
|
|
|
|
| |
We should have done this a decade ago...
https://bugzilla.gnome.org/show_bug.cgi?id=730293
|
|
|
|
|
|
|
|
|
| |
gdb is run in batch mode, and can leave leave the program being
executed/debugged running when the batchfile is finished. Explicitly
"quit"ing the subprocess prevents it from leaving the stray subprocess
when gdb finishes.
https://bugzilla.gnome.org/show_bug.cgi?id=731366
|
|
|
|
|
|
|
| |
It turns out that due to a recent gdm change, the inherited
signal mask has SIGUSR1 blocked - which is bad news for
tests using SIGUSR1. Fix the test by explicitly checking the
signal mask before using SIGUSR1.
|
| |
|
|
|
|
| |
This might help figuring out why the test is failing in continuous.
|
|
|
|
|
|
|
| |
The mapping-test is failing under gnome-continuous. I suspect this
is simply due to running many tests in parallel, and mapping-test
being racy. Replace the blind sleep by signals, to avoid the
races.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
g_time_val_from_iso8601 was attempting to parse strings
having only a date, but failed to actually set the timeval
despite returning TRUE. Since the docs state that the function
only parses strings containing a date and a time, just return
FALSE in this case.
Also remove an incomplete testcase for this behaviour that was
just checking the boolean return value, but not timeval.
|
|
|
|
|
|
|
| |
POSIX specifies that <poll.h> is the correct header to include for
poll(), so let's do that instead.
https://bugzilla.gnome.org/show_bug.cgi?id=141251
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Windows development environments that have it, <unistd.h> is mostly
just a wrapper around several other native headers (in particular,
<io.h>, which contains read(), close(), etc, and <process.h>, which
contains getpid()). But given that some Windows dev environments don't
have <unistd.h>, everything that uses those functions on Windows
already needed to include the correct Windows header as well, and so
there is never any point to including <unistd.h> on Windows.
Also, remove some <unistd.h> includes (and a few others) that were
unnecessary even on unix.
https://bugzilla.gnome.org/show_bug.cgi?id=710519
|
|
|
|
|
|
|
| |
Linking local libraries too late may cause preinstalled libraries to
get found earlier, due to external library paths in .la files.
https://bugzilla.gnome.org/show_bug.cgi?id=712314
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|
|
|
|
|
|
|
| |
This reverts commit fd7b2faa64febab407ffde2506c995544583a9d5.
This required another patch to be commited first. Will put this
back in bugzilla.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711047
|
|
|
|
|
|
|
|
|
|
|
| |
...and only include unistd.h when we are on *NIX.
Newer Visual C++ runtimes (8.0/2005 and later) will cause the program to
crash with an internal abort() call when they detect instances of close()
being called on an invalid fd, such as when the fd is -1, and these should
be purged anyways.
https://bugzilla.gnome.org/show_bug.cgi?id=711047
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711779
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711779
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711779
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711779
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711779
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711779
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711779
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711768
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|
|
|
|
|
|
|
| |
This is a test of deprecated functionality and its age is
showing. Doesn't actually do what it says. But fix leaks anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=711751
|