| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Since these variables are referenced from other directories
such as the tests/ subdir as well.
|
|
|
|
| |
Still at least one FIXME. And untested so far. It builds.
|
|
|
|
|
|
|
| |
Also remove headers from some gio sources. Headers do not need to be
added to the list of sources.
+ various smaller self-explanatory fixes.
|
| |
|
|
|
|
|
| |
- Fix installing various data files
- Build translations
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable gio tests on Windows, fix .gitignore to not ignore
config.h.meson, and add more things to it.
Rename the library file naming and versioning to match what Autotools
outputs, e.g., libglib-2.0.so.0.5000.2 on Linux, libglib-2.0-0.dll and
glib-2.0-0.dll on Windows with MSVC.
Several more tiny fixes, more executables built and installed, install
pkg-config and m4 files, fix building of gobject tests.
Changes to gdbus-codegen to support out-of-tree builds without
environment variables set (which you can't in Meson). We now add the
build directory to the Python module search path.
|
|
|
|
|
|
| |
Several small fixes to the build files.
Lots of tests have also been added, and glib tests pass now.
|
|
|
|
|
|
|
|
| |
This way code that does not manually include the generated marshallers
header and wishes to build with `-Wmissing-prototypes` will not generate
a compiler warning.
https://bugzilla.gnome.org/show_bug.cgi?id=781755
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=781755
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=781755
|
|
|
|
|
|
|
|
|
|
| |
The convention for arguments taking a value is:
--argument=VALUE
with the `VALUE` in caps.
https://bugzilla.gnome.org/show_bug.cgi?id=781755
|
|
|
|
|
|
|
|
| |
It's unnecessary, and only adds visual noise; we have been fairly
inconsistent in the past, but the semi-colon-less version clearly
dominates in the code base.
https://bugzilla.gnome.org/show_bug.cgi?id=669355
|
|
|
|
|
|
|
|
|
|
|
| |
This is going to be checked again by g_object_new_with_properties()
and g_object_new_valist() anyway, so might just as well leave it
to those functions to do the check and only do it once. It doesn't
matter which function emits the critical warning in the end either,
as one has to look at a stack trace to find out what code triggered
it in any case.
https://bugzilla.gnome.org/show_bug.cgi?id=780908
|
|
|
|
|
|
| |
This slipped through the review cracks.
https://bugzilla.gnome.org/show_bug.cgi?id=709865
|
|
|
|
|
|
|
|
| |
g_object_newv uses a GParameter as argument. Since GParameter
is deprecated due to this type is not introspectible,
g_object_newv is deprecated now.
https://bugzilla.gnome.org/show_bug.cgi?id=709865
|
|
|
|
|
|
| |
GParameter is a rarely used type and not introspectible.
https://bugzilla.gnome.org/show_bug.cgi?id=709865
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=709865
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=709865
|
|
|
|
|
|
|
|
|
| |
g_object_new_with_properties is an alternative to g_object_newv.
The last one, takes an array of GParameter. However, GParameter
is a rarely used type and this type is not introspectible, so
it will not work properly in bindings.
https://bugzilla.gnome.org/show_bug.cgi?id=709865
|
|
|
|
|
|
|
|
| |
g_object_new_is_valid_property
g_object_get_is_valid_property
g_object_set_is_valid_property
https://bugzilla.gnome.org/show_bug.cgi?id=709865
|
|
|
|
|
|
| |
These are useful for debugging.
https://bugzilla.gnome.org/show_bug.cgi?id=447907
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should be helpful for reproducible builds
<https://reproducible-builds.org/>.
Perl's sorting is not locale-sensitive unless the lexical scope has
'use locale', which this one does not, so we do not need to force
locale-agnostic sorting.
Signed-off-by: Simon McVittie <smcv@debian.org>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=769983
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809152
|
|
|
|
|
|
|
|
|
| |
They do not start with the #!/usr/bin/python that would be necessary
to make them run with Python rather than a shell, and they would
not be useful to run anyway: they are libraries to be imported,
not scripts to be run.
Signed-off-by: Simon McVittie <smcv@debian.org>
|
|
|
|
|
|
| |
It was suggested that the project files be moved here as we don't actually
need to go two directory layers from $(srcroot), and would help us to
standardize on things in the future across the board.
|
|
|
|
|
|
|
|
|
|
|
|
| |
The macros differ in their handling of NULL values — some macros ignore
them and pass through (e.g. G_TYPE_CHECK_INSTANCE_CAST) while others
will explicitly emit a warning if passed NULL (e.g.
G_TYPE_CHECK_INSTANCE).
Document their behaviour, so people don’t end up putting unnecessary
NULL checks in their code when doing checked type casts.
https://bugzilla.gnome.org/show_bug.cgi?id=735731
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
glibc string.h declares memcpy() with attribute(nonnull(1,2)), causing
calls with NULL arguments to be treated as undefined behaviour.
This is consistent with ISO C99 and C11, which state that passing 0
to string functions as an array length does not remove the requirement
that the pointer to the array is a valid pointer.
gcc -fsanitize=undefined catches this while running OSTree's test suite.
Similarly, running the GLib test suite reports similar issues for
qsort(), memmove(), memcmp().
Signed-off-by: Simon McVittie <smcv@debian.org>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=775510
Reviewed-by: Colin Walters
|
|
|
|
|
|
|
|
|
|
|
|
| |
UBSan considers left-shifting a negative number to be undefined
behaviour (per
<http://www.open-std.org/jtc1/sc22/wg14/www/docs/dr_081.html> it is
implementation-defined in C89, but according to
<https://llvm.org/bugs/show_bug.cgi?id=17490> it is undefined in C99).
Signed-off-by: Simon McVittie <smcv@debian.org>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=775510
Reviewed-by: Colin Walters
|
|
|
|
|
|
|
|
|
|
|
| |
global variables in SystemTap are shared between all SystemTap scripts;
so if scripts are loaded for two versions of GLib (for example, a stable
and a development version), those global variables will conflict.
Avoid that by including the soname’s version in the global variable
names.
https://bugzilla.gnome.org/show_bug.cgi?id=770646
|
|
|
|
|
|
|
|
| |
If we have an input parameter (or return value) we need to use (nullable).
However, if it is an (inout) or (out) parameter, (optional) is sufficient.
It looks like (nullable) could be used for everything according to the
Annotation documentation, but (optional) is more specific.
|
|
|
|
|
|
|
|
|
|
| |
gtk-doc doesn’t make the return type clear, because these are macros
rather than inline functions, so people often have to guess at the
return type (or look it up from g_signal_connect_closure(), but that’s
hard work).
Make it clear that the return type for handler IDs is gulong. While
there, fix the capitalisation of ‘id’ to ‘ID’ in a few places.
|
|
|
|
|
|
|
| |
Inconsequential, just sync up declaration with actual
name of variable to avoid confusion.
https://bugzilla.gnome.org/show_bug.cgi?id=770175
|
|
|
|
|
| |
Refer to https://bugzilla.gnome.org/show_bug.cgi?id=767882
Related to GCC https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71803
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=770175
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=770175
|
|
|
|
|
|
| |
The test setup here is not really independent, so the addition
of the custom-marshaller test was breaking some of the other
tests. Fix things up.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=769076
|
|
|
|
|
|
|
| |
Otherwise we get warnings when the caller later tries to set a
va marshaller with g_signal_set_va_marshaller.
https://bugzilla.gnome.org/show_bug.cgi?id=769076
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At some point, upstream SystemTap changed from using a
STAP_HAS_SEMAPHORES preprocessor variable for this, to using
_SDT_HAS_SEMAPHORES instead. We need to update our build system to
disable that as well.
The original discussion about use of semaphores is here:
https://bugzilla.gnome.org/show_bug.cgi?id=606044
This was breaking the build with -flto enabled, either because -flto
doesn’t work with semaphores.
https://bugzilla.gnome.org/show_bug.cgi?id=768198
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The C spec leaves conditional evaluation inside a macro expansion as
undefined behaviour. This means we cannot use constructs like:
GOBJECT_IF_DEBUG(OBJECTS, {
...
#ifdef BLAH
...
#endif
...});
Because compilers are entirely justified to ignore the conditional, or,
like in the case of MSVC, error out.
https://bugzilla.gnome.org/show_bug.cgi?id=769504
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=769033
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
historically, DEBUG_CODE(gtype.c) and IF_DEBUG(gobject.c, gsignal.c)
macros are used to support debugging messages about object bookkeeping
and signal emission.
DEBUG_CODE has never been used in gtype.c. IF_DEBUG, when used, must be
accompanied by an extra #ifdef G_ENABLE_DEBUG. this is cumbersome.
this patch add a new macro GOBJECT_IF_DEBUG based on DEBUG_CODE as
a replacement for both DEBUG_CODE and IF_DEBUG.
https://bugzilla.gnome.org/show_bug.cgi?id=729914
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In a vague attempt at ensuring the .stp scripts can be closely
associated with the .so files which they hard-code references to, rename
the scripts so they include the LT version — so that they are the .so
file name plus .stp.
This does not fix the fact that our .stp scripts will not work on
multiarch systems, as they are installed in an architecture-independent
directory (/usr/share/systemtap/tapset). At the moment, it is
recommended that any distribution who package the .stp files should
install them in the architecture-specific subdirectories of this (for
example, /usr/share/systemtap/tapset/x86-64).
A better long-term solution for this is under discussion upstream:
https://sourceware.org/bugzilla/show_bug.cgi?id=20264
https://bugzilla.gnome.org/show_bug.cgi?id=662802
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ability to pass libtool via $(CC) to dtrace and have it respect this
appears to be a feature that is only present in the systemtap version of
the tool. In particular, FreeBSD (which seems to be using a copy of the
tool from Solaris) doesn't support this.
The result is that, with $(CC) ignored, and a .lo file specified in -o,
we get an ELF written to the .lo.
Instead of trying to have dtrace run libtool we can have libtool run
dtrace. dtrace is really just a compiler that produces an object file
here, and it even understands -o, so libtool can make the appropriate
adjustments.
There appears to be some prior art for this approach. A quick search
shows that at least QEMU is using this approach. It also appears to
work on Linux with systemtap's dtrace and on FreeBSD.
This may regress cross-compilation because the dtrace command will have
no way of knowing which compiler we intend for it to use to produce the
object file. I say "may" because I don't know if dtrace ever worked in
the first place under cross-compilation.
https://bugzilla.gnome.org/show_bug.cgi?id=725902
|
|
|
|
|
|
|
|
| |
Some compilers have trouble with such sequences. Visual C++ may or may
not generate a warning in this particular case depending on if the
local code page supports an ellipsis.
https://bugzilla.gnome.org/show_bug.cgi?id=767218
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
glib installs a gdb helper file named `glib.py`.
Then the "hook" file updates `sys.path` and does `import glib`.
This will fail if glib has already been imported into gdb, say
using `from gi.repository import GLib`. This is due to a namespace clash.
One fix would be to rename the gdb helper files to not clash with
other Python modules. This should be done for all such helper files.
https://bugzilla.gnome.org/show_bug.cgi?id=760186
|
|
|
|
|
|
|
| |
Types are transformable if they are compatible *or* a transformation function
is registered.
https://bugzilla.gnome.org/show_bug.cgi?id=742898
|
|
|
|
|
|
|
| |
v_long is 32 bits on Win64, v_pointer is 64 bits. On most other platforms the
size of long and pointer is the same, so it's usually not a problem.
https://bugzilla.gnome.org/show_bug.cgi?id=758738
|
|
|
|
|
|
|
|
|
| |
Character entities are not supposed to be supported by gtk-doc¹ and
fix the spelling of ‘optional’
¹https://bugzilla.gnome.org/show_bug.cgi?id=758137
https://bugzilla.gnome.org/show_bug.cgi?id=758174
|
|
|
|
|
|
|
|
| |
Mirrors
https://git.gnome.org/browse/glib/commit/?id=ad2092bc680e434c3d17600988ec9b20f52eebef
except I didn't also change gobject/.
https://bugzilla.gnome.org/show_bug.cgi?id=763821
|
| |
|