summaryrefslogtreecommitdiff
path: root/gio/tests/gsettings.c
diff options
context:
space:
mode:
authorPhilip Withnall <pwithnall@endlessos.org>2020-11-18 12:49:54 +0000
committerPhilip Withnall <pwithnall@endlessos.org>2020-11-18 13:19:13 +0000
commitf936bba0d1db00bce9c85586942ea2a70e4373e6 (patch)
tree16eaf182decf163394d2b17c3e0a2af5ad9c9db3 /gio/tests/gsettings.c
parentfe5217bc2bea020cea015ba87121b95e069a087d (diff)
downloadglib-f936bba0d1db00bce9c85586942ea2a70e4373e6.tar.gz
tests: Improve validity of binary GDBusMessage parsing tests
These tests were originally written using the output directly from a fuzzer which had triggered the bugs we’re testing for. However, that means they’re liable to no longer test what they’re intended to test if the `GDBusMessage` parsing code is changed to (for example) check for certain errors earlier in future. It’s better to only have one invalidity in each binary blob, so change the test messages to all be valid apart from the specific thing they’re testing for. The changes were based on reading the D-Bus specification directly: https://dbus.freedesktop.org/doc/dbus-specification.html During these changes I found one problem in `test_message_parse_deep_header_nesting()` where it wasn’t actually nesting variants in the header deeply enough to trigger the bug it was supposed to be testing for. Fixed that. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Fixes: #1963
Diffstat (limited to 'gio/tests/gsettings.c')
0 files changed, 0 insertions, 0 deletions