summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNina Pypchenko <22447785+nina-py@users.noreply.github.com>2020-10-14 21:02:31 +1100
committerNina Pypchenko <22447785+nina-py@users.noreply.github.com>2020-10-15 11:30:04 +1100
commit97fe4903db6fede34d337a19b260790aca29c65f (patch)
tree8a89f62f6ea6074907f61d21e5211a2788f5be2b
parent51f4d51a9146e592c653363c669f2c520d32984b (diff)
downloadgjs-97fe4903db6fede34d337a19b260790aca29c65f.tar.gz
Fixed error in _init() that prevented GType objects from being created.
Improved the regression test, implementing Marco T's feedback. Closes #238.
-rw-r--r--installed-tests/js/testGObject.js11
-rw-r--r--modules/core/overrides/GObject.js2
2 files changed, 12 insertions, 1 deletions
diff --git a/installed-tests/js/testGObject.js b/installed-tests/js/testGObject.js
index 020d17ab..f71644cb 100644
--- a/installed-tests/js/testGObject.js
+++ b/installed-tests/js/testGObject.js
@@ -50,3 +50,14 @@ describe('GObject overrides', function () {
});
});
});
+
+describe('GObject should', function () {
+ const types = ['gpointer', 'GBoxed', 'GParam', 'GInterface', 'GObject', 'GVariant'];
+
+ types.forEach(type => {
+ it(`be able to create a GType object for ${type}`, function () {
+ const gtype = GObject.Type(type);
+ expect(gtype.name).toEqual(type);
+ });
+ });
+});
diff --git a/modules/core/overrides/GObject.js b/modules/core/overrides/GObject.js
index 50deb7dc..af08175e 100644
--- a/modules/core/overrides/GObject.js
+++ b/modules/core/overrides/GObject.js
@@ -227,7 +227,7 @@ function _init() {
let gtype = GObject.type_from_name(gtypeName);
obj[`TYPE_${upperName}`] = gtype;
obj[name] = function (v) {
- return new actual(v);
+ return actual(v);
};
obj[name].$gtype = gtype;
}