| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
- Use require.Regexp to expect ssh handshake error
- Use require.Eventually to refactor verifyStatus
|
|
|
|
|
|
| |
This will help to prevent misconfigurations.
Changelog: fixed
|
|
|
|
|
|
|
|
| |
Use reflection to log the command we are about to execute, both in
gitlab-shell and gitlab-sshd. Include the environment, which has all
the context we need to understand what the command is expected to do.
Changelog: added
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we get this in some log messages:
logrus_error="can not add field \"channel_type\""
This is because we're trying to add a function, rather than the result
of the function call (a string) to the `log.Fields`. Whoops!
Changelog: fixed
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
It adds correlation ids wherever possible
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
Update go-proxyproto to v0.6.0
See merge request gitlab-org/gitlab-shell!499
|
| | |
|
|/ |
|
|\
| |
| |
| |
| | |
Switch to labkit/log for logging functionality
See merge request gitlab-org/gitlab-shell!498
|
| | |
|
|/ |
|
|
|
|
|
| |
A RoundTripper for tracking the duration of an http request
is introduced
|
|
|
|
|
| |
They are going to be used to determine whether a server is alive
and ready to accept traffic
|
|
|
|
|
|
|
|
| |
When interruption signal is sent, we are closing ssh listener to
prevent it from accepting new connections
Then after configured grace period, we cancel the context to
cancel all ongoing operations
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, opentracing (if configured) was initialized late in the
gitlab-shell process's lifespan, coming just before making a gRPC
call to Gitaly.
By moving the opentracing initialization to be at process startup, we
make it available for the whole process lifecycle, which is very useful
to gitlab-sshd, as it means we'll only call tracing.Initialize() once
on process startup, rather than once per SSH connection.
To get this working, we need to introduce a context to gitlab-sshd.
This carries the client/service name, but also carries an initial
correlation ID. The main outcome of this is that all calls to the
authorized_keys endpoint from a given gitlab-sshd process will now
share a correlation ID. I don't have a strong opinion about this either
way.
Changelog: fixed
|
|
|
|
|
|
|
|
|
| |
Without these changes, Gitaly calls would not be linked to a parent
context. This means that they would have an unassociated correlationID,
and Gitaly RPC calls would not be cancel()ed by parent context
cancellation.
Changelog: fixed
|
|
|
|
|
|
| |
Without this, a failure in a single session could take out a whole
connection, or a failure in a single connection could take out the
whole server.
|
| |
|
| |
|
|\
| |
| |
| |
| | |
gitlab-sshd: Acceptance test for the discover command
See merge request gitlab-org/gitlab-shell!457
|
| |
| |
| |
| |
| | |
With this, we can start to build confidence in making changes to
gitlab-sshd.
|
|/
|
|
|
|
|
| |
Refactors introspection of execution environment to rely on
per-connection state (`gitlab-shell`) or per request (`gitlab-sshd`)
Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/496
|
|
|
|
|
|
|
|
|
| |
* Counter for how many times the max concurrent sessions limit was hit.
* Histogram for duration of each SSH connection.
https://gitlab.com/gitlab-org/gitlab-shell/-/issues/121
Signed-off-by: Ben Kochie <superq@gmail.com>
|
|
|