| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before 9deaf47f1ecb00f0f36d18ee4a0fb1576f5a0efe, Gitaly would return
success for `SSHUploadPack` and `SSHUploadArchive` regardless of the
exit code of the `git upload-pack|archive` process. As a result, the
gitlab-sshd acceptance tests could rely on no errors being returned from
Gitaly.
Currently these tests send the minimum request needed to start a
session, causing the server git process to fail as the `0000` flush
packet to end the session is never sent.
This commit fixes the tests by sending the full request/response needed
for a successful git operation.
|
|\
| |
| |
| |
| | |
Bump .tool_versions to use Go v1.16.12
See merge request gitlab-org/gitlab-shell!548
|
|/
|
|
| |
Part of https://gitlab.com/groups/gitlab-org/-/epics/7111
|
|\
| |
| |
| |
| | |
Release v13.22.1
See merge request gitlab-org/gitlab-shell!547
|
|/ |
|
|\
| |
| |
| |
| | |
Remove SSL_CERT_DIR logging
See merge request gitlab-org/gitlab-shell!546
|
|/
|
|
|
| |
This log entry doesn't respect log level, because the log level
is configured after this logging happens
|
|\
| |
| |
| |
| | |
Fix usage of out-of-date Gitaly images
See merge request gitlab-org/gitlab-shell!544
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Our CI jobs and docker-compose pull in the "latest" tag of Gitaly. As it
turns out though, "latest" is pointing to Gitaly v13.3.0-rc5, which is
definitely not the latest versionat this point in time. This is because
CNG was converted to not use the "latest" tag anymore, but instead to
use a tag called "master" in gitlab-org/build/CNG!519.
Fix this by using the new "master" tag instead.
|
|\ \
| |/
|/|
| |
| | |
Refactor flaky test case in sshd_test
See merge request gitlab-org/gitlab-shell!545
|
|/
|
|
|
| |
- Use require.Regexp to expect ssh handshake error
- Use require.Eventually to refactor verifyStatus
|
|\
| |
| |
| |
| | |
Update gitlab-shell VERSION to 13.22.0
See merge request gitlab-org/gitlab-shell!543
|
|/ |
|
|\
| |
| |
| |
| | |
Release v13.22.0
See merge request gitlab-org/gitlab-shell!541
|
| | |
|
| | |
|
| | |
|
|/ |
|
|\
| |
| |
| |
| | |
Fix golang definition in tool versions
See merge request gitlab-org/gitlab-shell!542
|
| | |
|
|/ |
|
|\
| |
| |
| |
| | |
Relax key and username matching for sshd
See merge request gitlab-org/gitlab-shell!540
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to the way sshd works, gitlab-shell could be called with a single
string in the form:
```
/path/to/gitlab-shell -c key-id
```
However, due to the tightening of the regular expressions in fcff692b
this string no longer matches, so logins would fail with:
```
Failed to get username: who='' is invalid
```
This can be reproduced by changing the user's shell to point to
gitlab-shell. For example:
```
usermod git -s /opt/gitlab/embedded/service/gitlab-shell/bin/gitlab-shell
```
While setting gitlab-shell as the user's shell isn't officially
supported, gitlab-shell still should be able to cope with the key being
specified as the last argument. We now split the argument list and use
the last value.
Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/530
|
|\
| |
| |
| |
| | |
Add logging to handler/exec.go and config/config.go
See merge request gitlab-org/gitlab-shell!539
|
| | |
|
|/ |
|
|\
| |
| |
| |
| | |
Improve logging for non-git commands
See merge request gitlab-org/gitlab-shell!538
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Several of our commands only touch the internal API, and go nowhere
near Gitaly. Improve logging for each of these in a single MR. In
general, we want to be able to tell what happened in the execution of
each command, and to track failures down to a specific line of code.
Changelog: added
|
|\ \
| |/
|/|
| |
| |
| |
| | |
Reject non-proxied connections when proxy protocol is enabled
Closes #532
See merge request gitlab-org/gitlab-shell!536
|
| |
| |
| |
| |
| |
| | |
This will help to prevent misconfigurations.
Changelog: fixed
|
|\ \
| | |
| | |
| | |
| | | |
Update to Go v1.16.9
See merge request gitlab-org/gitlab-shell!537
|
|/ /
| |
| |
| | |
This is a security release: https://golang.org/doc/devel/release#go1.16
|
|\ \
| |/
|/|
| |
| | |
refactor: remove call to BuildNameToCertificate (deprecated)
See merge request gitlab-org/gitlab-shell!515
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
Log command invocation
See merge request gitlab-org/gitlab-shell!535
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
Use reflection to log the command we are about to execute, both in
gitlab-shell and gitlab-sshd. Include the environment, which has all
the context we need to understand what the command is expected to do.
Changelog: added
|
|\ \
| | |
| | |
| | |
| | | |
Fix logging channel type
See merge request gitlab-org/gitlab-shell!534
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently we get this in some log messages:
logrus_error="can not add field \"channel_type\""
This is because we're trying to add a function, rather than the result
of the function call (a string) to the `log.Fields`. Whoops!
Changelog: fixed
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Resolve an error-swallowing issue
Closes #499
See merge request gitlab-org/gitlab-shell!533
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
Add more logging to gitlab-sshd
See merge request gitlab-org/gitlab-shell!531
|
| | | |
|
| | | |
|
| | | |
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Respect log-level configuration again
Closes #502
See merge request gitlab-org/gitlab-shell!530
|
|/ /
| |
| |
| |
| |
| | |
This was lost in the move from Ruby to Go. Restore it now.
Changelog: fixed
|
|\ \
| | |
| | |
| | |
| | | |
Only validate SSL cert file exists if a value is supplied
See merge request gitlab-org/gitlab-shell!527
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes a regression in
https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/508. If an
HTTPS internal API URL were used, gitlab-shell would not work at all. We
now handle blank `caFile` properly.
Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/529
|
|\ \
| | |
| | |
| | |
| | | |
makefile: properly escape '$' in VERSION_STRING
See merge request gitlab-org/gitlab-shell!525
|