| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|\
| |
| |
| |
| | |
Release v13.13.0
See merge request gitlab-org/gitlab-shell!433
|
|/ |
|
|\
| |
| |
| |
| | |
GitLab API Client support for client certificates
See merge request gitlab-org/gitlab-shell!432
|
|/ |
|
|\
| |
| |
| |
| | |
Release v13.12.0
See merge request gitlab-org/gitlab-shell!431
|
|/ |
|
|\
| |
| |
| |
| | |
Remove rubocop from Ruby test
See merge request gitlab-org/gitlab-shell!430
|
|/
|
|
| |
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
|
|\
| |
| |
| |
| |
| |
| | |
Upgrade Bundler from 1.17.2 to 2.1.4
Closes #483
See merge request gitlab-org/gitlab-shell!428
|
|/
|
|
|
|
|
| |
https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/426
https://gitlab.com/groups/gitlab-org/-/epics/2380
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
|
|\
| |
| |
| |
| | |
Log Content-Length bytes in API response
See merge request gitlab-org/gitlab-shell!427
|
| |
| |
| |
| |
| | |
This will be useful to measure bandwidth sent in response to an API
request, particularly with measuring the /api/v4/internal/lfs endpoint.
|
|\ \
| |/
|/|
| |
| | |
Bump default Ruby version to v2.7.2
See merge request gitlab-org/gitlab-shell!426
|
|/
|
|
| |
Part of https://gitlab.com/groups/gitlab-org/-/epics/2380
|
|\
| |
| |
| |
| | |
Release v13.11.0
See merge request gitlab-org/gitlab-shell!425
|
|/ |
|
|\
| |
| |
| |
| | |
Fix incorrect actor used to check permissions for SSH receive-pack
See merge request gitlab-org/gitlab-shell!424
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During a SSH receive-pack request (e.g. `git push`), gitlab-shell was
incorrectly using the user returned by the `/internal/allowed` API
endpoint to make an SSHReceivePack RPC call. This caused a number of
problems with deploy keys with write access:
1. Keys that were generated by a blocked user would be denied the
ability to write.
2. Keys that were generated by user that did not have write access to
the project would also be denied.
GitLab 12.4 removed the Ruby implementation of gitlab-shell in favor of
the Golang implementation, and these implementations worked slightly
differently. In
https://gitlab.com/gitlab-org/gitlab-shell/blob/v10.1.0/lib/gitlab_shell.rb,
the Ruby implementation would always use `@who` (e.g. `key-123`), but in
gitlab-shell v10.2.0 the Go implementation would always use the user
from the API response.
Reads did not have this issue because the user/deploy key is never
passed to Gitaly for additional permission checks. Writes need this
information for the pre-receive to check access to protected branches,
push rules, etc.
Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/479
|
|\
| |
| |
| |
| | |
Set SSL_CERT_DIR env var when building command
See merge request gitlab-org/gitlab-shell!423
|
| | |
|
|/ |
|
|\
| |
| |
| |
| | |
Release v13.10.0
See merge request gitlab-org/gitlab-shell!422
|
|/ |
|
|\
| |
| |
| |
| | |
Add support for -version argument
See merge request gitlab-org/gitlab-shell!421
|
| | |
|
|/
|
|
|
| |
This will help determine the version of the binary particularly on Cloud
Native GitLab, where VERSION may not be shipped with the binaries.
|
|\
| |
| |
| |
| | |
Release v13.9.0
See merge request gitlab-org/gitlab-shell!420
|
|/ |
|
|\
| |
| |
| |
| | |
tests: Remove testify assert in favour of require
See merge request gitlab-org/gitlab-shell!419
|
| |\
| |/
|/| |
|
|\ \
| | |
| | |
| | |
| | | |
client: Allow User-Agent header to be overridden
See merge request gitlab-org/gitlab-shell!418
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
Testify features sub packages `assert` and `require`. The difference is
subtle, and lost on novice Golang developers that don't read the docs.
To create a more consistent code base `assert` will no longer be used.
This change was generated by a running a sed command on all `_test.go`
files, followed by `goimports -w`.
|
|/
|
|
|
|
|
|
|
|
| |
The user agent for requests to the internal API endpoints used the
default Go provided user agent. This change updates that to always set
something else, by default `GitLab-Shell`.
Than for others importing the package, there's a new API to set it to
something else. This has been done with new method, a setter, to
maintain backwards compatibility in the API.
|
|\
| |
| |
| |
| | |
Drop "generated random correlation ID" log message
See merge request gitlab-org/gitlab-shell!417
|
|/
|
|
|
|
| |
This message happens all the time and doesn't add a lot of value.
Relates to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/1275
|
|\
| |
| |
| |
| | |
Release v13.8.0
See merge request gitlab-org/gitlab-shell!416
|
|/ |
|
|\
| |
| |
| |
| | |
Update Gitaly module dependency
See merge request gitlab-org/gitlab-shell!414
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This updates Gitaly's latest Protocol Buffer definitions, which were
last updated in Feburary 2020, with the latest version of Gitaly. This
is done to ensure the definitions are in sync with Workhorse
(https://gitlab.com/gitlab-org/gitlab-workhorse/-/merge_requests/619)
and Gitaly.
Because we started tagging Gitaly versions `v13.x.x` instead of
`v1.x.x`, `go get` refuses to update the Gitaly module using the latest
tag or SHA (https://gitlab.com/gitlab-org/gitaly/-/issues/3177). Go
tries to enforce semantic compatibility by requiring the use of module
paths (e.g. `m/v13`), and Gitaly doesn't adhere to this scheme.
To workaround this issue, we use the replace directive
(https://github.com/golang/go/wiki/Modules#when-should-i-use-the-replace-directive):
```
go mod edit -replace gitlab.com/gitlab-org/gitaly=gitlab.com/gitlab-org/gitaly@3f5e218def93024f3aafe590c22cd1b29f744105
```
|
|\ \
| |/
|/|
| |
| | |
config: Set a secret example
See merge request gitlab-org/gitlab-shell!415
|
|/
|
|
|
|
|
| |
The config.yml.example didn't include a field I was expecting to be
there, which lead me to believe the field didn't exist. This change adds
the `secret` YAML field, and describes how it interacts with the
secrets_file.
|
|\
| |
| |
| |
| |
| |
| | |
Make it possible to propagate correlation ID across processes
Closes #474
See merge request gitlab-org/gitlab-shell!413
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, gitlab-shell did not pass a context through the application.
Correlation IDs were generated down the call stack instead of passed
around from the start execution.
This has several potential downsides:
1. It's easier for programming mistakes to be made in future that lead
to multiple correlation IDs being generated for a single request.
2. Correlation IDs cannot be passed in from upstream requests
3. Other advantages of context passing, such as distributed tracing is
not possible.
This commit changes the behavior:
1. Extract the correlation ID from the environment at the start of
the application.
2. If no correlation ID exists, generate a random one.
3. Pass the correlation ID to the GitLabNet API requests.
This change also enables other clients of GitLabNet (e.g. Gitaly) to
pass along the correlation ID in the internal API requests
(https://gitlab.com/gitlab-org/gitaly/-/issues/2725).
Fixes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/474
|
|\
| |
| |
| |
| | |
hooks: Remove deprecated hooks dir
See merge request gitlab-org/gitlab-shell!411
|
|/
|
|
|
|
|
|
|
| |
Over a year ago, through e0824f17367a44e5bac84dac7197f9b45e37ab01, the
hooks in this repository were updated to not be successful, basically
block each push from happening.
This change removes the hooks, and updates the documentation. There's no
customer impact, and these changes are just part of a general cleanup.
|
|\
| |
| |
| |
| | |
Fix SAST and Dependency Scanning
See merge request gitlab-org/gitlab-shell!410
|
|/ |
|
|\
| |
| |
| |
| | |
Use docker image for Code Intelligence
See merge request gitlab-org/gitlab-shell!409
|