diff options
| author | Vasilii Iakliushin <viakliushin@gitlab.com> | 2022-04-22 13:52:06 +0200 |
|---|---|---|
| committer | Vasilii Iakliushin <viakliushin@gitlab.com> | 2022-04-26 11:07:08 +0200 |
| commit | 655ef6898ce883e71cae29c688b04830130897ec (patch) | |
| tree | a4cb64aa64f6aa89abf1fd8432caef7ec7246a6d | |
| parent | 67164bdf589ec2729f20ef4434cf83d1535a9d24 (diff) | |
| download | gitlab-shell-655ef6898ce883e71cae29c688b04830130897ec.tar.gz | |
Remove deprecated function NewHTTPClient
Contributes to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/484
Changelog: removed
| -rw-r--r-- | client/httpclient.go | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/client/httpclient.go b/client/httpclient.go index 0a5b149..bd00b6b 100644 --- a/client/httpclient.go +++ b/client/httpclient.go @@ -14,7 +14,6 @@ import ( "time" "gitlab.com/gitlab-org/labkit/correlation" - "gitlab.com/gitlab-org/labkit/log" "gitlab.com/gitlab-org/labkit/tracing" ) @@ -70,15 +69,6 @@ func validateCaFile(filename string) error { return nil } -// Deprecated: use NewHTTPClientWithOpts - https://gitlab.com/gitlab-org/gitlab-shell/-/issues/484 -func NewHTTPClient(gitlabURL, gitlabRelativeURLRoot, caFile, caPath string, readTimeoutSeconds uint64) *HttpClient { - c, err := NewHTTPClientWithOpts(gitlabURL, gitlabRelativeURLRoot, caFile, caPath, readTimeoutSeconds, nil) - if err != nil { - log.WithError(err).Error("new http client with opts") - } - return c -} - // NewHTTPClientWithOpts builds an HTTP client using the provided options func NewHTTPClientWithOpts(gitlabURL, gitlabRelativeURLRoot, caFile, caPath string, readTimeoutSeconds uint64, opts []HTTPClientOpt) (*HttpClient, error) { var transport *http.Transport |