Stop changing directory to the filesystem root

This behaviour dates from when Gitaly RPCs were executed in Ruby by a
Go subprocess. It's not needed for gitlab-shell now that it's in Go,
and it's a very strange thing for gitlab-sshd. Best just to remove it.

If we wanted to retain this behaviour, we could have an `os.Chdir` call
in the gitlab-shell binary, but I just don't think it's needed.

Changelog: fixed

1 files changed, 0 insertions, 6 deletions

diff --git a/internal/handler/exec.go b/internal/handler/exec.go
index ac59dab..0b1c56b 100644
--- a/internal/handler/exec.go
+++ b/internal/handler/exec.go
@@ -3,7 +3,6 @@ package handler
 import (
 	"context"
 	"fmt"
-	"os"
 	"strconv"
 	"strings"
 
@@ -137,11 +136,6 @@ func getConn(gc *GitalyCommand) (*GitalyConn, error) {
 		)
 	}
 
-	// Use a working directory that won't get removed or unmounted.
-	if err := os.Chdir("/"); err != nil {
-		return nil, err
-	}
-
 	// Configure distributed tracing
 	serviceName := fmt.Sprintf("gitlab-shell-%v", gc.ServiceName)
 	closer := tracing.Initialize(