summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Merge branch 'change_css_class_has_tooltip_to_has-tooltip' into 'master' Jacob Schatz2016-03-212-4/+4
| |\ \ \ | | |_|/ | |/| | | | | | | | | | | | | | | | | | change the css class has_tooltip to has-tooltip universally closes #14432 See merge request !3321
| | * | change the css class has_tooltip to has-tooltip universallychange_css_class_has_tooltip_to_has-tooltipArinde Eniola2016-03-202-4/+4
| | | |
| * | | Merge branch 'master' into 2489-soft-delete-issuesZeger-Jan van de Weg2016-03-2113-8/+660
| |\ \ \
| | * \ \ Merge branch 'issues-show-performance' into 'master' Robert Speicher2016-03-216-8/+102
| | |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve performance of viewing individual issues This MR does two things: 1. `Issue#related_branches` no longer performs Git operations that aren't needed 2. The output of `Repository#exists?` is now cached and flushed properly Combined these two changes should further cut down the amount of Git operations performed when viewing individual issues (and possibly other pages). See merge request !3296
| | | * | | Create repositories in IssuesController specsYorick Peterse2016-03-191-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the real world a project always has a repository. This fact allows code such as Issue#related_branches to work without explicitly checking if a repository exists.
| | | * | | Cache output of Repository#exists?Yorick Peterse2016-03-194-4/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This caches the output of Repository#exists? in Redis while making sure it's flushed properly when creating new repositories, deleting them, etc. For the ProjectWiki tests to work I had to make ProjectWiki#create_repo! public as testing private methods in RSpec is a bit of a pain.
| | | * | | Tweaked performance of Issue#related_branchesYorick Peterse2016-03-191-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Requesting the branch names of a repository works even when it's empty, thus there's no need to explicitly check for an empty repository. Removing this check cuts down the amount of Git operations which in turn cuts down request timings a bit. The regular expression used to compare branches was also moved out of the loop so it's created only once.
| | * | | | Merge branch 'feature/issue-move' into 'master' Kamil Trzciński2016-03-217-0/+539
| | |\ \ \ \ | | | |_|/ / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ability to move issue to another project Tasks: - [x] Create scaffold of service that will move issue to another project. - [x] Close old issue, add system note about moving issue to a new project. - [x] Create a new issue, add system note about issue being moved from old project. - [x] Check if issue can be moved to another project before executing service - [x] Check permissions when moving an issue (`:admin_issue` ability) - [x] Display select box for a new project when editing an issue - [x] Show only projects that issue can be moved into in that select box - [x] Add project select handler, helper and some permission filters to it - [x] Preserve as much information as possible, including author - [x] Prepare mechanisms that unfolds local references in issue description - [x] Rewrite issue description with references unfolding and add some specs for it - [x] Rewrite all system notes and comments attached to issue that is being moved - [x] Update `Label` so that is was able to create cross reference labels (separate MR) - [x] Add notifications about moving issue to another project - [x] Display confirmation alert/message when issue move has been requested - [x] Make it possible to undo selecting project where issue will be moved to - [x] Add column to issue, that will indicate if it has been moved to another project - [x] Do not allow to move issue that has been already moved - [x] Write top-to-bottom feature spec in RSpec instead of Spinach UI: ![issue_move_ui](/uploads/b3c6b563362c1fded9082cc0f51e5a74/issue_move_ui.png) ![issue_move_tooltip](/uploads/2ab913b06f52df1cafde9abe89bd9cb8/issue_move_tooltip.png) Closes #3024 See merge request !2831
| | | * | | Preserve created at time of notes when moving issueGrzegorz Bizon2016-03-201-0/+5
| | | | | |
| | | * | | Merge branch 'master' into feature/issue-moveGrzegorz Bizon2016-03-204-24/+24
| | | |\ \ \ | | | | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Fix bug where wrong commit ID was being used in a merge request diff to show old image Remove CHANGELOG item that was added during merge resolution Improve the "easy WIP & un-WIP from link" feature Fix specs \#to_branch_name now uses the iid as postfix Add label description in tooltip to labels in issue index and sidebar Easily (un)mark merge request as WIP using link Use specialized system notes when MR is (un)marked as WIP another attempt to fix oauth issue attempting to fix omniauth problem Conflicts: app/assets/javascripts/issuable_form.js.coffee
| | | * | | Find referable for each ref found in references rewriterGrzegorz Bizon2016-03-201-0/+15
| | | | | |
| | | * | | Rename reference unfolder to rewriter, minor refactoringsGrzegorz Bizon2016-03-201-3/+3
| | | | | |
| | | * | | Do not pass params that are not used in issue move serviceGrzegorz Bizon2016-03-201-2/+1
| | | | | |
| | | * | | Update reference unfolder according to recent ability changesGrzegorz Bizon2016-03-192-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 43d8bdb4f048cbeb5675ed9120cb1aeb415b9586 introduced additional checks for permissions to read issue in references extractor.
| | | * | | Merge branch 'master' into feature/issue-moveGrzegorz Bizon2016-03-1936-112/+1352
| | | |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (121 commits) Dedupe labels in labels selector in Dashboard pages Refactor colors and lists Add a safeguard in MergeRequest#compute_diverged_commits_count Fix an issue when the target branch of a MR had been deleted Add avatar to issue and MR pages header Cleanup somce css colors Re-group scss variables Refactor `Todo#target` Fixes issue with filter label missing on labels & milestones Rename `Todo#to_reference` to `Todo#target_reference` Fixed failing tests Updated controller with before_action Fixed other issues based on feedback Fixes issue on dashboard issues Full labels data in JSON Fixed issue with labels dropdown getting wrong labels Update CHANGELOG Use `Note#for_project_snippet?` to skip notes on project snippet Use `Commit#short_id` instead of `Commit.truncate_sha` Reuse `for_commit?` on conditional validations Update schema info comment on todo related files ... Conflicts: app/models/issue.rb db/schema.rb spec/models/issue_spec.rb
| | | * | | | Improvements in issue move feaure (refactoring)Grzegorz Bizon2016-03-192-53/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | According to endbosses' suggestions.
| | | * | | | Do not use javascript in specs for issue moveGrzegorz Bizon2016-03-171-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Feature specs that were using javascript took a long time to finish (about 10x longer) and where hitting Poltergeist timeouts. This modification skips using javascript with select2 selecbox, thus it is faster, but this also does not check some JavaScript related features.
| | | * | | | Prevent issue move if issue has been already movedGrzegorz Bizon2016-03-173-0/+79
| | | | | | |
| | | * | | | Add feature specs for issue moveGrzegorz Bizon2016-03-171-0/+77
| | | | | | |
| | | * | | | Add minor improvements in code related to issue moveGrzegorz Bizon2016-03-171-1/+1
| | | | | | |
| | | * | | | Use helper to create list of projects issue can be moved toGrzegorz Bizon2016-03-171-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This also adds confirmation message if issue move has been requested.
| | | * | | | Add new notifications for issue move actionGrzegorz Bizon2016-03-172-1/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
| | | * | | | Reuse existing issue services when moving issueGrzegorz Bizon2016-03-171-1/+1
| | | | | | |
| | | * | | | Make it possible to move issue if user is a reporterGrzegorz Bizon2016-03-171-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Discussed it here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2831#note_4190228
| | | * | | | Preserve original author when moving issueGrzegorz Bizon2016-03-171-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also wrapps entire process into transation, as rewriting references may have large memory footprint.
| | | * | | | Add implementation of reference unfolder using banzaiGrzegorz Bizon2016-03-171-3/+29
| | | | | | |
| | | * | | | Move reference unfolder for GFM to separate classGrzegorz Bizon2016-03-173-62/+55
| | | | | | |
| | | * | | | Use internal reference extractor in banzai unfold pipelineGrzegorz Bizon2016-03-171-27/+30
| | | | | | |
| | | * | | | Add reference unfold pipeline used when moving issueGrzegorz Bizon2016-03-172-2/+61
| | | | | | |
| | | * | | | Minor refactoring of issue move service and specsGrzegorz Bizon2016-03-171-2/+3
| | | | | | |
| | | * | | | Rewrite references in notes when moving issueGrzegorz Bizon2016-03-171-15/+42
| | | | | | |
| | | * | | | Take care about data being rewritten when moving issueGrzegorz Bizon2016-03-171-1/+19
| | | | | | |
| | | * | | | Use a new issue create service when moving an issueGrzegorz Bizon2016-03-171-0/+5
| | | | | | |
| | | * | | | Do not pass unsanitized params to issue move serviceGrzegorz Bizon2016-03-171-3/+7
| | | | | | |
| | | * | | | Rewrite references in issue description when moving itGrzegorz Bizon2016-03-171-6/+19
| | | | | | |
| | | * | | | Silently close old issue when it has been movedGrzegorz Bizon2016-03-171-0/+9
| | | | | | |
| | | * | | | Do not show issue move form unless user can moveGrzegorz Bizon2016-03-171-1/+1
| | | | | | |
| | | * | | | Add issue move ability and use it in move serviceGrzegorz Bizon2016-03-171-10/+60
| | | | | | |
| | | * | | | Add implementation that rewrites issue notes when movingGrzegorz Bizon2016-03-171-14/+53
| | | | | | |
| | | * | | | Add issue move implementation to controllerGrzegorz Bizon2016-03-172-11/+29
| | | | | | |
| | | * | | | Improve system notes that are added when issue is movedGrzegorz Bizon2016-03-172-10/+47
| | | | | | |
| | | * | | | Add new system note used when issue has been movedGrzegorz Bizon2016-03-172-0/+24
| | | | | | |
| | | * | | | Add scaffold of service that moves issue to another projectGrzegorz Bizon2016-03-171-0/+22
| | | | | | |
| | * | | | | Make HTTP(s) label consistent on clone barStan Hu2016-03-191-0/+19
| | | |_|/ / | | |/| | | | | | | | | | | | | | | | | | | | | Sites that use http:// for the external_url should always display HTTP on the clone bar. Similarly, sites that use https:// should show HTTPS.
| * | | | | Fix typos and dentingZeger-Jan van de Weg2016-03-212-9/+9
| | | | | |
| * | | | | Minor improvements on IssuableActionsZeger-Jan van de Weg2016-03-214-41/+56
| | | | | |
| * | | | | minor improvements and fixed specsZeger-Jan van de Weg2016-03-193-23/+29
| | | | | |
| * | | | | Dry destroy action on issuablesZeger-Jan van de Weg2016-03-191-4/+4
| | | | | |
| * | | | | Soft delete issuablesZeger-Jan van de Weg2016-03-196-6/+84
| |/ / / /
* | | | | Add specs and add visibility level to admin groupsFelipe Artur2016-03-211-0/+89
| | | | |