summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | Updated based on Ruby feedbackPhil Hughes2016-04-121-12/+13
| | | | | | | |
| * | | | | | | Tests updatePhil Hughes2016-04-122-22/+24
| | | | | | | |
| * | | | | | | Updated testsPhil Hughes2016-04-121-2/+1
| | | | | | | |
* | | | | | | | Merge branch 'fix_quick_submit_missing_in_edit_merge_request' into 'master' Jacob Schatz2016-04-121-0/+21
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix quick submit missing in edit merge request page closes #14953 ![fix](/uploads/5b80b37330929514c81299b4c8fe3efb/fix.gif) See merge request !3601
| * | | | | | | add some changes to the testfix_quick_submit_missing_in_edit_merge_requestArinde Eniola2016-04-071-11/+5
| | | | | | | |
| * | | | | | | add testArinde Eniola2016-04-071-0/+27
| | | | | | | |
* | | | | | | | Merge branch 'decouple-member-notification' into 'master' Douwe Maan2016-04-125-44/+109
|\ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Decouple membership and notifications This allow you to have notification setting per project even if you are member of group. It also creates background for having notification settings in project you are not member of. - [x] Make it work - [x] Migrations - [x] CHANGELOG - [x] More tests - [x] API For #3359 After this merge request there is still some work to be done: * create migration that remove duplicates in notification settings table and create uniq index (8.8 probably) * remove notification_level field from Member model in 9.0 * make proper API for notification settings * use `MemberCreateService` instead of Member#after_create callback for creating notification settings (after #14709) * maybe more tests Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> See merge request !3421
| * | | | | | | Fix specs for Projects::NotificationSettingsControllerDouglas Barbosa Alexandre2016-04-121-28/+0
| | | | | | | |
| * | | | | | | Improve specs for group/project notification controllerdecouple-member-notificationDouglas Barbosa Alexandre2016-04-122-3/+53
| | | | | | | |
| * | | | | | | Requires user to be signed in when changing notification settingsDouglas Barbosa Alexandre2016-04-112-0/+48
| | | | | | | |
| * | | | | | | Reuse `User#notification_settings_for` when it's possibleDouglas Barbosa Alexandre2016-04-111-2/+2
| | | | | | | |
| * | | | | | | Merge branch 'master' into decouple-member-notificationDouglas Barbosa Alexandre2016-04-118-22/+204
| |\ \ \ \ \ \ \
| * \ \ \ \ \ \ \ Merge branch 'master' into decouple-member-notificationDouglas Barbosa Alexandre2016-04-0862-262/+1581
| |\ \ \ \ \ \ \ \ | | | |_|_|/ / / / | | |/| | | | | |
| * | | | | | | | Add spec for user_id uniq in NotificationSetting modelDmitriy Zaporozhets2016-03-301-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | | | | Refactor notification helper and fix notification serviceDmitriy Zaporozhets2016-03-301-28/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | | | | Small refactoring and cleanup of notification logicDmitriy Zaporozhets2016-03-302-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | | | | Update NotificationService to use NotificationSettings instead of membershipDmitriy Zaporozhets2016-03-301-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | | | | Introduce NotificationSetting modelDmitriy Zaporozhets2016-03-301-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It will hold notification setting per group or per project. It will allow get rid of notification level stored in Member model Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | | | | | | Merge branch 'api-delete-note' into 'master' Rémy Coutable2016-04-122-0/+76
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Delete notes via API Supports deleting issues, snippets, and merge requests via the API. * Closes #14944 * Closes #14845 * Closes #6060 @zj I did not see that you assigned yourself in #6060. Hopefully, you did not start yet. @rymai In #6060 this is targeted for 8.7 release. Could you review that and maybe this still lands in 8.7. See merge request !3557
| * | | | | | | | | Adapt tests to new testing guidelinesRobert Schilling2016-04-122-11/+10
| | | | | | | | | |
| * | | | | | | | | Fix code review issuesRobert Schilling2016-04-122-5/+24
| | | | | | | | | |
| * | | | | | | | | Delete notes via APIRobert Schilling2016-04-122-0/+58
| | |_|_|_|/ / / / | |/| | | | | | |
* | | | | | | | | Merge branch 'api-get-tag' into 'master' Rémy Coutable2016-04-121-0/+17
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | API: Ability to retrieve a single tag * Closes #14330 /cc @dblessing See merge request !3577
| * | | | | | | | | Fix minor styling issues from code reviewRobert Schilling2016-04-121-3/+3
| | | | | | | | | |
| * | | | | | | | | API: Ability to retrieve a single tagRobert Schilling2016-04-121-0/+17
| | | | | | | | | |
* | | | | | | | | | Allow a project member to leave the projected through the APIremove-myself-from-project-api-7687Zeger-Jan van de Weg2016-04-121-3/+17
| |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | API: Add iid filter to milestonesRobert Schilling2016-04-121-3/+5
|/ / / / / / / /
* | | | | | | | Merge branch 'issue_1752' into 'master' Robert Speicher2016-04-111-4/+19
|\ \ \ \ \ \ \ \ | |_|_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix milestone removal problem when editing issues fixes #1752 See merge request !3571
| * | | | | | | improve specs code syntaxissue_1752Felipe Artur2016-04-071-11/+11
| | | | | | | |
| * | | | | | | Fix milestone removal problem when editing issuesFelipe Artur2016-04-061-0/+15
| | | | | | | |
* | | | | | | | Merge branch 'dashboard-filter-milestone' into 'master' Jacob Schatz2016-04-111-0/+54
|\ \ \ \ \ \ \ \ | |_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed issue with dashboard/issues not filtering by milestone Closes #15128 See merge request !3650
| * | | | | | | Fixed issue with dashboard/issues not filtering by milestonedashboard-filter-milestonePhil Hughes2016-04-111-0/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #15128
* | | | | | | | Merge branch 'metrics-measure-block-transaction' into 'master' Yorick Peterse2016-04-112-11/+14
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Store block timings as transaction values See merge request !3649
| * | | | | | | | Fixed stubbing for Gitlab::Metrics specsYorick Peterse2016-04-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the measure method uses Transaction.current directly the SQL subscriber (Subscribers::ActiveRecord) will add timings of queries triggered by DB cleaner.
| * | | | | | | | Track call counts in Gitlab::Metrics.measure_blockmetrics-measure-block-transactionYorick Peterse2016-04-111-0/+3
| | | | | | | | |
| * | | | | | | | Added specs for Gitlab::Metrics::System.cpu_timeYorick Peterse2016-04-111-0/+6
| | | | | | | | |
| * | | | | | | | Store block timings as transaction valuesYorick Peterse2016-04-111-11/+5
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes it easier to query, simplifies the code, and makes it possible to figure out what transaction the data belongs to (simply because it's now stored _in_ the transaction). This new setup keeps track of both the real/wall time _and_ CPU time spent in a block, both measured using milliseconds (to keep all units the same).
* | | | | | | | Merge branch 'rs-form_errors' into 'master' Dmitriy Zaporozhets2016-04-111-0/+46
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Standardize the way we check for and display form errors - Some views had a "Close" button. We've removed this, because we don't want users accidentally hiding the validation errors and not knowing what needs to be fixed. - Some views used `li`, some used `p`, some used `span`. We've standardized on `li`. - Some views only showed the first error. We've standardized on showing all of them. - Some views added an `#error_explanation` div, which we've made standard. See merge request !3531
| * | | | | | | | Standardize the way we check for and display form errorsrs-form_errorsRobert Speicher2016-04-041-0/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Some views had a "Close" button. We've removed this, because we don't want users accidentally hiding the validation errors and not knowing what needs to be fixed. - Some views used `li`, some used `p`, some used `span`. We've standardized on `li`. - Some views only showed the first error. We've standardized on showing all of them. - Some views added an `#error_explanation` div, which we've made standard.
* | | | | | | | | Merge branch 'mr-ui-update' into 'master' Jacob Schatz2016-04-111-3/+8
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updated UI for new merge request Closes #2540 ![Screen_Shot_2016-03-29_at_12.53.18](/uploads/426e603675171f0dc4e0af83c7762eba/Screen_Shot_2016-03-29_at_12.53.18.png) ![Screen_Shot_2016-03-29_at_12.53.13](/uploads/645ad7955acfb9f7693245fcc048ee49/Screen_Shot_2016-03-29_at_12.53.13.png) See merge request !3228
| * | | | | | | | Build fixPhil Hughes2016-04-061-3/+8
| | | | | | | | |
* | | | | | | | | Merge branch 'rs-remove-markdown-tips' into 'master' Dmitriy Zaporozhets2016-04-111-7/+0
|\ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove `random_markdown_tip` helper Only usage got removed in !3442 See merge request !3637
| * | | | | | | | Remove `random_markdown_tip` helperrs-remove-markdown-tipsRobert Speicher2016-04-091-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only usage got removed in !3442
* | | | | | | | | write test to prevent reoccurence of issueprevent_users_from_upvoting_downvoting_emojiArinde Eniola2016-04-091-0/+64
|/ / / / / / / /
* | | | | | | | Merge branch '14400-diff-redesign' into 'master' Jacob Schatz2016-04-091-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Diff redesign Fixes #14400 Fixes #13500 ![diffs_redesign](/uploads/16da9557e497114d886ef5ece2f306b3/diffs_redesign.gif) See merge request !3476
| * | | | | | | | Diff design updatesAnnabel Dunstone2016-04-071-1/+1
| | | | | | | | |
| * | | | | | | | Update diff colors and iconsAnnabel Dunstone2016-04-071-1/+1
| | |_|_|_|/ / / | |/| | | | | |
* | | | | | | | Instrument Rails cache codeinstrument-rails-cacheYorick Peterse2016-04-081-0/+71
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to track how much time of a transaction is spent in dealing with cached data.
* | | | | | | Merge branch 'issue_14012' into 'master' Rémy Coutable2016-04-071-0/+6
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix problem when creating milestones in groups without projects Fixes #14012 See merge request !3481
| * | | | | | Implement review suggestionsFelipe Artur2016-04-071-1/+1
| | | | | | |