summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'avoid-unrelated-errors-in-quarantined-specs' into 'master'Lin Jen-Shin2019-05-101-1/+1
|\ | | | | | | | | Fix unrelated errors when teardowning quanrantined specs See merge request gitlab-org/gitlab-ce!28240
| * Fix unrelated errors when teardowning quanrantined specsavoid-unrelated-errors-in-quarantined-specsRémy Coutable2019-05-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Since we're skipping the example in a before hook, the @_subscribers instance variable that is normally set in the setup phase of the test by https://github.com/rails/rails-controller-testing/blob/21014e48be124dd8d0af250b79f682519d445015/lib/rails/controller/testing/template_assertions.rb#L21 isn't set but the teardown phase of the example still happens and tries to iterate over the array of subcribers: https://github.com/rails/rails-controller-testing/blob/21014e48be124dd8d0af250b79f682519d445015/lib/rails/controller/testing/template_assertions.rb#L54 Using an around hook allows the @_subscribers instance variable to be set. Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Merge branch 'sh-fix-lfs-download-errors' into 'master'Douglas Barbosa Alexandre2019-05-101-1/+19
|\ \ | | | | | | | | | | | | | | | | | | Properly handle LFS Batch API response in project import Closes #61624 See merge request gitlab-org/gitlab-ce!28223
| * | Properly handle LFS Batch API response in project importsh-fix-lfs-download-errorsStan Hu2019-05-091-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Project imports were failing with `undefined method each_with_object for String` because the import was attempting to parse the LFS Batch API and failing due to the fact that the Content-Type wasn't a supported format (e.g. application/vnd.git-lfs+json instead of application/json). We now parse the body as JSON. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61624
* | | Merge branch 'winh-simplify-frontend-fixtures' into 'master'Rémy Coutable2019-05-1030-165/+98
|\ \ \ | | | | | | | | | | | | | | | | Simplify frontend test fixtures See merge request gitlab-org/gitlab-ce!27531
| * | | Remove trailing empty lineswinh-simplify-frontend-fixturesWinnie Hellmann2019-05-102-6/+0
| | | |
| * | | Remove unused fixture_file_name parametersWinnie Hellmann2019-05-103-20/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | for f in $(find spec/javascripts/fixtures/ -name '*.rb') do sed -E -e 's/(, ){0,1}(fixture_file_name| example\.description)(, ){0,1}//' < $f > $f.tmp; mv $f.tmp $f done
| * | | Remove example block parametersWinnie Hellmann2019-05-1027-56/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | for f in $(find spec/javascripts/fixtures/ -name '*.rb') do sed 's/do |example|/do/' < $f > $f.tmp; mv $f.tmp $f done
| * | | Remove duplicate store_frontend_fixture() callsWinnie Hellmann2019-05-1027-44/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | for f in $(find spec/javascripts/fixtures/ -name '*.rb') do grep -v store_frontend_fixture < $f > $f.tmp; mv $f.tmp $f done
| * | | Merge balsamiq fixture into raw file fixturesWinnie Hellmann2019-05-102-18/+7
| | | |
| * | | Merge PDF fixture into raw file fixturesWinnie Hellmann2019-05-102-18/+7
| | | |
| * | | Expose response variable for raw file fixturesWinnie Hellmann2019-05-101-7/+8
| | | |
| * | | Call store_frontend_fixture() in JavaScriptFixturesHelpersWinnie Hellmann2019-05-101-7/+11
| | | |
* | | | Resolve "JIRA service: NoMethodError: undefined method `find' for nil:NilClass"Patrick Derichs2019-05-101-0/+7
| | | |
* | | | Don't run full gc in AfterImportServicesh-revert-full-gc-after-importStan Hu2019-05-101-1/+1
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | Pull mirrors would run the `Projects::AfterImportService`, which would force a `git gc` each time it finished. This is overkill and not necessary now that we have refs packed more frequently (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27826). Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11556
* | | Fix Error 500 when inviting user already presentStan Hu2019-05-101-1/+12
| |/ |/| | | | | | | | | | | A project admin attempting to invite an already-invited user will see a confusing Error 500 message. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61574
* | Merge branch 'fix-60425' into 'master'Nick Thomas2019-05-094-12/+20
|\ \ | | | | | | | | | | | | | | | | | | Change DetectRepositoryLanguagesWorker to not receive user Closes #60425 See merge request gitlab-org/gitlab-ce!28091
| * | Change DetectRepositoryLanguagesWorker to not receive userDiego Silva2019-05-094-12/+20
| | | | | | | | | | | | Fixes #60425
* | | Merge branch '61635-flaky-spec-dashboard-user_filters_projects_spec' into ↵Stan Hu2019-05-091-44/+12
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Resolve "Flaky spec: "Dashboard > User filters projects with search bar Sorting Sorting by Stars sorts the project list" / spec/features/dashboard/user_filters_projects_spec.rb:257" Closes #61635 See merge request gitlab-org/gitlab-ce!28224
| * | | Fix a flaky spec for sorting projects in dashboard61635-flaky-spec-dashboard-user_filters_projects_specRémy Coutable2019-05-091-44/+12
| | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | Update usage_data_spec to match EEJames Lopez2019-05-091-2/+2
| |/ / |/| |
* | | Whitelist Gitaly N+1 for forking in testsNick Thomas2019-05-091-6/+17
|/ / | | | | | | | | | | | | | | | | | | | | This helper is right on the limit of the number of calls being made. When the request store is enabled, and Sidekiq is running in inline mode, just a couple of additional actions result in it being pushed over the line. The operation is entirely artificial, since in reality we'd perform these requests in multiple separate processes, so just whitelist it for now.
* | Generate Let's Encrypt private keyVladimir Shushlin2019-05-091-0/+11
| |
* | Fix discussion notes spec timeout61596-increase-timeout-for-discussion-notes-specPaul Slaughter2019-05-081-2/+5
| |
* | Refactor spec to reload existing_label right after creationPatrick Derichs2019-05-081-0/+40
| | | | | | | | | | This will avoid timestamp comparison issues later within equality check with attributes
* | Remove jira_spec from quarantine60953-unquarantine-jira-specHeinrich Lee Yu2019-05-081-1/+1
| |
* | Merge branch '58404-set-default-max-depth-for-GraphQL' into 'master'Sean McGivern2019-05-083-32/+100
|\ \ | | | | | | | | | | | | | | | | | | 58404 - setup max depth for graphql Closes #58404 See merge request gitlab-org/gitlab-ce!25737
| * | 58404 - setup max depth for graphqlKen Ding2019-05-073-32/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 58404 - add change log 58404 - add spec 58404 - add more spec to test depth 2 58404 - fix spec 58404 - fix rubocop 58404 - refactor the code by Bob's advice 58404 - revert changes of all_graphql_fields_for 58404 - change text only 58404 - fix rspec according to gitlab's standard 58404 - revert previous spec 58404 - fix rubocop
* | | Merge branch 'fe-header-row' into 'master'Phil Hughes2019-05-082-19/+19
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Adds header column to variables list Closes #46806 See merge request gitlab-org/gitlab-ce!28060
| * | | Adds header column to variables listfe-header-rowFilipa Lacerda2019-05-072-19/+19
| | | | | | | | | | | | | | | | | | | | For the variables list in CI/CD settings this commits adds an header row with titles
* | | | Merge branch 'winh-notes-error-handling' into 'master'Fatih Acet2019-05-082-0/+62
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Handle errors in successful notes reply Closes #61377 See merge request gitlab-org/gitlab-ce!28082
| * | | | Add failing test for hasQuickActionsWinnie Hellmann2019-05-071-0/+17
| | | | |
| * | | | Add failing test for saveNote error handlingWinnie Hellmann2019-05-071-0/+45
| | |_|/ | |/| |
* | | | Added user time settings fields to profileEzekiel Kigbo2019-05-075-0/+156
|/ / / | | | | | | | | | | | | | | | Udpated user_edit_profile_spec with time preferences Minor update form fields
* | | Add custom metrics form to dashboardAdriel Santiago2019-05-071-2/+5
| | | | | | | | | | | | Use existing form to allow users to add custom metrics via the dashboard
* | | Merge branch '56850-add-new-unicorn-metrics' into 'master'Ash McKenzie2019-05-073-8/+71
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Add new Unicorn metrics" Closes #56850 See merge request gitlab-org/gitlab-ce!27474
| * | | Cleanup spec by removing not needed letRyan Cobb2019-04-301-2/+1
| | | |
| * | | Update docs and calculate process start time via proc tableRyan Cobb2019-04-242-9/+15
| | | | | | | | | | | | | | | | | | | | | | | | This updates monitor docs to reflect the new ruby and unicorn metrics as well as making it so we fetch process start time via the proc table instead of via CLOCK_BOOTTIME
| * | | Move process specific metrics to ruby samplerRyan Cobb2019-04-242-8/+25
| | | | | | | | | | | | | | | | | | | | These metrics are not unicorn specific and can be used across ruby processes
| * | | Adds new metrics for unicorn monitoringRyan Cobb2019-04-182-5/+46
| | | | | | | | | | | | | | | | | | | | | | | | This adds new metrics for monitoring unicorn. These metrics include process_cpu_seconds_total, process_start_time_seconds, process_max_fds, and unicorn_workers.
* | | | Confirm existence of head_pipeline if pipeline success requiredKerri Miller2019-05-071-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pipelines are created by an async worker, so a rapid sequence of API calls can trigger a state where the pipeline, whose existence is part of determining if we wait for the pipeline to successfully complete before merging, can trigger the MR to be immediately merged instead. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55127
* | | | Merge branch '60462-empty-pipeline-section' into 'master'Mayra Cabrera2019-05-072-0/+35
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes empty block in MR widget Closes #60462 See merge request gitlab-org/gitlab-ce!27462
| * | | | Fixes empty block in MR widgetFilipa Lacerda2019-05-072-0/+35
| | | | | | | | | | | | | | | | | | | | | | | | | This commit prevents the pipeline block to be rendered when no pipeline information is provided
* | | | | Merge branch '54405-resolve-discussion-when-applying-a-suggested-change' ↵Phil Hughes2019-05-074-100/+230
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Resolve "Resolve discussion when suggestion is applied" Closes #54405 See merge request gitlab-org/gitlab-ce!28160
| * | | | | Resolve discussion when suggestion is applied54405-resolve-discussion-when-applying-a-suggested-changePaul Slaughter2019-05-074-100/+230
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Adds color and a tooltip to describe this new behavior - Does not resolve if discussion is already resolved - Adds an action `resolveDiscussion` to simplify `toggleResolveNote` - Updates docs https://gitlab.com/gitlab-org/gitlab-ce/issues/54405
* | | | | | Merge branch 'sh-fix-related-merge-requests-path' into 'master'Rémy Coutable2019-05-071-0/+34
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use a path for the related merge requests endpoint Closes #61280 See merge request gitlab-org/gitlab-ce!28171
| * | | | | | Use a path for the related merge requests endpointsh-fix-related-merge-requests-pathStan Hu2019-05-071-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Hosts using a non-standard configuration may have a different hostname/port/scheme than what may be configured on the GitLab server. While expose_url should generate a proper URL, there are cases where it may not work. Since we don't need the full URL, we can use the relative path. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61280
* | | | | | | Add external dashboard linkAdriel Santiago2019-05-072-0/+162
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add settings for linking to external dashboard from metrics dashboard
* | | | | | | Merge branch '58882-reduce-test-view-port' into 'master'Rémy Coutable2019-05-074-9/+23
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Try to reduce testing viewport Closes #58882 See merge request gitlab-org/gitlab-ce!27385
| * | | | | | | Avoid quick action prompt blocking preview button58882-reduce-test-view-portLin Jen-Shin2019-05-072-5/+14
| | | | | | | |