summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
...
| | | * | | | | | | | | | | | rempves tests for "you have master access" textimproved-leave-projectJacob Schatz2016-01-041-1/+0
| | | | | | | | | | | | | | |
| | | * | | | | | | | | | | | adds proper `it` for multi line. adds `find` with correct id for button.Jacob Schatz2015-12-281-3/+3
| | | | | | | | | | | | | | |
| | | * | | | | | | | | | | | Merge branch 'master' into improved-leave-projectJacob Schatz2015-12-281-1/+1
| | | |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | |_|_|_|_|_|_|_|_|_|/ | | | | |/| | | | | | | | | |
| | | * | | | | | | | | | | | fixes tests failingJacob Schatz2015-12-281-1/+4
| | | | | | | | | | | | | | |
| | * | | | | | | | | | | | | Merge branch 'metrics-tuning' into 'master' Dmitriy Zaporozhets2016-01-058-136/+74
| | |\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tuning of metrics data to store This removes data we don't really need, as well as making sure we don't overload any cache stores or databases. See merge request !2265
| | | * | | | | | | | | | | | | Fix Rubocop styling in AR subscriber specsmetrics-tuningYorick Peterse2016-01-041-1/+1
| | | | | | | | | | | | | | | |
| | | * | | | | | | | | | | | | Automatically prefix transaction series namesYorick Peterse2016-01-045-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures Rails and Sidekiq transactions are split into the series "rails_transactions" and "sidekiq_transactions" respectively.
| | | * | | | | | | | | | | | | Use separate series for Rails/Sidekiq sample statsYorick Peterse2016-01-041-8/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the need for any tags to differentiate between Sidekiq and Rails statistics while still being able to separate the two.
| | | * | | | | | | | | | | | | Track total method call times per transactionYorick Peterse2016-01-041-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes it easier to see where time is spent without having to aggregate all the individual points in the method_calls series.
| | | * | | | | | | | | | | | | Track total query/view timings in transactionsYorick Peterse2016-01-042-0/+38
| | | | | | | | | | | | | | | |
| | | * | | | | | | | | | | | | Ability to increment custom transaction valuesYorick Peterse2016-01-041-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will be used to store/increment the total query/view rendering timings on a per transaction basis. This in turn can greatly reduce the amount of metrics stored.
| | | * | | | | | | | | | | | | Removed tracking of hostnames for metricsYorick Peterse2015-12-312-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This isn't hugely useful and mostly wastes InfluxDB space. We can re-add this whenever needed (but only once we really need it).
| | | * | | | | | | | | | | | | Use separate series for Rails/Sidekiq transactionsYorick Peterse2015-12-315-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the need for tagging all metrics with a "process_type" tag.
| | | * | | | | | | | | | | | | Cache InfluxDB settings after the first useYorick Peterse2015-12-311-9/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures we don't need to load anything from either PostgreSQL or the Rails cache whenever creating new InfluxDB connections.
| | | * | | | | | | | | | | | | Removed tracking of raw SQL queriesYorick Peterse2015-12-312-125/+0
| | | | |_|/ / / / / / / / / / | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This particular setup had 3 problems: 1. Storing SQL queries as tags is very inefficient as InfluxDB ends up indexing every query (and they can get pretty large). Storing these as values instead means we can't always display the SQL as easily. 2. We already instrument ActiveRecord query methods, thus we already have timing information about database queries. 3. SQL obfuscation is difficult to get right and I'd rather not expose sensitive data by accident.
| | * | | | | | | | | | | | | Don't notify users twice if they are both project watchers and subscribersStan Hu2016-01-041-0/+12
| | | |_|_|_|_|/ / / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #4708
| | * | | | | | | | | | | | Merge branch 'show-all-builds-by-default' into 'master' Robert Speicher2016-01-042-54/+88
| | |\ \ \ \ \ \ \ \ \ \ \ \ | | | |_|_|_|_|/ / / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Show all builds by default in the builds page Fixes #4240 See merge request !2243
| | | * | | | | | | | | | | Show 'All' tab by default in the builds pageshow-all-builds-by-defaultDouglas Barbosa Alexandre2016-01-042-54/+88
| | | | | | | | | | | | | |
| | * | | | | | | | | | | | Merge branch 'rs-issue-201' into 'master' Dmitriy Zaporozhets2016-01-041-1/+1
| | |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevent duplicate "username has already been taken" validation message Closes #201 - two-year-old bug, woo! :boom: :tada: See merge request !2279
| | | * | | | | | | | | | | | Prevent duplicate "username has already been taken" validation messagers-issue-201Robert Speicher2016-01-021-1/+1
| | | | |/ / / / / / / / / / | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #201 - two-year-old bug, woo! :boom: :tada:
| | * | | | | | | | | | | | Merge branch 'extra-system-hooks' into 'master' Stan Hu2016-01-041-14/+33
| | |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added system hooks messages for renaming and transferring a project This is work in progress but I wanted to get some feedback on it in case there is something I've missed or a better way to do it. As the title says when a project is renamed or transferred to another group a system hook message is generated. Currently adds a couple of extra properties to the standard project system hooks messages. old_path_with_namespace - The old path of the project so we can see what has been renamed / transferred changed_at - The time that change took place My main concern is if there is a better way of doing this than passing the extra_data variable into the system hook. Would it be better to extend the project model with these 2 items as transient properties as I doubt they would need to be saved to the database? The other I've also seen, but can't find, someone talking about the emails sent when a project is renamed or transferred doesn't reference the original project path so if you have similarly named projects then you might not know what has been moved. I think the extra_data (or however it is best to implement this) would allow the extra information to be sent in emails. Closes [System hooks for project transfer and repository rename](http://feedback.gitlab.com/forums/176466-general/suggestions/6006233-system-hooks-for-project-transfer-and-repository-r) See merge request !611
| | | * | | | | | | | | | | | Added system hooks messages for renaming and transferring a projectSteve Norman2016-01-041-14/+33
| | | | |/ / / / / / / / / / | | | |/| | | | | | | | | |
| | * | | | | | | | | | | | remove public field from namespace and refactoringnamespace-clean_upValery Sizov2016-01-044-125/+1
| | |/ / / / / / / / / / /
| | * | | | | | | | | | | Optimize CSS expressions produced by Nokogiriautocomplete-performanceYorick Peterse2015-12-311-0/+13
| | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nokogiri produces inefficient XPath expressions when given CSS expressions such as "a.gfm". Luckily these expressions can be optimized quite easily while still achieving the same results. In the two cases where this optimization is applied the run time has been reduced from around 170 ms to around 15 ms.
| * | | | | | | | | | | Add some fixes after reviewTomasz Maczukin2016-01-131-6/+6
| | | | | | | | | | | |
| * | | | | | | | | | | Change 'trigger_id' to 'token' as resource ID in triggers APITomasz Maczukin2016-01-071-28/+14
| | | | | | | | | | | |
| * | | | | | | | | | | Get show details feature to triggers APITomasz Maczukin2016-01-051-5/+51
| | | | | | | | | | | |
| * | | | | | | | | | | Add create feature to triggers APITomasz Maczukin2016-01-051-0/+29
| | | | | | | | | | | |
| * | | | | | | | | | | Add delete feature to triggers APITomasz Maczukin2016-01-051-0/+33
| | | | | | | | | | | |
| * | | | | | | | | | | Fix ci_trigger_request factoryTomasz Maczukin2016-01-051-1/+1
| | | | | | | | | | | |
| * | | | | | | | | | | Add triggers feature to APITomasz Maczukin2016-01-042-4/+43
| |/ / / / / / / / / /
| * | | | | | | | | | Removed various default metrics tagsreduce-influxdb-tagsYorick Peterse2015-12-311-3/+0
| | |_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While it's useful to keep track of the different versions (Ruby, GitLab, etc) doing so for every point wastes disk space and possibly also RAM (which InfluxDB is all to eager to gobble up). If we want to see the performance differences between different GitLab versions simply looking at the performance since the last release date should suffice.
| * | | | | | | | | Merge branch 'upvote_count_to_api' into 'master' Valery Sizov2015-12-291-0/+14
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert upvotes and downvotes params back to MR API issue https://gitlab.com/gitlab-org/gitlab-ce/issues/3672 See merge request !2212
| | * | | | | | | | | Revert upvotes and downvotes params to MR APIValery Sizov2015-12-281-0/+14
| | | | | | | | | | |
| * | | | | | | | | | Write to InfluxDB directly via UDPYorick Peterse2015-12-295-62/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the need for Sidekiq and any overhead/problems introduced by TCP. There are a few things to take into account: 1. When writing data to InfluxDB you may still get an error if the server becomes unavailable during the write. Because of this we're catching all exceptions and just ignore them (for now). 2. Writing via UDP apparently requires the timestamp to be in nanoseconds. Without this data either isn't written properly. 3. Due to the restrictions on UDP buffer sizes we're writing metrics one by one, instead of writing all of them at once.
| * | | | | | | | | | Strip newlines from obfuscated SQLYorick Peterse2015-12-291-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Newlines aren't really needed and they may mess with InfluxDB's line protocol.
| * | | | | | | | | | Merge branch 'fix-spelling-mistake' into 'master' Robert Speicher2015-12-291-3/+3
| |\ \ \ \ \ \ \ \ \ \ | | |_|_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix spelling mistake, thanks Connor. [ci skip] See merge request !2227
| | * | | | | | | | | Fix spelling mistake, thanks Connor.fix-spelling-mistakeSytse Sijbrandij2015-12-281-3/+3
| | | |/ / / / / / / | | |/| | | | | | |
* | | | | | | | | | More refactoring from last code review. #3945Rubén Dávila2016-01-144-279/+339
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use commit objects instead of IDs when generating diffs * Use proper references when generating MR's source and target * Update broken specs
* | | | | | | | | | Add inline diff markers in highlighted diffs.Douwe Maan2016-01-141-2/+2
| | | | | | | | | |
* | | | | | | | | | Add more specs. #3945Rubén Dávila2016-01-121-0/+18
| | | | | | | | | |
* | | | | | | | | | Fix broken specs. #3945Rubén Dávila2016-01-082-87/+86
| | | | | | | | | |
* | | | | | | | | | Fix broken specs. #3945Rubén Dávila2016-01-082-2/+3
| | | | | | | | | |
* | | | | | | | | | Update specs. #3945Rubén Dávila2016-01-081-16/+15
| | | | | | | | | |
* | | | | | | | | | Don't process inline diffs on backend. #3945Rubén Dávila2016-01-071-39/+0
| | | | | | | | | |
* | | | | | | | | | Fix broken spec. #3945Rubén Dávila2015-12-311-8/+4
| | | | | | | | | |
* | | | | | | | | | Apply syntax highlighting when expanding diff plus some refactor. #3945Rubén Dávila2015-12-311-13/+29
| | | | | | | | | |
* | | | | | | | | | Don't modify "match" diff lines. #3945Rubén Dávila2015-12-301-0/+5
| | | | | | | | | |
* | | | | | | | | | A bit of refactoring. #3945Rubén Dávila2015-12-301-1/+1
| | | | | | | | | |
* | | | | | | | | | Add specs for Gitlab::Diff::Highlight. #3945Rubén Dávila2015-12-301-0/+28
| | | | | | | | | |
View Lorry Controller Status