summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Enable RSpec/FilePath copenable-spec-file-name-copSean McGivern2017-04-2635-587/+342
| | | | | | - Ignore JS fixtures - Ignore qa directory - Rewrite concern specs to put concern name first
* Merge branch '29903-remove-user-is-admin-flag-from-api' into 'master' Sean McGivern2017-04-254-4/+18
|\ | | | | | | | | | | | | Don't display the `is_admin?` flag for user API responses Closes #29903 See merge request !10846
| * Don't display the `is_admin?` flag for user API responses.Timothy Andrew2017-04-254-4/+18
| | | | | | | | | | | | | | | | | | | | | | - To prevent an attacker from enumerating the `/users` API to get a list of all the admins. - Display the `is_admin?` flag wherever we display the `private_token` - at the moment, there are two instances: - When an admin uses `sudo` to view the `/user` endpoint - When logging in using the `/session` endpoint
* | Merge branch 'gitaly-testing-toml' into 'master' Rémy Coutable2017-04-251-3/+4
|\ \ | | | | | | | | | | | | | | | | | | Gitaly testing toml Closes gitaly#182 See merge request !10605
| * | Configure Gitaly through settings file instead of ENV varsgitaly-testing-tomlAlejandro Rodríguez2017-04-181-3/+4
| | |
* | | Merge branch 'use-jquery-on-blob-fork-suggestion' into 'master' Jacob Schatz2017-04-241-15/+16
|\ \ \ | | | | | | | | | | | | | | | | Use jQuery niceness on blob_fork_suggestion See merge request !10858
| * | | Use jQuery niceness on blob_fork_suggestionuse-jquery-on-blob-fork-suggestionEric Eastwood2017-04-221-15/+16
| | | | | | | | | | | | | | | | | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10602#note_27871752
* | | | Merge branch 'add-aria-to-icon' into 'master' Jacob Schatz2017-04-241-0/+15
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Add aria to icon See merge request !10670
| * | | | Improve specsadd-aria-to-iconClement Ho2017-04-241-1/+3
| | | | |
| * | | | Add testsClement Ho2017-04-181-0/+13
| | | | |
* | | | | Merge branch 'dm-fix-individual-notes-reply-attributes' into 'master' Sean McGivern2017-04-241-0/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ensure replying to an individual note by email creates a note with its own discussion ID Closes #31067 See merge request !10890
| * | | | | Ensure replying to an individual note by email creates a note with its own ↵dm-fix-individual-notes-reply-attributesDouwe Maan2017-04-241-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | discussion ID
* | | | | | Merge branch 'notebooklab-in-repo' into 'master' Jacob Schatz2017-04-248-1/+417
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moved NotebookLab assets into repo See merge request !10630
| * \ \ \ \ \ Merge branch 'master' into notebooklab-in-reponotebooklab-in-repoPhil Hughes2017-04-1310-97/+223
| |\ \ \ \ \ \
| * \ \ \ \ \ \ Merge branch 'master' into notebooklab-in-repoPhil Hughes2017-04-1329-328/+1048
| |\ \ \ \ \ \ \
| * | | | | | | | Pull in fixture files from the repoPhil Hughes2017-04-116-7/+49
| | | | | | | | |
| * | | | | | | | Moved NotebookLab assets into repoPhil Hughes2017-04-116-0/+374
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moved all the notebooklab assets into the GitLab repo
* | | | | | | | | Merge branch 'sh-optimize-milestone-polymorphic-url' into 'master' Sean McGivern2017-04-241-0/+15
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Eliminate N+1 queries in loading namespaces for every issuable in milestones See merge request !10871
| * | | | | | | | | Optimize project namespace lookup for milestones and add specssh-optimize-milestone-polymorphic-urlStan Hu2017-04-241-0/+15
| | |_|_|/ / / / / | |/| | | | | | |
* | | | | | | | | Merge branch 'dm-fix-position-tracer-for-hidden-lines' into 'master' Sean McGivern2017-04-241-7/+2
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix commenting on an existing discussion on an unchanged line that is no longer in the diff Closes #31339 See merge request !10888
| * | | | | | | | | Fix commenting on an existing discussion on an unchanged line that is no ↵Douwe Maan2017-04-241-7/+2
| |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | longer in the diff
* | | | | | | | | Merge branch '30305-oauth-token-push-code' into 'master' Rémy Coutable2017-04-242-3/+3
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow OAuth clients to push code Closes #30305 See merge request !10677
| * | | | | | | | | Allow OAuth clients to push code30305-oauth-token-push-codeTimothy Andrew2017-04-132-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - We currently support fetching code with username = 'oauth2' and password = <access_token>. - Trying to _push_ code with the same credentials fails with an authentication error. - There's no reason this shouldn't be enabled, especially since we allow the OAuth client to create deploy keys with push access: https://docs.gitlab.com/ce/api/deploy_keys.html#add-deploy-key
* | | | | | | | | | Merge branch 'jacopo-beschi/gitlab-ce-29712-unnecessary-wait-for-ajax'Rémy Coutable2017-04-24168-362/+87
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See merge request !10567 Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | | | | | | Unnecessary "include WaitForAjax" and "include ApiHelpers"Jacopo2017-04-21169-364/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs. Removed unnecessary usage of `api:true`
* | | | | | | | | | | Merge branch 'sh-optimize-duplicate-routable-full-path' into 'master' Sean McGivern2017-04-241-0/+18
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cache Routable#full_path in RequestStore to reduce duplicate route loads See merge request !10872
| * | | | | | | | | | | Cache Routable#full_path in RequestStore to reduce duplicate route loadssh-optimize-duplicate-routable-full-pathStan Hu2017-04-241-0/+18
| | |_|/ / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We see in #27387 that a call to `polymorphic_path` will cause duplicate SELECT route calls for each merge request in a milestone. This happens because calling `project.namespace.becomes(Namespace)` will instantiate a new instance of a Namespace for each merge request, which causes a N+1 query on the routes table. This change caches the state of the route by the specific class and ID, which dramatically eliminates duplicate work.
* | | | | | | | | | | Merge branch 'tc-realtime-every-pipeline-on-mr' into 'master' Kamil Trzciński2017-04-243-31/+66
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Properly expire cache for **all** MRs of a pipeline Closes #31040 See merge request !10770
| * | | | | | | | | | | Simplify specs and remove unnecessary attributestc-realtime-every-pipeline-on-mrToon Claes2017-04-242-13/+4
| | | | | | | | | | | |
| * | | | | | | | | | | Refactor ExpirePipelineCacheWorker#performToon Claes2017-04-242-8/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make it gracefully handle unexisting pipelines and refactor iterating all the merge request paths.
| * | | | | | | | | | | Use a better performing query to find all MRs for pipelineToon Claes2017-04-242-1/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | And add some specs.
| * | | | | | | | | | | Properly expire cache for **all** MRs of a pipelineToon Claes2017-04-242-7/+7
| |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Turn ExpirePipelineCacheService into Worker so it can fetch all the merge requests for which the pipeline runs or did run against.
* | | | | | | | | | | Merge branch 'fix/gb/fix-blocked-pipeline-duration' into 'master' Kamil Trzciński2017-04-241-20/+45
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix missing duration for blocked pipelines Closes #31264 See merge request !10856
| * | | | | | | | | | | Improve helpers in pipeline model specsGrzegorz Bizon2017-04-211-3/+3
| | | | | | | | | | | |
| * | | | | | | | | | | Fix missing pipeline duration for blocked pipelinesGrzegorz Bizon2017-04-211-19/+44
| | |_|_|_|_|_|_|/ / / | |/| | | | | | | | |
* | | | | | | | | | | Merge branch 'fix/gb/fix-incorrect-commit-status-badge-text' into 'master' Kamil Trzciński2017-04-243-18/+85
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix incorrect commit status text on main project page See merge request !10863
| * | | | | | | | | | | Add specs for new ci status helper methodGrzegorz Bizon2017-04-211-9/+38
| | | | | | | | | | | |
| * | | | | | | | | | | Fix lastest commit status text on main project pageGrzegorz Bizon2017-04-212-9/+47
| | | | | | | | | | | |
* | | | | | | | | | | | Merge branch 'rs-empty-project-features' into 'master' Rémy Coutable2017-04-2418-44/+56
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use `:empty_project` where possible in top-level feature specs See merge request !10836
| * | | | | | | | | | | | Use `:empty_project` where possible in top-level feature specsrs-empty-project-featuresRobert Speicher2017-04-2018-44/+56
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge branch 'dz-fix-spec-filenames-ce' into 'master' Sean McGivern2017-04-245-51/+46
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix incorrect spec filenames which were ingored by CI See merge request !10875
| * | | | | | | | | | | | | Fix outdated specs that were not executed due to wrong filenameDmitriy Zaporozhets2017-04-242-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | | | | | | | | | Fix incorrect spec filenames which were ingored by CIdz-fix-spec-filenames-ceDmitriy Zaporozhets2017-04-245-47/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | | | | | | | | | | | Merge branch '29335-fix-request-access-button-visibility' into 'master' Douwe Maan2017-04-241-0/+11
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added test to prevent ‘Request access’ regression See merge request !10866
| * | | | | | | | | | | | | | Added test to prevent ‘Request access’ regression29335-fix-request-access-button-visibilityJames Edwards-Jones2017-04-221-0/+11
| | |_|/ / / / / / / / / / / | |/| | | | | | | | | | | |
* | | | | | | | | | | | | | Merge branch 'mrchrisw-22740-merge-api' into 'master' Sean McGivern2017-04-241-1/+13
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix updating merge_when_build_succeeds via merge API endpoint Closes #22740 See merge request !10873
| * | | | | | | | | | | | | | Fix updating merge_when_build_succeeds via merge API endpointmrchrisw-22740-merge-apiChris Wilson2017-04-241-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When updating a merge request via the `/merge` endpoint we check the `mergeable` and `mergeable_state` status, these will return `false` if the application option only_allow_merge_if_pipeline_succeeds is enabled. We should skip CI checks if the request uses the merge_when_pipeline_succeeds param Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/22740
* | | | | | | | | | | | | | | Merge branch 'rs-rename-login_as' into 'master' Rémy Coutable2017-04-242-5/+4
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Except where necessary, use `sign_in` over `login_as` in features See merge request !10320
| * | | | | | | | | | | | | | Return early from `finished_all_ajax_requests?` when jQuery is undefinedrs-rename-login_asRobert Speicher2017-04-191-0/+1
| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Simplify the `javascript_test?` helperRobert Speicher2017-04-191-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also don't try to run `page.evaluate_script` when we're not in a JavaScript test.