summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Fix rubucop offensesbitbucket-oauth2Douglas Barbosa Alexandre2016-12-161-1/+0
|
* BB importer: Milestone importerValery Sizov2016-12-161-0/+6
|
* Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into bitbucket-oauth2Valery Sizov2016-12-1436-100/+859
|\
| * Merge branch '24927-custom-event-polyfill-test' into 'master' Alfredo Sumaran2016-12-141-0/+43
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds tests for Custom Event polyfill ## What does this MR do? Adds tests for CustomEvent polyfill. ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #24927 See merge request !7996
| | * Fix broken test in chrome24927-custom-event-polyfill-testFilipa Lacerda2016-12-131-3/+3
| | |
| | * Fix broken testFilipa Lacerda2016-12-091-3/+3
| | |
| | * Adds tests for Custom Event polyfillFilipa Lacerda2016-12-081-0/+43
| | | | | | | | | | | | Update changelog with MR ID
| * | Merge branch 'master' into 'dz-remove-namespaces-path-uniq'Dmitriy Zaporozhets2016-12-1464-268/+1625
| |\ \ | | | | | | | | | | | | | | | | | | | | Merge Request - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8013 # Conflicts: # db/schema.rb
| | * \ Merge branch 'dz-fix-admin-routes' into 'master' Sean McGivern2016-12-144-6/+18
| | |\ \ | | | | | | | | | | | | | | | | | | | | Add support for nested groups to admin routing See merge request !8008
| | | * | Add support for nested groups to admin routingdz-fix-admin-routesDmitriy Zaporozhets2016-12-114-6/+18
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | Merge branch 'build-statuses' into 'master' Rémy Coutable2016-12-1428-86/+795
| | |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Detailed build statuses ## What does this MR do? Implements detailed statuses for `Ci::Builds` and `CommitStatus`. It also adds a new icon for manual build. ## Screenshots ![manual_builds_icon](/uploads/22b5c594350856c85398ef705a635f8b/manual_builds_icon.png) ## What are the relevant issue numbers? See #24273, closes #22642 See merge request !7989
| | | * | | Improve build status specs contexts descriptionsGrzegorz Bizon2016-12-144-4/+4
| | | | | |
| | | * | | Add some missing tests for detailed status methodsbuild-statusesGrzegorz Bizon2016-12-143-2/+32
| | | | | |
| | | * | | Make it possible to mix `Gitlab::Routing` inGrzegorz Bizon2016-12-131-0/+23
| | | | | |
| | | * | | Extract abilities checking module from ability modelGrzegorz Bizon2016-12-131-0/+27
| | | | | |
| | | * | | Extend tests for pipeline detailed status helpersGrzegorz Bizon2016-12-131-12/+18
| | | | | |
| | | * | | Add tests for common build detailed status helpersGrzegorz Bizon2016-12-131-0/+37
| | | | | |
| | | * | | Add missing tests for build `cancelable?` methodGrzegorz Bizon2016-12-131-0/+36
| | | | | |
| | | * | | Add tests for detailed build statuses factoryGrzegorz Bizon2016-12-131-0/+141
| | | | | |
| | | * | | Make it possible to retry build that was canceledGrzegorz Bizon2016-12-131-0/+8
| | | | | |
| | | * | | Make build retryable only if complete and executedGrzegorz Bizon2016-12-131-8/+30
| | | | | |
| | | * | | Add tests for build cancelable/retryable statusesGrzegorz Bizon2016-12-132-0/+172
| | | | | |
| | | * | | Extend specs for build play/stop detailed statusesGrzegorz Bizon2016-12-132-7/+55
| | | | | |
| | | * | | Refine build stop/play extended status specsGrzegorz Bizon2016-12-132-31/+31
| | | | | |
| | | * | | Fix detailed status specs for pipeline stage modelGrzegorz Bizon2016-12-121-1/+3
| | | | | |
| | | * | | Fix pipeline specs for detailed statusesGrzegorz Bizon2016-12-121-8/+12
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
| | | * | | Add specs for build stop extended detailed statusGrzegorz Bizon2016-12-121-0/+59
| | | | | |
| | | * | | Add tests for build play extended detailed statusGrzegorz Bizon2016-12-122-3/+69
| | | | | |
| | | * | | Fix some detailed statuses specs related to abilitiesGrzegorz Bizon2016-12-127-17/+41
| | | | | |
| | | * | | Fix tests related to detailed statuses and permissionsGrzegorz Bizon2016-12-1214-41/+45
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
| | * | | | Merge branch '25651-fix-master' into 'master' Rémy Coutable2016-12-141-1/+1
| | |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix wrong error message expectation in API::Commits spec See commit message or https://gitlab.com/gitlab-org/gitlab-ce/issues/25651#note_19996076 for the explanation. Closes #25651 See merge request !8083
| | | * | | | Fix wrong error message expectation in API::Commits spec25651-fix-masterRémy Coutable2016-12-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was because the MR was a bit behind master and the error message got updated in the meantime by 79aad815. Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | | Modify namespace name and path validationdz-remove-namespaces-path-uniqDmitriy Zaporozhets2016-12-122-7/+2
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently namespace name and path have uniq validaiton which does not allow us to use same group name/path inside different groups. This commit changes validation in next way: * Allow same namespace name with different parent_id * Allow same namespace path. Uniq validation should be handled by routes table Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | | | BB importer: fix specsValery Sizov2016-12-146-12/+15
| | | | | |
* | | | | | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into bitbucket-oauth2Valery Sizov2016-12-14233-1747/+6220
|\ \ \ \ \ \ | | |/ / / / | |/| | | |
| * | | | | Merge branch 'process-commit-worker-migration-encoding' into 'master' Rémy Coutable2016-12-141-2/+25
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Encode when migrating ProcessCommitWorker jobs ## What does this MR do? This adds encoding logic to the migration for ProcessCommitWorker, ensuring it doesn't throw errors when the input can not be converted to UTF-8 without extra help. ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/25489 See merge request !8064
| | * | | | | Encode when migrating ProcessCommitWorker jobsprocess-commit-worker-migration-encodingYorick Peterse2016-12-131-2/+25
| | | |_|/ / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the source encoding is not UTF-8 we need to encode the data as `JSON.dump` may throw an error if the input can not be converted to UTF-8. We only encode when necessary to reduce the overhead. Fixes gitlab-org/gitlab-ce#25489
| * | | | | Merge branch '25136-last-deployment-link' into 'master' Grzegorz Bizon2016-12-141-0/+37
| |\ \ \ \ \ | | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix broken link for latest deployment ## What does this MR do? Creates a new helper for the latest deployment link. ## Why was this MR needed? A helper that returns a link was being called inside another helper that creates a link, resulting in `builds/<a href="builds/ID>#id</a>` ## What are the relevant issue numbers? Closes #25136 See merge request !7839
| | * | | | Changes after review25136-last-deployment-linkFilipa Lacerda2016-12-071-17/+14
| | | | | |
| | * | | | Changes after reviewFilipa Lacerda2016-12-071-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | Fix error
| | * | | | Updates testsFilipa Lacerda2016-12-071-12/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix tests Fix rubocop error Fix broken test
| | * | | | Fix broken link for latest deploymentFilipa Lacerda2016-12-071-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | Updates changelog with MR ID
| * | | | | Merge branch 'api-cherry-pick' into 'master' Rémy Coutable2016-12-131-0/+70
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds the ability to cherry pick a commit via the API. Right now it only supports to directly cherry pick a commit and not starting a MR from it. Shall we do that also for the API? Closes #25450 See merge request !8047
| | * | | | | Make rubocop happyapi-cherry-pickRobert Schilling2016-12-131-1/+1
| | | | | | |
| | * | | | | API: Ability to cherry-pick a commitRobert Schilling2016-12-131-0/+70
| | | |/ / / | | |/| | |
| * | | | | Merge branch 'jzinn/gitlab-ce-chomp-git-status-message' into 'master' Rémy Coutable2016-12-131-1/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For single line Git commit messages, the close quote should be on the same line as the open quote _Originally opened at !7299 by @jzinn._ - - - ## What does this MR do? Chomps merge commit messages so that there is not a dangling close quote. A better solution would be not to use quotes at all, but to set off the message in a `<div>` with a background color. ## Screenshots (if relevant) ![Screen_Shot_2016-11-04_at_8.06.54_PM](/uploads/6e749c5227d88a9bfea64e70cccaf14a/Screen_Shot_2016-11-04_at_8.06.54_PM.png) See merge request !7975
| | * | | | | For single line git commit messages, the close quote should be on the same ↵jzinn/gitlab-ce-chomp-git-status-messageJulian Zinn2016-12-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | line as the open quote Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | | Merge branch '25482-fix-api-sudo' into 'master' Sean McGivern2016-12-133-55/+68
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | API: Memoize the current_user so that the sudo can work properly Closes #25482 See merge request !8017
| | * | | | | | Be smarter when finding a sudoed user in API::Helpers25482-fix-api-sudoRémy Coutable2016-12-132-13/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| | * | | | | | API: Memoize the current_user so that the sudo can work properlyRémy Coutable2016-12-122-42/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The issue was arising when `#current_user` was called a second time after a user was impersonated: the `User#is_admin?` check would be performed on it and it would fail. Signed-off-by: Rémy Coutable <remy@rymai.me>