| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
added a QueryRecorder for IssuesController#index.json
|
| |\
| |
| |
| |
| |
| |
| | |
Migrate Git::CommitStats to Gitaly
Closes gitaly#519
See merge request !14077
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
Detect orphaned repositories
See merge request !14204
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Allow to use same periods for housekeeping tasks
Closes #34981
See merge request !13711
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This enables skipping a lesser housekeeping task
(incremental or full repack) by consistently
scheduling a higher task (respectively full repack or gc)
with the same period.
Cf. #34981
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Replace the 'project/issues/award_emoji.feature' spinach test with an rspec analog
See merge request !14202
|
| | | | | |
| | | | |
| | | | |
| | | | | |
analog
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Replace the 'project/builds/summary.feature' spinach test with an rspec analog
See merge request !14177
|
| | |/ / / / |
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
Hide read_registry scope when registry is disabled on instance
See merge request !13314
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
spec/features/projects/wiki/user_updates_wiki_page_spec.rb
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Replace the 'project/merge_requests/revert.feature' spinach test with an rspec analog
See merge request !14201
|
| | | |_|/ /
| |/| | |
| | | | |
| | | | | |
rspec analog
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
Replace the 'project/milestone.feature' spinach test with an rspec analog
See merge request !14171
|
| | | | | | |
|
| |\ \ \ \ \
| |_|_|_|/
|/| | | |
| | | | |
| | | | | |
Reset all connection schema cache after migration tests
See merge request !14195
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We might also want to consider reduce the number of
connections in the tests. However I just tried setting it to 1
and that doesn't seem enough for feature tests.
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
Replace the 'project/merge_requests/accept.feature' spinach test with an rspec analog
See merge request !14176
|
| | |/ / /
| | | |
| | | |
| | | | |
rspec analog
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Replace 'project/wiki.feature' spinach test with an rspec analog
See merge request !13856
|
| | |/ / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Replace 'project/group_links.feature' spinach test with an rspec analog
See merge request !14169
|
| | |/ / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Replace the 'profile/emails.feature' spinach test with an rspec analog
See merge request !14172
|
| | |/ / / |
|
| |\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | | |
Replace the 'project/team_management.feature' spinach test with an rspec analog
See merge request !14173
|
| | |/ / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Rework how recent push events are retrieved
Closes #35990
See merge request !13995
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Whenever you push to a branch GitLab will show a button to create a
merge request (should one not exist already). The underlying code to
display this data was quite inefficient. For example, it involved
multiple slow queries just to figure out what the most recent push event
was.
This commit changes the way this data is retrieved so it's much faster.
This is achieved by caching the ID of the last push event on every push,
which is then retrieved when loading certain pages. Database queries are
only executed if necessary and the cached data is removed automatically
once a merge request has been created, or 2 hours after being stored.
A trade-off of this approach is that we _only_ track the last event.
Previously if you were to push to branch A and B then create a merge
request for branch B we'd still show the widget for branch A. As of this
commit this is no longer the case, instead we will only show the widget
for the branch you pushed to most recently. Once a merge request exists
the widget is no longer displayed. Alternative solutions are either too
complex and/or too slow, hence the decision was made to settle for this
trade-off.
Performance Impact
------------------
In the best case scenario (= a user didn't push anything for more than 2
hours) we perform a single Redis GET per page. Should there be cached
data we will run a single (and lightweight) SQL query to get the
event data from the database. If a merge request already exists we will
run an additional DEL to remove the cache key.
The difference in response timings can vary a bit per project. On
GitLab.com the 99th percentile of time spent in User#recent_push hovers
between 100 milliseconds and 1 second, while the mean hovers around 50
milliseconds. With the changes in this MR the expected time spent in
User#recent_push is expected to be reduced down to just a few
milliseconds.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/35990
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Remove confidential toggle checkbox while editing issue inline
Closes #37454
See merge request !14142
|
| | | |/ /
| |/| | |
|
| |/ / / |
|
| | | |
| | |
| | |
| | |
| | | |
'35012-navigation-add-option-to-change-navigation-color-palette' into 'master'"
This reverts merge request !13619
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Move issues index variable setting to a method
See merge request !14048
|
| | |\ \ \ |
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'37569-fix-wrong-number-of-arguments-in-tree_helper-flatten_tree' into 'master'
Fix a "Wrong number of arguments" error in TreeHelper#flatten_tree
Closes #37569
See merge request !14119
|
| | |/ / / /
| | | | |
| | | | |
| | | | | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Supports additional colors and labels for the prometheus monitoring dashboard
Closes #34629
See merge request !14065
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[9.5] Disallow the `name` attribute on all user-provided markup
See merge request gitlab/gitlabhq!2166
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[9.5] Limit `style` attribute on `th` and `td` elements to specific properties
See merge request gitlab/gitlabhq!2155
|
