Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix Error 500 when inviting user already present | Stan Hu | 2019-05-10 | 1 | -1/+12 |
| | | | | | | | A project admin attempting to invite an already-invited user will see a confusing Error 500 message. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61574 | ||||
* | Add frozen_string_literal to spec/servicesfrozen_string_literal_spec_services | Thong Kuah | 2019-04-12 | 5 | -0/+10 |
| | | | | Probably useful as we often move these files to "new" files. | ||||
* | [CE] Support multiple assignees for merge requestsosw-multi-assignees-merge-requests | Oswaldo Ferreira | 2019-04-08 | 1 | -2/+2 |
| | | | | | Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161 (code out of ee/ folder). | ||||
* | Update members service to cope with errors | James Lopez | 2019-02-01 | 1 | -0/+9 |
| | |||||
* | Fix rubocop violations | Gabriel Mazetto | 2019-01-31 | 1 | -1/+1 |
| | |||||
* | Add subresources removal to member destroy service | James Lopez | 2019-01-31 | 1 | -4/+56 |
| | |||||
* | Delete confidential issue todos for guests | Felipe Artur | 2018-12-14 | 2 | -1/+18 |
| | | | | | Fix leaking information of confidential issues on TODOs when user is downgraded to guest access. | ||||
* | Delete todos when users loses target read permissions | Jarka Kadlecová | 2018-07-30 | 1 | -0/+5 |
| | |||||
* | Resolve "Rename the `Master` role to `Maintainer`" Backend | Mark Chao | 2018-07-11 | 4 | -10/+10 |
| | |||||
* | Updates from `rubocop -a` | Lin Jen-Shin | 2018-07-09 | 1 | -2/+2 |
| | |||||
* | Don't delete todos or unassign issues and MRs when a user leaves a projectunassign-when-leaving | Douwe Maan | 2018-03-07 | 1 | -36/+60 |
| | |||||
* | Improve Member servicesrc/reduce-delta-with-ce-in-controllers-ce | Rémy Coutable | 2018-02-27 | 6 | -168/+132 |
| | | | | Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | Remove explicit audit event log in MembershipActions | Rémy Coutable | 2018-02-27 | 4 | -103/+144 |
| | | | | | | | | | Move it to Members::ApproveAccessRequestService. Also, note that there was a double audit event log for access request destruction. Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | Resolve "Remove notification settings for groups and projects you were ↵ | 🙈 jacopo beschi 🙉 | 2018-02-14 | 1 | -6/+50 |
| | | | | previously a member of" | ||||
* | Replace '.team << [user, role]' with 'add_role(user)' in specs36782-replace-team-user-role-with-add_role-user-in-specs | blackst0ne | 2017-12-22 | 4 | -6/+6 |
| | |||||
* | Fix specs after removing assignee_id field | Valery Sizov | 2017-12-11 | 1 | -1/+1 |
| | |||||
* | Change all `:empty_project` to `:project`rs-empty_project-default | Robert Speicher | 2017-08-02 | 5 | -8/+8 |
| | |||||
* | Remove superfluous lib: true, type: redis, service: true, models: true, ↵ | Rémy Coutable | 2017-07-27 | 5 | -5/+5 |
| | | | | | | services: true, no_db: true, api: true Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | Enable Style/DotPosition Rubocop :cop: | Grzegorz Bizon | 2017-06-21 | 1 | -2/+2 |
| | |||||
* | Correct RSpec/SingleLineHook cop offenses | Robert Speicher | 2017-06-14 | 1 | -1/+3 |
| | |||||
* | Limit non-administrators to adding 100 members at a time to groups and projects | Nick Thomas | 2017-06-06 | 1 | -2/+14 |
| | |||||
* | Fix spec for Members::AuthorizedDestroyServicefix-authorized-members-destroy | Yorick Peterse | 2017-05-30 | 1 | -1/+1 |
| | | | | | This spec was still assuming that creating a project would not result in the owner having access to the project. | ||||
* | Fix: Deleting an invited member causes 500 error | Valery Sizov | 2017-05-18 | 1 | -0/+21 |
| | |||||
* | Fix specs | Clement Ho | 2017-05-04 | 1 | -3/+3 |
| | |||||
* | Remove helpers assigned_issuables_count and cached_assigned_issuables_countuassign_on_member_removing | Valery Sizov | 2017-04-20 | 1 | -4/+4 |
| | |||||
* | Remove assigned_(issues|merge_requests) methods from the issuable | Valery Sizov | 2017-04-18 | 1 | -2/+1 |
| | |||||
* | Unassign all Issues and Merge Requests when member leaves team | Valery Sizov | 2017-04-18 | 1 | -0/+46 |
| | |||||
* | Use `:empty_project` where possible in service specs | Robert Speicher | 2017-03-27 | 2 | -4/+4 |
| | |||||
* | Make access request specs explicitly enable or disable access requests as ↵ | Nick Thomas | 2016-11-11 | 3 | -19/+17 |
| | | | | required | ||||
* | Implement CreateMembers service to make controller thinrefactor_group_members | Valery Sizov | 2016-11-01 | 1 | -0/+25 |
| | |||||
* | Allow Members::ApproveAccessRequestService to accept a new :force paramee-1159-allow-permission-check-bypass-in-approve-access-request-service | Rémy Coutable | 2016-10-28 | 1 | -6/+57 |
| | | | | | | | | | | | This param allows to bypass permission check. It is useful for LDAP-sync where even owners don't have the :admin_group_member permission. See https://gitlab.com/gitlab-org/gitlab-ee/blob/6081c37123abae4570f78831b33c2f45f92c2765/app/policies/group_policy.rb#L38 and https://gitlab.com/gitlab-org/gitlab-ee/issues/1159 Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | Merge branch 'rc-improve-members-destroy-service' into 'master' | Robert Speicher | 2016-10-04 | 1 | -37/+78 |
|\ | | | | | | | | | | | | | Improve `Members::DestroyService` Part of #21979. See merge request !6267 | ||||
| * | Fix a few things after the initial improvment to Members::DestroyService | Rémy Coutable | 2016-10-03 | 1 | -0/+9 |
| | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
| * | Improve Members::DestroyService | Rémy Coutable | 2016-10-03 | 1 | -40/+72 |
| | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | | Enable Lint/StringConversionInInterpolation cop and autocorrect offensesrs-string-conversion-in-interpolation | Robert Speicher | 2016-10-03 | 2 | -2/+2 |
|/ | |||||
* | Merge branch 'rc-new-members-request-access-service' into 'master' | Robert Speicher | 2016-10-02 | 1 | -0/+57 |
|\ | | | | | | | | | | | | | New `Members::RequestAccessService` Part of #21979. See merge request !6265 | ||||
| * | New Members::RequestAccessService | Rémy Coutable | 2016-09-22 | 1 | -0/+57 |
| | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | | Ensure Members::ApproveAccessRequestService can fin a requester by ID | Rémy Coutable | 2016-09-22 | 1 | -0/+8 |
| | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | | New Members::ApproveAccessRequestService | Rémy Coutable | 2016-09-22 | 1 | -0/+88 |
|/ | | | | Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | Raise a new Gitlab::Access::AccessDeniedError when permission is not enough ↵ | Rémy Coutable | 2016-06-18 | 1 | -2/+22 |
| | | | | | | | | to destroy a member This is a try for a new approach to put the access checks at the service level. Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | Don't send the "access declined" email on access request withdrawal | Rémy Coutable | 2016-06-18 | 1 | -0/+8 |
| | | | | Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | New Members::DestroyService | Rémy Coutable | 2016-06-18 | 1 | -0/+43 |
This is to ensure we don't send unwanted notifications when deleting a project. In other words, stop abusing AR callbacks and use services. Signed-off-by: Rémy Coutable <remy@rymai.me> |