summaryrefslogtreecommitdiff
path: root/spec/services/members
Commit message (Collapse)AuthorAgeFilesLines
* Fix Error 500 when inviting user already presentStan Hu2019-05-101-1/+12
| | | | | | | A project admin attempting to invite an already-invited user will see a confusing Error 500 message. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61574
* Add frozen_string_literal to spec/servicesfrozen_string_literal_spec_servicesThong Kuah2019-04-125-0/+10
| | | | Probably useful as we often move these files to "new" files.
* [CE] Support multiple assignees for merge requestsosw-multi-assignees-merge-requestsOswaldo Ferreira2019-04-081-2/+2
| | | | | Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161 (code out of ee/ folder).
* Update members service to cope with errorsJames Lopez2019-02-011-0/+9
|
* Fix rubocop violationsGabriel Mazetto2019-01-311-1/+1
|
* Add subresources removal to member destroy serviceJames Lopez2019-01-311-4/+56
|
* Delete confidential issue todos for guestsFelipe Artur2018-12-142-1/+18
| | | | | Fix leaking information of confidential issues on TODOs when user is downgraded to guest access.
* Delete todos when users loses target read permissionsJarka Kadlecová2018-07-301-0/+5
|
* Resolve "Rename the `Master` role to `Maintainer`" BackendMark Chao2018-07-114-10/+10
|
* Updates from `rubocop -a`Lin Jen-Shin2018-07-091-2/+2
|
* Don't delete todos or unassign issues and MRs when a user leaves a projectunassign-when-leavingDouwe Maan2018-03-071-36/+60
|
* Improve Member servicesrc/reduce-delta-with-ce-in-controllers-ceRémy Coutable2018-02-276-168/+132
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Remove explicit audit event log in MembershipActionsRémy Coutable2018-02-274-103/+144
| | | | | | | | | Move it to Members::ApproveAccessRequestService. Also, note that there was a double audit event log for access request destruction. Signed-off-by: Rémy Coutable <remy@rymai.me>
* Resolve "Remove notification settings for groups and projects you were ↵🙈 jacopo beschi 🙉2018-02-141-6/+50
| | | | previously a member of"
* Replace '.team << [user, role]' with 'add_role(user)' in specs36782-replace-team-user-role-with-add_role-user-in-specsblackst0ne2017-12-224-6/+6
|
* Fix specs after removing assignee_id fieldValery Sizov2017-12-111-1/+1
|
* Change all `:empty_project` to `:project`rs-empty_project-defaultRobert Speicher2017-08-025-8/+8
|
* Remove superfluous lib: true, type: redis, service: true, models: true, ↵Rémy Coutable2017-07-275-5/+5
| | | | | | services: true, no_db: true, api: true Signed-off-by: Rémy Coutable <remy@rymai.me>
* Enable Style/DotPosition Rubocop :cop:Grzegorz Bizon2017-06-211-2/+2
|
* Correct RSpec/SingleLineHook cop offensesRobert Speicher2017-06-141-1/+3
|
* Limit non-administrators to adding 100 members at a time to groups and projectsNick Thomas2017-06-061-2/+14
|
* Fix spec for Members::AuthorizedDestroyServicefix-authorized-members-destroyYorick Peterse2017-05-301-1/+1
| | | | | This spec was still assuming that creating a project would not result in the owner having access to the project.
* Fix: Deleting an invited member causes 500 errorValery Sizov2017-05-181-0/+21
|
* Fix specsClement Ho2017-05-041-3/+3
|
* Remove helpers assigned_issuables_count and cached_assigned_issuables_countuassign_on_member_removingValery Sizov2017-04-201-4/+4
|
* Remove assigned_(issues|merge_requests) methods from the issuableValery Sizov2017-04-181-2/+1
|
* Unassign all Issues and Merge Requests when member leaves teamValery Sizov2017-04-181-0/+46
|
* Use `:empty_project` where possible in service specsRobert Speicher2017-03-272-4/+4
|
* Make access request specs explicitly enable or disable access requests as ↵Nick Thomas2016-11-113-19/+17
| | | | required
* Implement CreateMembers service to make controller thinrefactor_group_membersValery Sizov2016-11-011-0/+25
|
* Allow Members::ApproveAccessRequestService to accept a new :force paramee-1159-allow-permission-check-bypass-in-approve-access-request-serviceRémy Coutable2016-10-281-6/+57
| | | | | | | | | | | This param allows to bypass permission check. It is useful for LDAP-sync where even owners don't have the :admin_group_member permission. See https://gitlab.com/gitlab-org/gitlab-ee/blob/6081c37123abae4570f78831b33c2f45f92c2765/app/policies/group_policy.rb#L38 and https://gitlab.com/gitlab-org/gitlab-ee/issues/1159 Signed-off-by: Rémy Coutable <remy@rymai.me>
* Merge branch 'rc-improve-members-destroy-service' into 'master' Robert Speicher2016-10-041-37/+78
|\ | | | | | | | | | | | | Improve `Members::DestroyService` Part of #21979. See merge request !6267
| * Fix a few things after the initial improvment to Members::DestroyServiceRémy Coutable2016-10-031-0/+9
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * Improve Members::DestroyServiceRémy Coutable2016-10-031-40/+72
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Enable Lint/StringConversionInInterpolation cop and autocorrect offensesrs-string-conversion-in-interpolationRobert Speicher2016-10-032-2/+2
|/
* Merge branch 'rc-new-members-request-access-service' into 'master' Robert Speicher2016-10-021-0/+57
|\ | | | | | | | | | | | | New `Members::RequestAccessService` Part of #21979. See merge request !6265
| * New Members::RequestAccessServiceRémy Coutable2016-09-221-0/+57
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Ensure Members::ApproveAccessRequestService can fin a requester by IDRémy Coutable2016-09-221-0/+8
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | New Members::ApproveAccessRequestServiceRémy Coutable2016-09-221-0/+88
|/ | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Raise a new Gitlab::Access::AccessDeniedError when permission is not enough ↵Rémy Coutable2016-06-181-2/+22
| | | | | | | | to destroy a member This is a try for a new approach to put the access checks at the service level. Signed-off-by: Rémy Coutable <remy@rymai.me>
* Don't send the "access declined" email on access request withdrawalRémy Coutable2016-06-181-0/+8
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* New Members::DestroyServiceRémy Coutable2016-06-181-0/+43
This is to ensure we don't send unwanted notifications when deleting a project. In other words, stop abusing AR callbacks and use services. Signed-off-by: Rémy Coutable <remy@rymai.me>