| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
Closes gitaly#915
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Uses `list_commits_by_oid` on the CommitService, to request the needed
commits for pipelines. These commits are needed to display the user that
created the commit and the commit title.
This includes fixes for tests failing that depended on the commit
being `nil`. However, now these are batch loaded, this doesn't happen
anymore and the commits are an instance of BatchLoader.
|
|
|
|
|
| |
This adds an optimised way of getting the latest pipeline status for a
list of Commit objects (or just a single one).
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Also improved the UT for better documenting this change.
|
| |
|
|
|
|
|
| |
The list of commits must be generated from the merge request,
not from a diff of the branches.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
services: true, no_db: true, api: true
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
|
|
|
| |
We also try to use instance variable to cache the result if
RequestStore is not available, so we could keep the same logic,
using the same cache key. Also introduce a way to specify method
specific cache key
|
| |
|
|
|
|
| |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
| |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|\
| |
| |
| |
| |
| |
| | |
Fix long urls in the title of commit
Closes #12614
See merge request !10938
|
| | |
|
| |
| |
| |
| | |
Closes gitaly#199
|
| | |
|
| | |
|
|/
|
|
|
|
|
|
| |
As it might be confusing that it's not the same as
Pipeline#latest
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11038#note_28677090
|
| |
|
|\
| |
| |
| |
| | |
Use Gitaly for CommitController#show
See merge request !9629
|
| | |
|
|/ |
|
| |
|
|
|
|
| |
Was proposed in #24833
|
| |
|
|
|
|
|
|
|
|
| |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20058993
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20059060
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20059357
|
|
|
|
|
|
|
|
|
|
| |
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20059124
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20059187
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20059322
|
|
|
|
|
| |
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20003268
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
show-commit-status-from-latest-pipeline
* upstream/master: (557 commits)
Fix wrong error message expectation in API::Commits spec
Move admin settings spinach feature to rspec
Encode when migrating ProcessCommitWorker jobs
Prevent overflow with vertical scroll when we have space to show content
Make rubocop happy
API: Ability to cherry-pick a commit
Be smarter when finding a sudoed user in API::Helpers
Backport hooks on group policies for the EE-specific implementation
API: Ability to get group's project in simple representation
Add AddLowerPathIndexToRoutes to setup_postgresql.rake
For single line git commit messages, the close quote should be on the same line as the open quote
added border-radius and padding to labels
Allow all alphanumeric characters in file names (!8002)
Add failing test for #20190
Don't allow blank MR titles in API
Replace static fixture for awards_handler_spec (!7661)
Crontab typo '* */6' -> '0 */6' (4x/day not 1x-per-min-for-1h 4x/day)
Fix test
Tweak style and add back wording
Clean up commit copy to clipboard and make consistent
...
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Replace MR access checks with use of MergeRequestsFinder
Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867
:warning: - Potentially untested
:bomb: - No test coverage
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)
:white_check_mark: - Permissions check tested
- [x] :bomb: app/finders/notes_finder.rb:17
- [x] :warning: app/views/layouts/nav/_project.html.haml:80 [`.count`]
- [x] :bomb: app/controllers/concerns/creates_commit.rb:84
- [x] :traffic_light: app/controllers/projects/commits_controller.rb:24
- [x] :traffic_light: app/controllers/projects/compare_controller.rb:56
- [x] :vertical_traffic_light: app/controllers/projects/discussions_controller.rb:29
- [x] :white_check_mark: app/controllers/projects/todos_controller.rb:27
- [x] :vertical_traffic_light: app/models/commit.rb:268
- [x] :white_check_mark: lib/gitlab/search_results.rb:71
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)`
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`.
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?`
See merge request !2033
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
By passing commit data to this worker we remove the need for querying
the Git repository for every job. This in turn reduces the time spent
processing each job.
The migration included migrates jobs from the old format to the new
format. For this to work properly it requires downtime as otherwise
workers may start producing errors until they're using a newer version
of the worker code.
|
| |
| |
| |
| | |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_18860042
|
| |
| |
| |
| |
| | |
feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_18819886
|
| |
| |
| |
| |
| |
| | |
ref and sha so that it would show latest pipeline
if ref and sha are both specified, otherwise still
the same as before.
|
|/
|
|
|
|
| |
Rather than compound status from all pipelines.
Closes #20560
|
| |
|
|
|
|
| |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7034#note_17742297
|