summaryrefslogtreecommitdiff
path: root/spec/models/commit_spec.rb
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security'Douwe Maan2016-12-081-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace MR access checks with use of MergeRequestsFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 :warning: - Potentially untested :bomb: - No test coverage :traffic_light: - Test coverage of some sort exists (a test failed when error raised) :vertical_traffic_light: - Test coverage of return value (a test failed when nil used) :white_check_mark: - Permissions check tested - [x] :bomb: app/finders/notes_finder.rb:17 - [x] :warning: app/views/layouts/nav/_project.html.haml:80 [`.count`] - [x] :bomb: app/controllers/concerns/creates_commit.rb:84 - [x] :traffic_light: app/controllers/projects/commits_controller.rb:24 - [x] :traffic_light: app/controllers/projects/compare_controller.rb:56 - [x] :vertical_traffic_light: app/controllers/projects/discussions_controller.rb:29 - [x] :white_check_mark: app/controllers/projects/todos_controller.rb:27 - [x] :vertical_traffic_light: app/models/commit.rb:268 - [x] :white_check_mark: lib/gitlab/search_results.rb:71 - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)` - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`. - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?` See merge request !2033
* Add shorthand support to gitlab markdown referencesOswaldo Ferreira2016-12-021-4/+10
|
* Pass commit data to ProcessCommitWorkerprocess-commit-worker-improvementsYorick Peterse2016-12-011-0/+17
| | | | | | | | | | | By passing commit data to this worker we remove the need for querying the Git repository for every job. This in turn reduces the time spent processing each job. The migration included migrates jobs from the old format to the new format. For this to work properly it requires downtime as otherwise workers may start producing errors until they're using a newer version of the worker code.
* There's no such methodLin Jen-Shin2016-11-041-4/+0
|
* Merge status_for and status, feedback:Lin Jen-Shin2016-11-031-34/+36
| | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7034#note_17742297
* Add tests for Commit#status and Commit#status_for, feedback:Lin Jen-Shin2016-10-281-1/+44
| | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7034#note_17543036
* refactors tests because of gitlab-test repository changes20708-new-branch-is-immediatelly-tagged-as-mergedtiagonbotelho2016-10-111-4/+4
|
* Expand commit message width in repo viewClement Ho2016-08-021-0/+21
|
* Add specs for caching commit authorStan Hu2016-07-271-0/+20
|
* Ensure relative paths for video are rewritten as we do for images20189-markdown-video-doesn-t-work-when-the-referenced-video-file-is-in-same-repoRémy Coutable2016-07-261-0/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Optimize Banzai::Filter::RelativeLinkFilterAlejandro Rodríguez2016-06-211-0/+12
| | | | | | | | | | | | A lot of git operations were being repeated, for example, to build a url you would ask if the path was a Tree, which would call a recursive routine in Gitlab::Git::Tree#where, then ask if the path was a Blob, which would call a recursive routine at Gitlab::Git::Blob#find, making reference to the same git objects several times. Now we call Rugged::Tree#path, which allows us to determine the type of the path in one pass. Some other minor improvement added, like saving commonly used references instead of calculating them each time.
* Refactor ParticipableYorick Peterse2016-06-011-1/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are several changes to this module: 1. The use of an explicit stack in Participable#participants 2. Proc behaviour has been changed 3. Batch permissions checking == Explicit Stack Participable#participants no longer uses recursion to process "self" and all child objects, instead it uses an Array and processes objects in breadth-first order. This allows us to for example create a single Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using a ReferenceExtractor removes the need for running potentially many SQL queries every time a Proc is called on a new object. == Proc Behaviour Changed Previously a Proc in Participable was expected to return an Array of User instances. This has been changed and instead it's now expected that a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return value of the Proc is ignored. == Permissions Checking The method Participable#participants uses Ability.users_that_can_read_project to check if the returned users have access to the project of "self" _without_ running multiple SQL queries for every user.
* Codestyle: make sure we have space around operatorsGabriel Mazetto2016-05-131-1/+1
|
* Rename CiStatus to StatusableKamil Trzcinski2016-04-161-0/+8
|
* Restrict access to references for confidential issuesDouglas Barbosa Alexandre2016-03-171-1/+12
|
* Ensure we don't check a commit's description for revert message if it has no ↵Rémy Coutable2016-02-221-0/+34
| | | | description
* Tag model specsDouwe Maan2015-12-091-1/+1
|
* Merge branch 'webhook_payload_with_changes' into 'master' Valery Sizov2015-12-071-0/+11
|\ | | | | | | | | | | | | Add added, modified and removed properties to commit object in webhook https://gitlab.com/gitlab-org/gitlab-ee/issues/20 See merge request !1988
| * fixes after reviewwebhook_payload_with_changesValery Sizov2015-12-071-1/+1
| |
| * fox specsValery Sizov2015-12-071-1/+1
| |
| * Add added, modified and removed properties to commit object in webhookValery Sizov2015-12-041-0/+11
| |
* | Render commit reference using short sha, but include full sha in comment.Douwe Maan2015-12-011-3/+14
| |
* | Fix specsDouwe Maan2015-11-301-10/+6
|/
* Fix mentionable specsDouwe Maan2015-10-121-2/+2
|
* Update mock and stub syntax for specsRobert Speicher2015-06-221-3/+5
|
* Add `to_reference` for models that support referencesRobert Speicher2015-05-261-2/+22
| | | | | Now there is a single source of information for which attribute a model uses to be referenced, and its special character.
* No longer needed to pass project argument to commit methods.Douwe Maan2015-04-241-2/+2
|
* Use project.commit convenience method.Douwe Maan2015-04-241-1/+1
|
* Update mentionable shared examples to be (a bit) more understandableRobert Speicher2015-04-161-1/+1
|
* Correct usage of `subject` in specsRobert Speicher2015-04-161-1/+2
|
* Don't use HTML ellipsis in EmailsOnPush subject truncated commit message.emailsonpush-hellipDouwe Maan2015-04-141-1/+1
|
* Updated rspec to rspec 3.x syntaxJeroen van Baarsen2015-02-121-21/+21
| | | | Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
* Allow commit messages to close several issues at once (thanks @123Haynesjubianchi2015-01-201-4/+0
| | | | for his work and help)
* Use 8chars short sha for commit in viewsDmitriy Zaporozhets2014-10-101-1/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Use short_id instead of [0..N] for short version of commit shaDmitriy Zaporozhets2014-10-101-1/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Make Mentionables work for cross-project refsVinnie Okada2014-10-031-1/+13
| | | | | Add a note to merge requests and issues when they're mentioned by a merge request, issue, or commit in another project.
* Fix commit specsDmitriy Zaporozhets2014-08-011-4/+7
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Make changes to testsDmitriy Zaporozhets2014-01-221-1/+1
| | | | | | | * project_with_code -> project * project -> ermpty_project Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Link issues from comments and automatically close themash wilson2013-08-251-1/+21
| | | | | | | | | | Any mention of Issues, MergeRequests, or Commits via GitLab-flavored markdown references in descriptions, titles, or attached Notes creates a back-reference Note that links to the original referencer. Furthermore, pushing commits with commit messages that match a (configurable) regexp to a project's default branch will close any issues mentioned by GFM in the matched closing phrase. If accepting a merge request would close any Issues in this way, a banner is appended to the merge request's main panel to indicate this.
* Allow project name, path etc start with number. Fixed specsDmitriy Zaporozhets2013-08-131-3/+3
|
* Merge Request on forked projectsIzaak Alpert2013-07-171-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The good: - You can do a merge request for a forked commit and it will merge properly (i.e. it does work). - Push events take into account merge requests on forked projects - Tests around merge_actions now present, spinach, and other rspec tests - Satellites now clean themselves up rather then recreate The questionable: - Events only know about target projects - Project's merge requests only hold on to MR's where they are the target - All operations performed in the satellite The bad: - Duplication between project's repositories and satellites (e.g. commits_between) (for reference: http://feedback.gitlab.com/forums/176466-general/suggestions/3456722-merge-requests-between-projects-repos) Fixes: Make test repos/satellites only create when needed -Spinach/Rspec now only initialize test directory, and setup stubs (things that are relatively cheap) -project_with_code, source_project_with_code, and target_project_with_code now create/destroy their repos individually -fixed remote removal -How to merge renders properly -Update emails to show project/branches -Edit MR doesn't set target branch -Fix some failures on editing/creating merge requests, added a test -Added back a test around merge request observer -Clean up project_transfer_spec, Remove duplicate enable/disable observers -Ensure satellite lock files are cleaned up, Attempted to add some testing around these as well -Signifant speed ups for tests -Update formatting ordering in notes_on_merge_requests -Remove wiki schema update Fixes for search/search results -Search results was using by_project for a list of projects, updated this to use in_projects -updated search results to reference the correct (target) project -udpated search results to print both sides of the merge request Change-Id: I19407990a0950945cc95d62089cbcc6262dab1a8
* Fixed API file raw functionality, Fixed tree controller tests. Added ↵Dmitriy Zaporozhets2013-04-031-2/+2
| | | | BlobController specs
* Dont init repo on every create(:repo)Dmitriy Zaporozhets2013-04-011-1/+1
|
* Project.repository should never be nil so you can call repository.exists? or ↵Dmitriy Zaporozhets2013-04-011-22/+19
| | | | | | repository.empty? Also specify separate project factory for project with filled repo
* Fix tests and remove app/models/repository.rbDmitriy Zaporozhets2013-03-311-45/+0
|
* Fixed protected branches and file editDmitriy Zaporozhets2013-01-041-1/+1
|
* Rspec models Milestone, Commit, UsersProjectDmitriy Zaporozhets2013-01-031-0/+61
|
* Cache the value of safe_messageRobert Speicher2012-10-021-0/+37
Also, just for extra paranoia, only call safe_message once in the decorator methods Adds specs to make sure it still works
View Lorry Controller Status