summaryrefslogtreecommitdiff
path: root/spec/lib
Commit message (Collapse)AuthorAgeFilesLines
* Add a feature flag for subdirectory archivesNick Thomas2019-04-161-25/+58
|
* JSON-encoded binary fields should use Base64::encode64Nick Thomas2019-04-161-1/+1
| | | | | | | It is not interoperable to use Base64::urlsafe_encode64 for fields in JSON that contain binary (as opposed to UTF8-safe) data. For instance, the Golang JSON decoder (which is what gitlab-workhorse uses) insists upon the standard base64 encoding.
* Revert "Revert "Merge branch '24704-download-repository-path' into 'master'""Nick Thomas2019-04-162-13/+29
| | | | This reverts commit 171818df0a72097aa1a804c8213666b3f66b0966.
* Merge branch 'gt-fix-styling-for-pages-status' into 'master'Filipa Lacerda2019-04-162-2/+2
|\ | | | | | | | | | | | | Fix styling for `app/assets/stylesheets/pages/status.scss` Closes #59929 See merge request gitlab-org/gitlab-ce!26875
| * Rename CI related selectorsGeorge Tsiolis2019-04-162-2/+2
| |
* | Merge branch '53138-add-metrics-usage-ping' into 'master'Grzegorz Bizon2019-04-161-0/+2
|\ \ | |/ |/| | | | | | | | | Adds instance metrics to usage ping Closes #53138 See merge request gitlab-org/gitlab-ce!27238
| * Adds instance metrics to usage pingRyan Cobb2019-04-101-0/+2
| | | | | | | | | | This adds influxdb_metrics_enabled and prometheus_metrics_enabled to usage ping.
* | Merge branch 'helm_uninstall_command' into 'master'Sean McGivern2019-04-161-0/+72
|\ \ | | | | | | | | | | | | Helm DeleteCommand See merge request gitlab-org/gitlab-ce!27348
| * | Implement commands to uninstall cluster applicationshelm_uninstall_commandThong Kuah2019-04-161-0/+72
| | | | | | | | | | | | | | | This is the backend part which just allows uninstalling Prometheus for now.
* | | Merge branch 'ci-lint-ssl-error' into 'master'Kamil Trzciński2019-04-161-0/+22
|\ \ \ | | | | | | | | | | | | | | | | Reporting SSL certificate verify errors in CI external config See merge request gitlab-org/gitlab-ce!26750
| * | | catching and cleanly reporting SSL errors in Ci::Config::External::Processordrew cimino2019-04-151-0/+22
| | | |
* | | | Merge branch 'forbid-the-usage-of-reload' into 'master'Lin Jen-Shin2019-04-151-2/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Forbid the usage of reload Closes #60218 See merge request gitlab-org/gitlab-ce!27125
| * | | | Forbid the use of `#reload` and prefer `#reset`forbid-the-usage-of-reloadKamil Trzciński2019-04-151-2/+2
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | The `#reload` makes to load all objects into memory, and the main purpose of `#reload` is to drop the association cache. The `#reset` seems to solve exactly that case.
* | | | Merge branch 'osw-remote-multi-line-suggestions-ff' into 'master'Lin Jen-Shin2019-04-151-23/+4
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | Remove multi-line suggestions feature flag Closes #59178 See merge request gitlab-org/gitlab-ce!27219
| * | | Remove multi-line suggestions feature flagosw-remote-multi-line-suggestions-ffOswaldo Ferreira2019-04-101-23/+4
| | |/ | |/| | | | | | | That's a straightforward feature flag code removal for 11.10
* | | Merge branch 'sh-validate-ref-name-in-commit' into 'master'Rémy Coutable2019-04-151-0/+30
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Validate refs used in controllers don't have spaces Closes #58572 and gitaly#1425 See merge request gitlab-org/gitlab-ce!24037
| * | | Validate refs used in controllers don't have spacessh-validate-ref-name-in-commitStan Hu2019-04-141-0/+30
| | |/ | |/| | | | | | | | | | | | | | | | This avoids an unnecessary call to Gitaly and reduces gRPC errors. * Closes https://gitlab.com/gitlab-org/gitaly/issues/1425 * Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58572
* | | Added write_repository scope for personal access tokenHoratiu Eugen Vlad2019-04-151-16/+59
| | |
* | | Un-quarantine speccherry-pick-39eb16aaKamil Trzciński2019-04-151-3/+3
| | |
* | | Merge branch 'require-all-templates-to-include-default-stages' into 'master'Sean McGivern2019-04-152-37/+30
|/ / | | | | | | | | | | | | | | | | | | | | Require all templates to use default stages Closes #59992 See merge request gitlab-org/gitlab-ce!26954 (cherry picked from commit 39eb16aab2dbac3347f61f83fb60f5448d44e965) e0df05cf Require all templates to use default stages
* | Squashed commits and modified visibility level outputSara Ahbabou2019-04-121-0/+8
| | | | | | | | Added changelog and rebased
* | Merge branch 'restore-hipchat' into 'master'Nick Thomas2019-04-112-0/+23
|\ \ | | | | | | | | | | | | | | | | | | Revert "Remove HipChat integration from GitLab" Closes #60042 See merge request gitlab-org/gitlab-ce!27172
| * | Revert "Remove HipChat integration from GitLab"Sean McGivern2019-04-102-0/+23
| |/ | | | | | | This reverts commit a5378665a1dc0b9c8dc3a4fa279a0eb78aac5aac.
* | Merge branch 'revert-24704-download-repository-path' into 'master'Rémy Coutable2019-04-112-29/+13
|\ \ | | | | | | | | | | | | Revert "Merge branch '24704-download-repository-path' into 'master'" See merge request gitlab-org/gitlab-ce!27249
| * | Revert "Merge branch '24704-download-repository-path' into 'master'"revert-24704-download-repository-pathPatrick Bajao2019-04-112-29/+13
| | | | | | | | | | | | | | | This reverts commit 6c75bd015cba181f028bc87c396c3d8e43b5dc3e, reversing changes made to 1be7f5aaa38aba79843eae8835be6c99c025e982.
* | | Merge branch 'jc-guard-against-empty-dereferenced_target' into 'master'Sean McGivern2019-04-111-0/+7
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Guard against nil dereferenced_target Closes #60076 See merge request gitlab-org/gitlab-ce!27192
| * | Guard against nil dereferenced_targetjc-guard-against-empty-dereferenced_targetJohn Cai2019-04-101-0/+7
| | |
* | | Align UrlValidator to validate_url gem implementation.Thong Kuah2019-04-111-3/+3
| | | | | | | | | | | | | | | | | | | | | Renamed UrlValidator to AddressableUrlValidator to avoid 'url:' naming collision with ActiveModel::Validations::UrlValidator in 'validates' statement. Make use of the options attribute of the parent class ActiveModel::EachValidator. Add more options: allow_nil, allow_blank, message. Renamed 'protocols' option to 'schemes' to match the option naming from UrlValidator.
* | | Revert "Merge branch 'tz-reorganise-digests-json' into 'master'"tz-revert-new-emojis-loadingTim Zallmann2019-04-101-1/+1
| |/ |/| | | | | Reverts the loading of emojis and its images to move forward with RC
* | Merge branch '47327-fix-github-project-import-visibility' into 'master'Douwe Maan2019-04-101-3/+13
|\ \ | | | | | | | | | | | | Fix GitHub project import visibility See merge request gitlab-org/gitlab-ce!27133
| * | Address style review commentDaniel Wyatt2019-04-091-2/+0
| | |
| * | Add test for github project import to user namespace.Daniel Wyatt2019-04-091-0/+12
| | |
| * | Fix GitHub project import visibilityDaniel Wyatt2019-04-081-2/+2
| | |
* | | Add more info logging to cluster appsDylan Griffith2019-04-101-0/+27
| |/ |/| | | | | | | Log events so that it's easy to see when different requests are starting.
* | Move Contribution Analytics related spec in ↵Imre Farkas2019-04-097-0/+439
| | | | | | | | spec/features/groups/group_page_with_external_authorization_service_spec to EE
* | Merge branch 'osw-multi-assignees-merge-requests' into 'master'Nick Thomas2019-04-095-5/+14
|\ \ | | | | | | | | | | | | [Backport] Support multiple assignees for merge requests See merge request gitlab-org/gitlab-ce!27089
| * | [CE] Support multiple assignees for merge requestsosw-multi-assignees-merge-requestsOswaldo Ferreira2019-04-085-5/+14
| | | | | | | | | | | | | | | Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161 (code out of ee/ folder).
* | | Merge branch '43263-git-push-option-to-create-mr' into 'master'Nick Thomas2019-04-091-0/+103
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Git push options to create a merge request, set target_branch and set merge when pipeline succeeds Closes #53198 and #43263 See merge request gitlab-org/gitlab-ce!26752
| * | | Use Gitlab::PushOptions for `ci.skip` push optionLuke Duncalfe2019-04-091-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously the raw push option Array was sent to Pipeline::Chain::Skip. This commit updates this class (and the chain of classes that pass the push option parameters from the API internal `post_receive` endpoint to that class) to treat push options as a Hash of options parsed by GitLab::PushOptions. The GitLab::PushOptions class takes options like this: -o ci.skip -o merge_request.create -o merge_request.target=branch and turns them into a Hash like this: { ci: { skip: true }, merge_request: { create: true, target: 'branch' } } This now how Pipeline::Chain::Skip is determining if the `ci.skip` push option was used.
| * | | Support merge request create with push optionsLuke Duncalfe2019-04-091-0/+91
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To create a new merge request: git push -u origin -o merge_request.create To create a new merge request setting target branch: git push -u origin -o merge_request.create \ -o merge_request.target=123 To update an existing merge request with a new target branch: git push -u origin -o merge_request.target=123 A new Gitlab::PushOptions class handles parsing and validating the push options array. This can be the start of the standard of GitLab accepting push options that follow namespacing rules. Rules are discussed in issue https://gitlab.com/gitlab-org/gitlab-ce/issues/43263. E.g. these push options: -o merge_request.create -o merge_request.target=123 Become parsed as: { merge_request: { create: true, target: '123', } } And are fetched with the class via: push_options.get(:merge_request) push_options.get(:merge_request, :create) push_options.get(:merge_request, :target) A new MergeRequests::PushOptionsHandlerService takes the `merge_request` namespaced push options and handles creating and updating merge requests. Any errors encountered are passed to the existing `output` Hash in Api::Internal's `post_receive` endpoint, and passed to gitlab-shell where they're output to the user. Issue https://gitlab.com/gitlab-org/gitlab-ce/issues/43263
* | | Merge branch 'osw-schedule-multiple-mr-assignees-ff-auto-enabling' into 'master'Yorick Peterse2019-04-091-0/+40
|\ \ \ | | | | | | | | | | | | | | | | Add methods to check dead and retrying jobs See merge request gitlab-org/gitlab-ce!27149
| * | | Add methods to check dead and retrying jobsosw-schedule-multiple-mr-assignees-ff-auto-enablingOswaldo Ferreira2019-04-081-0/+40
| |/ / | | | | | | | | | | | | It adds two methods for checking if a background job (for a given class) has dead or retrying jobs.
* | | Reduce number of rspec retriesSanad Liaquat2019-04-091-1/+1
| | | | | | | | | | | | | | | In both e2e QA tests and unit tests, reduce the number of retires to 2 (i.e., 1 initial and one retry)
* | | Add environment url validationWolphin2019-04-091-0/+40
| | |
* | | Set release name when adding release notes to an existing tagJason Goodman2019-04-091-0/+1
|/ / | | | | | | Also set the release sha and author
* | Merge branch 'sh-fix-issue-59985' into 'master'Michael Kozono2019-04-081-1/+1
|\ \ | | | | | | | | | | | | | | | | | | Fix stage index migration failing in PostgreSQL 10 Closes #59985 See merge request gitlab-org/gitlab-ce!26972
| * | Fix stage index migration failing in PostgreSQL 10sh-fix-issue-59985Stan Hu2019-04-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed in https://www.postgresql.org/message-id/9922.1353433645%40sss.pgh.pa.us, the PostgreSQL window function last_value may not consider the right rows: Note that first_value, last_value, and nth_value consider only the rows within the "window frame", which by default contains the rows from the start of the partition through the last peer of the current row. This is likely to give unhelpful results for last_value and sometimes also nth_value. You can redefine the frame by adding a suitable frame specification (RANGE or ROWS) to the OVER clause. See Section 4.2.8 for more information about frame specifications. This query could be fixed by adding `RANGE BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING`, but that's quite verbose. It's simpler just to use the first_value function. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59985
* | | Improve performance of PR importfix-pull-request-importerKamil Trzciński2019-04-081-0/+73
| |/ |/| | | | | | | | | This removes unneeded `.reload` call which makes AR to load ALL objects, and create its in-memory representation.
* | GitHub import: Run housekeeping after initial importsh-git-gc-after-initial-fetchStan Hu2019-04-071-0/+5
| | | | | | | | | | | | | | | | | | After an initial fetch, the repository will have many loose objects and refs. Running a `git gc` will compact refs into `packed-refs` and objects into `.pack` files, which should make importing pull requests faster. Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/59477
* | Handle possible HTTP exception for Sentry clientPeter Leitzen2019-04-071-9/+39
| | | | | | | | | | | | | | | | | | | | | | Prior this commit exceptions raised during a HTTP request weren't caught by the Sentry client and were passed to the user. In addition the Sentry client tried to catch a non-existent error `Sentry::Client::SentryError`. Now, the Sentry client catches all possible errors coming from a HTTP request.