summaryrefslogtreecommitdiff
path: root/spec/lib
Commit message (Collapse)AuthorAgeFilesLines
* Fix Import/Export error checking versionsfix/import-errorJames Lopez2016-08-031-0/+30
|
* Add failing tests for #19028winniehell2016-08-021-0/+12
|
* Fix specsfix-extra-new-line-crlfRémy Coutable2016-08-011-1/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Trim extra displayed carriage returns in diffs and files with CRLFsStan Hu2016-08-011-0/+12
| | | | Closes #20440
* squashed - fixed label and milestone association problems, updated specs and ↵fix/labels-milestones-importJames Lopez2016-08-013-141/+77
| | | | refactored reader class a bit
* Merge branch 'ability-batch-issue-checking' into 'master' Robert Speicher2016-07-291-6/+6
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Optimize checking if a user can read multiple issues ## What does this MR do? This optimizes various parts of the code so it can more efficiently check if a user can read a list of issues. ## Are there points in the code the reviewer needs to double check? Yes, in particular `Ability.issues_readable_by_user` should be checked to make sure it correctly allows/restricts access to issues. ## Why was this MR needed? Currently the general approach to checking if one can read an issue is to iterate over the issues to check and call `can?(user, :read_issue, issue)` for every issue. This is not efficient as the same work has to be done for every issue. ## What are the relevant issue numbers? * #15607 * #17463 See merge request !5370
| * Method for returning issues readable by a userability-batch-issue-checkingYorick Peterse2016-07-291-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | The method Ability.issues_readable_by_user takes a list of users and an optional user and returns an Array of issues readable by said user. This method in turn is used by Banzai::ReferenceParser::IssueParser#nodes_visible_to_user so this method no longer needs to get all the available abilities just to check if a user has the "read_issue" ability. To test this I benchmarked an issue with 222 comments on my development environment. Using these changes the time spent in nodes_visible_to_user was reduced from around 120 ms to around 40 ms.
* | Merge branch 'refactor/ci-config-move-job-entries' into 'master' Rémy Coutable2016-07-2913-83/+623
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move CI job config entries from legacy to new config ## What does this MR do? This MR extracts jobs configuration logic from legacy CI config processor to the new code. ## What are the relevant issue numbers? #15060 ## Does this MR meet the acceptance criteria? - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) See merge request !5087
| * | Improve code, remove unused validator, improve namesGrzegorz Bizon2016-07-292-3/+3
| | |
| * | Merge branch 'master' into refactor/ci-config-move-job-entriesGrzegorz Bizon2016-07-227-5/+248
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (183 commits) Add a spec for #20079. Skip repository storage path valitaions on test environment Use Pathname to make the repository storage path validations more robust Update to gitlab_git 10.4.1 and take advantage of preserved Ref objects Change nav link snippet controller Reduce min width of pipeline table Retrieve rendered HTML from cache in one request Explain CI_PROJECT_NAMESPACE better Bump vmstat version to fix issues reporting on FreeBSD Fix sha icon positioning on safari Don't drop in DropAndReaddHasExternalWikiInProjects Mobile view for commit status Fix ci icons getting cut off Update CHANGELOG Extract helper methods to clean up RepositoryArchiveCleanUpService spec Use Dir.mktmpdir instead of FileUtils.mkdir_p in the spec Fix firefox rendering of SVGs Fix icons on commits page and builds page Add new fork SVG to fix weird styling of other SVGs Bug fixes ...
| * | | Move job dependencies entry to the new CI configGrzegorz Bizon2016-07-201-1/+1
| | | |
| * | | Add minor readability, style improvements in CI configGrzegorz Bizon2016-07-201-1/+1
| | | |
| * | | Merge branch 'master' into refactor/ci-config-move-job-entriesGrzegorz Bizon2016-07-2016-968/+546
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (321 commits) Fix the Sentry spam from CSP violations by disabling it. Limit git rev-list output count to one in forced push check Ensure Owners are included in the scope for authorized_projects Fix alignment of icons on project page Fix ci_status_helper_spec to look for new SVGs use 2.0.5, actually (2.0.4 was a bad release) upgrade rouge to 2.0.4 Fix help page paths to make sure shortcuts and the UI help page work. fixes an issue cause by a bad merge Vertically align status icon within table Add new icons for every CI status Add global style for running icon Align running icon in merge request Add new running icon; add a bunch of styles to get svg to match existing fa icons Improve code design Fix broken builds_for_ref Move when tests before to make it no conflict with manual-actions Use value of `yaml_variables` and `when` from config_processor if undefined Add CHANGELOG entry CHANGELOG item ... Conflicts: lib/ci/gitlab_ci_yaml_processor.rb spec/lib/ci/gitlab_ci_yaml_processor_spec.rb
| * | | | Move job environment validation to new CI configGrzegorz Bizon2016-07-191-3/+3
| | | | |
| * | | | Move tags and allow_failure CI entries to new configGrzegorz Bizon2016-07-181-2/+2
| | | | |
| * | | | Validate allowed keys only in new CI configGrzegorz Bizon2016-07-181-0/+10
| | | | |
| * | | | Improve valid keys validation for CI config nodesGrzegorz Bizon2016-07-181-5/+16
| | | | |
| * | | | Move job artifacts configuration new CI config codeGrzegorz Bizon2016-07-183-6/+83
| | | | |
| * | | | Move job variables config entry to new CI configGrzegorz Bizon2016-07-181-1/+1
| | | | |
| * | | | Move except and only job nodes to new CI configGrzegorz Bizon2016-07-182-2/+58
| | | | |
| * | | | Move job image and services nodes to new CI configGrzegorz Bizon2016-07-181-4/+4
| | | | |
| * | | | Merge branch 'master' into refactor/ci-config-move-job-entriesGrzegorz Bizon2016-07-1835-71/+2992
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (522 commits) Fix CI yaml example Align cancel and retry buttons Remove deploy to production button Fix a bug where the project's repository path was returned instead of the wiki path Don't fail to highlight when Rouge doesn't have a lexer Revert "Merge branch 'gl-dropdown-issuable-form' into 'master'" Update tests Don't fail when Ci::Pipeline doesn't have a project Don't fail when a LegacyDiffNote didn't store the right diff Update CHANGELOG Use cattr_accessor instead duplicating code on NoteOnDiff concern Fix mentioned users list on diff notes Don't ask Heather to review documentation MR's add project name and namespace to filename on project export navbar_icon was renamed to custom_icon in: use %(...) and %[...] in favor of %<...> Fix spec Don't attempt to disable statement timeout on a MySQL DB Disable statement timeout outside of transaction and during adding concurrent index Disable PostgreSQL statement timeout during migrations Add visibility icon ...
| * | | | | Simplify abstract class for CI config entry nodesGrzegorz Bizon2016-07-151-4/+10
| | | | | |
| * | | | | Simplify CI config and remove logical validationGrzegorz Bizon2016-07-152-8/+2
| | | | | |
| * | | | | Add metadata to new CI config and expose job nameGrzegorz Bizon2016-07-154-37/+34
| | | | | |
| * | | | | Remove job cache configfrom legacy yaml processorGrzegorz Bizon2016-07-141-3/+3
| | | | | |
| * | | | | Remove references to global entry in new CI configGrzegorz Bizon2016-07-143-13/+4
| | | | | |
| * | | | | Revert logical validation in CI job stage entryGrzegorz Bizon2016-07-142-67/+8
| | | | | |
| * | | | | Revert references to global node in CI job entryGrzegorz Bizon2016-07-143-122/+2
| | | | | |
| * | | | | Improve CI job entry validations in new configGrzegorz Bizon2016-07-144-15/+23
| | | | | |
| * | | | | Expose CI job commands and use in legacy processorGrzegorz Bizon2016-07-133-7/+19
| | | | | |
| * | | | | Add before script and commands to CI job entryGrzegorz Bizon2016-07-131-6/+111
| | | | | |
| * | | | | Improve CI stage configuration entry validationsGrzegorz Bizon2016-07-131-2/+2
| | | | | |
| * | | | | Do not raise when getting value of invalid CI nodeGrzegorz Bizon2016-07-121-4/+2
| | | | | |
| * | | | | Simplify undefined node definition in CI configGrzegorz Bizon2016-07-123-55/+30
| | | | | |
| * | | | | Add CI config node that is unspecified null entryGrzegorz Bizon2016-07-121-0/+29
| | | | | |
| * | | | | Prevalidate CI entries recursively on processedGrzegorz Bizon2016-07-121-1/+1
| | | | | |
| * | | | | Require parent when using node factory in CI configGrzegorz Bizon2016-07-101-7/+36
| | | | | |
| * | | | | Rename CI config job script entry node to commandsGrzegorz Bizon2016-07-101-2/+2
| | | | | |
| * | | | | Move after script CI job confg to new processorGrzegorz Bizon2016-07-102-3/+5
| | | | | |
| * | | | | Add CI job script node in new config processorGrzegorz Bizon2016-07-104-5/+54
| | | | | |
| * | | | | Add before_script node to CI job entry configGrzegorz Bizon2016-07-102-15/+33
| | | | | |
| * | | | | Extend CI job entries fabrication and validationGrzegorz Bizon2016-07-094-16/+36
| | | | | |
| * | | | | Use node factory to assemble global CI config entryGrzegorz Bizon2016-07-091-2/+2
| | | | | |
| * | | | | Integrate CI job stage entry into CI configurationGrzegorz Bizon2016-07-095-17/+30
| | | | | |
| * | | | | Add CI config known stage validation for job stageGrzegorz Bizon2016-07-081-11/+43
| | | | | |
| * | | | | Extract CI entry node validator and improve namingGrzegorz Bizon2016-07-081-1/+4
| | | | | |
| * | | | | Extract internal attributes validator for CI entryGrzegorz Bizon2016-07-081-2/+4
| | | | | |
| * | | | | Require reference to CI config for some entriesGrzegorz Bizon2016-07-071-9/+22
| | | | | |
| * | | | | Simplify CI config entry node factory, use attribsGrzegorz Bizon2016-07-071-19/+7
| | | | | |
View Lorry Controller Status