| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
The setup was wrong, and due to Gitaly being a bit more strict it had to
match up. The test is now accurate and passing again.
|
| |
|
|
|
| |
Also add ::Gitlab::LetsEncrypt.enabled? shortcut
and simplify it a lot
|
| |
|
|
| |
Changes migration and all other places the attribute is used
|
| |\
| |
| |
| |
| | |
Refactor Deployment#cluster to #deployment_platform_cluster
See merge request gitlab-org/gitlab-ce!29961
|
| | |
| |
| |
| |
| | |
We will introduce #cluster at a later stage.
Also deprecate this method
|
| | |
| |
| |
| | |
This reverts merge request !29832
|
| |\ \
| | |
| | |
| | |
| | | |
Build correct basenames for title search results
See merge request gitlab-org/gitlab-ce!29898
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The "basename" here needs to be the full path without the trailing
extension, instead of stripping the leading path as well.
This was previously fixed in 2f36efa0871 inside the view, but the
problematic code was still present in FoundBlob, and the corresponding
spec didn't actually use a child wiki page to properly verify the fix.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
RSpec::Parameterized syntax for CI pipeline build seed specs
See merge request gitlab-org/gitlab-ce!29947
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix label serialisation in issue and note hooks
Closes #63473
See merge request gitlab-org/gitlab-ce!29850
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We were not calling hook_attrs on the labels correctly. Specs were
passing because the issues under test did not have any labels!
|
| |\ \ \ \ \
| |_|_|_|/
|/| | | |
| | | | |
| | | | | |
Enable JIT Kubernetes resource creation for project level clusters
See merge request gitlab-org/gitlab-ce!29515
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Previously this behaviour was only available to group
and instance-level clusters, as some project clusters
relied on Kubernetes credentials being passed through
to the runner instead of having their resources managed
by GitLab (which is not available when using JIT). These
clusters have been migrated to unmanaged, so resources
can be created on demand for the remaining managed clusters.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
As Auto DevOps deployments both label and annotations, that will be
included in the deploy board so need to warn at all.
|
| | |_|/ /
|/| | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Avoid storing backtraces from Bitbucket Cloud imports in the database
See merge request gitlab-org/gitlab-ce!29862
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We noticed in
https://gitlab.com/gitlab-com/gl-infra/production/issues/908 some
Bitbucket imports took over a second to load their projects row because
`import_error` was huge due to errors. To prevent this, we now:
1. Clean the backtraces
2. Log the details into importer.log
3. Omit the details from the database
|
| | | | | |
| | | | |
| | | | |
| | | | | |
https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md#version-341-2019-06-13
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'63406-selecting-a-line-in-ci-job-trace-using-triple-click-selects-the-previous-line-also' into 'master'
Fix copying a single line from Firefox
Closes #63406
See merge request gitlab-org/gitlab-ce!29832
|
| | |\ \ \ \ \
| | |/ / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'63406-selecting-a-line-in-ci-job-trace-using-triple-click-selects-the-previous-line-also'
# Conflicts:
# spec/lib/gitlab/ci/ansi2html_spec.rb
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This change ensures that all open <span> tags are closed before adding a
<br> tag.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Do not rewrite relative links for system notes
Closes #63162
See merge request gitlab-org/gitlab-ce!29825
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Add Gitaly data to the usage ping
See merge request gitlab-org/gitlab-ce!29893
|
| | | |_|_|_|_|/
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Gitaly data wasn't available to the team, an this change is a first
iteration towards understanding what data we need and how to interpret
it. Later more values will be added.
For now the most important thing is the filesystem String Array, as that
includes data on ext4 exposure and NFS.
Part of: https://gitlab.com/gitlab-org/gitlab-ce/issues/60602
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Backport changes made by EE to various YAML configuration files
See merge request gitlab-org/gitlab-ce!29606
|
| | | |_|_|_|_|/
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
To make this happen, we need to conditionally add the group_saml
strategy when running tests, but only on EE. This requires some changes
to Gitlab.ee? so that it can be used before/without loading the Rails
environment. We also have to change how we require a few files, so this
can run outside of Rails.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This commits adds support for metrics dashboards
for embedding. If the flag 'embedded' is provided
to the environments/id/metrics_dashboard endpoint,
the response will be suitable for embedding in
issues or other content.
This is a precursor for support for embedding
metrics in GFM.
|
| |\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
'master'
Gitlab::JsonCache#parse_value ensure string
Closes #63510
See merge request gitlab-org/gitlab-ce!29885
|
| | | |_|_|/ /
| |/| | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Remove import columns from projects table
See merge request gitlab-org/gitlab-ce!29863
|
| | |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21497, we
migrated all project import data into a separate table,
`project_import_data`. In addition, we also added:
```
ignore_column :import_status, :import_jid, :import_error
```
In https://gitlab.com/gitlab-com/gl-infra/production/issues/908, we
observed some of these `import_error` columns consumed megabytes of
error backtraces and caused slow loading of projects whenever a `SELECT
* from projects` query loaded the row into memory.
Since we have long migrated away from these columns, we can now drop
these columns entirely.
|
| |/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This adds a `markdown_field` to our types.
Using this helper will render a model's markdown field using the
existing `MarkupHelper` with the context of the GraphQL query
available to the helper.
Having the context available to the helper is needed for redacting
links to resources that the current user is not allowed to see.
Because rendering the HTML can cause queries, the complexity of a
these fields is raised by 5 above the default.
The markdown field helper can be used as follows:
```
markdown_field :note_html, null: false
```
This would generate a field that will render the markdown field `note`
of the model. This could be overridden by adding the `method:`
argument. Passing a symbol for the method name:
```
markdown_field :body_html, null: false, method: :note
```
It will have this description by default:
> The GitLab Flavored Markdown rendering of `note`
This could be overridden by passing a `description:` argument.
The type of a `markdown_field` is always `GraphQL::STRING_TYPE`.
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Adds missing class in collapsible sections
Closes #63417
See merge request gitlab-org/gitlab-ce!29804
|
| | |/ / /
| | | |
| | | |
| | | |
| | | | |
Will apply identation from
CSS to collapsible sections
|
| | |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit adds
- feature specs
- to test the ability of a user with "developer" permission
to delete tags in repositories.
- documentation
|
| | | |
| | |
| | |
| | | |
Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/61201#
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Remove support for app label matching
See merge request gitlab-org/gitlab-ce!29460
|
| | |/ /
| | |
| | |
| | |
| | |
| | | |
From now on, only match on the annotations, instead of falling back to
legacy app label. This enables users to use the app label for other
purposes such as helm charts.
|
| |\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | | |
Cache feature flag names in Redis for a minute
Closes #63435
See merge request gitlab-org/gitlab-ce!29816
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We saw on GitLab.com, the SQL query, `SELECT "features"."key" FROM
"features"` peaked at 2300 times per second.
We can quiet this down a bit by caching it in Redis for a minute.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63435
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The feature flag has been introduced an was turned off by default,
now the it will default to be turned on. That change would still allow
users to turn this feature off by leveraging the Rails console by
running:
`Feature.disable("gitaly_catfile-cache")`
Another option is to manage the number of items the LRU cache will
contain, by updating the `config.toml` for Gitaly. This would be the
`catfile_cache_size`:
https://gitlab.com/gitlab-org/gitaly/blob/0dcb5c579e63754f557aef91a4fa7a00e5b8b127/config.toml.example#L27
Closes: https://gitlab.com/gitlab-org/gitaly/issues/1712
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
The GitalyClient held a lot of logic which was all very tightly coupled.
In this instance the feature logic was extracted to make it do just a
little less and create a bit more focus in the GitalyClient's
responsibilies.
|
| | |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This moves all existing `image/services/before_script/variables`
into `default:`. This allows us to easily add a default and
top-level entries. `default`: is keep backward compatible: to
be considered to be job if `default:script:` is specified. This
behavior should be removed.
All existing `image/services/before_script/variables` are properly
handled in root context.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
We are deprecating this service in favor of instance wide clusters.
Therefore we removed some code that is not anymore needed for a
readonly cluster and also we added some flags to allow for this
deprecation. These flags are to be removed in the next release when
we finally completelly remove KubernetesService.
|
| |\ \
| |/
|/|
| |
| | |
Refresh service_account_token for kubernetes_namespaces
See merge request gitlab-org/gitlab-ce!29657
|
| | |
| |
| |
| |
| |
| |
| | |
There seems to be several examples where service_account_token is blank
even in GitLab.com newly created kubernetes_namespaces . We have not
figured out why they are blank but this should hopefully fix some issues
similar to https://gitlab.com/gitlab-org/gitlab-ce/issues/55362
|
| |\ \
| | |
| | |
| | |
| | | |
Add collapsible sections to job log
See merge request gitlab-org/gitlab-ce!28642
|
| | | | |
|
