summaryrefslogtreecommitdiff
path: root/spec/lib
Commit message (Collapse)AuthorAgeFilesLines
* Fix rubucop offensesbitbucket-oauth2Douglas Barbosa Alexandre2016-12-161-1/+0
|
* BB importer: Milestone importerValery Sizov2016-12-161-0/+6
|
* Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into bitbucket-oauth2Valery Sizov2016-12-1422-64/+664
|\
| * Merge branch 'build-statuses' into 'master' Rémy Coutable2016-12-1422-64/+664
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Detailed build statuses ## What does this MR do? Implements detailed statuses for `Ci::Builds` and `CommitStatus`. It also adds a new icon for manual build. ## Screenshots ![manual_builds_icon](/uploads/22b5c594350856c85398ef705a635f8b/manual_builds_icon.png) ## What are the relevant issue numbers? See #24273, closes #22642 See merge request !7989
| | * Improve build status specs contexts descriptionsGrzegorz Bizon2016-12-144-4/+4
| | |
| | * Make it possible to mix `Gitlab::Routing` inGrzegorz Bizon2016-12-131-0/+23
| | |
| | * Extract abilities checking module from ability modelGrzegorz Bizon2016-12-131-0/+27
| | |
| | * Extend tests for pipeline detailed status helpersGrzegorz Bizon2016-12-131-12/+18
| | |
| | * Add tests for common build detailed status helpersGrzegorz Bizon2016-12-131-0/+37
| | |
| | * Add tests for detailed build statuses factoryGrzegorz Bizon2016-12-131-0/+141
| | |
| | * Add tests for build cancelable/retryable statusesGrzegorz Bizon2016-12-132-0/+172
| | |
| | * Extend specs for build play/stop detailed statusesGrzegorz Bizon2016-12-132-7/+55
| | |
| | * Refine build stop/play extended status specsGrzegorz Bizon2016-12-132-31/+31
| | |
| | * Add specs for build stop extended detailed statusGrzegorz Bizon2016-12-121-0/+59
| | |
| | * Add tests for build play extended detailed statusGrzegorz Bizon2016-12-121-0/+59
| | |
| | * Fix some detailed statuses specs related to abilitiesGrzegorz Bizon2016-12-127-17/+41
| | |
| | * Fix tests related to detailed statuses and permissionsGrzegorz Bizon2016-12-1214-41/+45
| | | | | | | | | | | | [ci skip]
* | | BB importer: fix specsValery Sizov2016-12-146-12/+15
| | |
* | | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into bitbucket-oauth2Valery Sizov2016-12-1438-139/+1372
|\ \ \ | |/ /
| * | Merge branch 'unescape-relative-path' into 'master' Gabriel Mazetto2016-12-121-1/+1
| |\ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid escaping relative links in Markdown twice ## What does this MR do? Avoid escaping relative links in Markdown twice. ## Why was this MR needed? Relative links with special characters (e.g. spaces) were escaped twice. ## What are the relevant issue numbers? closes #25191, #25318 See merge request !7940
| | * Add failing test for #25191winniehell2016-12-051-1/+1
| | |
| * | Merge branch 'dz-nested-groups' into 'master' Douwe Maan2016-12-092-0/+8
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add nested groups support on data level ## What does this MR do? - [x] Add `parent_id` field to `Namespace`model. - [x] Create new database table `routes` that keeps information about full path to each group or project - [x] Remove uniq index from `namespaces.path` - [x] Add uniq index on `routes.path` - [x] Fill routes table with path data from namespaces and projects - [x] Change Namespace/Project URL lookup by routes table - [x] Rename related routes (nested groups, projects) when parent path changes This is solely backend preparation. UI, Permissions and API support will be added in separate merge request. ## Are there points in the code the reviewer needs to double check? migrations, Route model, Routable concern Will require downtime. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7121#note_19490281 discussion ## Why was this MR needed? One step further to full nested groups support ## Screenshots (if relevant) No UI changes in this merge request so far ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added~~ - ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - ~~API support added~~ - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/2772 See merge request !7121
| | * | Add nested groups support on data leveldz-nested-groupsDmitriy Zaporozhets2016-12-082-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * add parent_id field to namespaces table to store relation with nested groups * create routes table to keep information about full path of every group and project * project/group lookup by full path from routes table Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security'Douwe Maan2016-12-081-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace MR access checks with use of MergeRequestsFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 :warning: - Potentially untested :bomb: - No test coverage :traffic_light: - Test coverage of some sort exists (a test failed when error raised) :vertical_traffic_light: - Test coverage of return value (a test failed when nil used) :white_check_mark: - Permissions check tested - [x] :bomb: app/finders/notes_finder.rb:17 - [x] :warning: app/views/layouts/nav/_project.html.haml:80 [`.count`] - [x] :bomb: app/controllers/concerns/creates_commit.rb:84 - [x] :traffic_light: app/controllers/projects/commits_controller.rb:24 - [x] :traffic_light: app/controllers/projects/compare_controller.rb:56 - [x] :vertical_traffic_light: app/controllers/projects/discussions_controller.rb:29 - [x] :white_check_mark: app/controllers/projects/todos_controller.rb:27 - [x] :vertical_traffic_light: app/models/commit.rb:268 - [x] :white_check_mark: lib/gitlab/search_results.rb:71 - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)` - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`. - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?` See merge request !2033
| * | | Merge branch 'pipeline-stage' into 'master' Rémy Coutable2016-12-083-0/+85
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refine pipeline stages ## What does this MR do? Introduces a concept of `Ci::Stage` to make it easier to have detailed statuses. ## Why was this MR needed? This is needed to simplify the handling of `Ci::Statuses` and make the `Stage` actual concept in code: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7889 See merge request !7927
| | * | | Code reviewKamil Trzcinski2016-12-072-7/+3
| | | | |
| | * | | Add Ci::Status::FactoryKamil Trzcinski2016-12-071-0/+26
| | | | |
| | * | | Added Ci::Stage specsKamil Trzcinski2016-12-063-8/+10
| | | | |
| | * | | Fix test failuresKamil Trzcinski2016-12-062-4/+6
| | | | |
| | * | | Added Stage testsKamil Trzcinski2016-12-062-0/+59
| | | | |
| * | | | Merge branch 'fix-all-dashboard' into 'master' Sean McGivern2016-12-081-3/+12
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't whitelist events for all filter Closes #24826 See merge request !7673
| | * | | | Add issue events filter and make sure "All" really shows everythingOxan van Leeuwen2016-12-041-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the EventFilter whitelists event types for the "All" filter. This has gotten outdated, which causes the confusing behaviour of the "All" tab not really showing all events. To make matters worse, by default no tab at all is selected, which does show all events, so selecting the "All" tab actually hides some events. Fix this by: - Making sure All always includes all activity, by abolishing the whitelist and just returning all events instead. - Make the All tab selected by default. - Add Issue events tab to include the specific events around opening and closing issues, since there was no specific filter to see them yet. Fixes #24826
| * | | | | Fix Backup::Manager#remove_old25399-backup-task-is-not-working-on-8-15-preSean McGivern2016-12-071-0/+127
| | | | | |
| * | | | | Merge branch '25209-improve-length-validators' into 'master' Rémy Coutable2016-12-071-1/+1
| |\ \ \ \ \ | | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Use :maximum instead of :within for length validators with a 0..N range Closes #25209 See merge request !7894
| | * | | | Use :maximum instead of :within for length validators with a 0..N range25209-improve-length-validatorsRémy Coutable2016-12-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | Merge branch 'zj-guest-reads-public-builds' into 'master' Sean McGivern2016-12-061-1/+1
| |\ \ \ \ \ | | |_|_|/ / | |/| | | | | | | | | | | | | | | | Guests can read builds if those are public See merge request !6842
| | * | | | Update effected testszj-guest-reads-public-buildsZ.J. van de Weg2016-12-041-1/+1
| | | | | |
| * | | | | Merge branch 'refine-ci-statuses' into 'master' Kamil Trzciński2016-12-0611-0/+299
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refine CI Statuses ## What does this MR do? This MR introduces classes for each relevant CI status. ## What are the relevant issue numbers? Closes #24273 See merge request !7889
| | * | | | | Add text example for pipeline status without actionrefine-ci-statusesGrzegorz Bizon2016-12-061-1/+3
| | | | | | |
| | * | | | | Extend tests for pipeline status factoryGrzegorz Bizon2016-12-051-3/+16
| | | | | | |
| | * | | | | Implement pipeline status factory with extended statusGrzegorz Bizon2016-12-051-0/+37
| | | | | | |
| | * | | | | Fold core/extended status modules to reduce nestingGrzegorz Bizon2016-12-0511-11/+11
| | | | | | |
| | * | | | | Implement extended pipeline - status with warningsGrzegorz Bizon2016-12-022-0/+77
| | | | | | |
| | * | | | | Add implementation of common pipeline extended statusGrzegorz Bizon2016-12-021-0/+23
| | | | | | |
| | * | | | | Add information about badge test to core statusesGrzegorz Bizon2016-12-027-0/+28
| | | | | | |
| | * | | | | Add scaffold for remaining statuses-related classesGrzegorz Bizon2016-12-024-0/+0
| | | | | | |
| | * | | | | Implement the rest of core CI statuses with specsGrzegorz Bizon2016-12-027-1/+107
| | | | | | |
| | * | | | | Add abstract base class for core CI statusGrzegorz Bizon2016-12-021-0/+2
| | | | | | |
| | * | | | | Add initial implmentation for core success statusGrzegorz Bizon2016-12-021-0/+11
| | | |/ / / | | |/| | |
| * | | | | Merge branch 'glm-shorthand-reference' into 'master' Sean McGivern2016-12-069-119/+750
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GLM shorthand reference for projects from the same namespace Closes #21679 See merge request !7255
View Lorry Controller Status