summaryrefslogtreecommitdiff
path: root/spec/lib/banzai
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'dev_issue_15331' into 'master' Robert Speicher2016-04-211-1/+9
|\ | | | | | | | | | | | | | | | | Fixes window.opener bug Adds `noreferrer` value to rel attribute for external links REF: https://gitlab.com/gitlab-org/gitlab-ce/issues/15331 See merge request !1953
| * Fix failing specAlfredo Sumaran2016-04-211-1/+9
| |
* | Fix cross-project label ref with invalid projectGrzegorz Bizon2016-04-211-16/+26
|/ | | | Closes #15168
* Merge branch 'patch/fix-markdown-preview-wikis' into 'master' Robert Speicher2016-04-072-6/+8
|\ | | | | | | | | | | | | | | | | | | | | Wiki preview URL converting problem [via Markdown] Current implementation when rendering the preview, thinks relative links are for project repository files. We are creating a new preview route that will define correct context data to render for wikis instead. Fixes #2380, #1184 See merge request !3461
| * little refactor and improvements on specsGabriel Mazetto2016-04-062-7/+4
| |
| * Fixed WikiPipeline and specsGabriel Mazetto2016-04-061-3/+6
| |
| * Fixed Gollum pages link url expansion to render correctly in previewGabriel Mazetto2016-03-301-3/+5
| |
* | Fix header link rendering when containing numbersfix-markdown-renderingYorick Peterse2016-04-061-0/+8
| | | | | | | | | | | | | | | | | | | | | | This fixes the problem where Markdown such as: ### 31st Would get rendered as a link tag pointing to issue number 31 inside a header tag. See gitlab-org/gitlab-ce#14936 for more information.
* | Wrap images in discussions and wikis with a link to the image source using ↵connorshea2016-04-041-0/+24
|/ | | | | | | | ImageLinkFilter. Resolves #14411. See merge request !3464
* Merge branch 'master' into issue_12658Douwe Maan2016-03-211-1/+1
|\ | | | | | | | | | | | | | | | | # Conflicts: # app/models/issue.rb # app/views/projects/_home_panel.html.haml # app/views/shared/projects/_project.html.haml # db/schema.rb # spec/models/project_spec.rb
| * change the css class has_tooltip to has-tooltip universallychange_css_class_has_tooltip_to_has-tooltipArinde Eniola2016-03-201-1/+1
| |
* | Fix some specsDouwe Maan2016-03-201-2/+2
|/
* Merge branch 'label-tooltip' into 'master' Douwe Maan2016-03-191-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add label description in tooltip to labels in issue index and sidebar The tooltip can get quite big, but it’s so useful to inform people about what these labels mean new ![Screen_Shot_2016-03-08_at_11.48.28](/uploads/894baaaa1f789c3a2069a924d541e64b/Screen_Shot_2016-03-08_at_11.48.28.png) ![Screen_Shot_2016-03-08_at_11.48.20](/uploads/efe4fa0960054c4071b8f6bf83024403/Screen_Shot_2016-03-08_at_11.48.20.png) @JobV writes on Slack: > yeah I think it’s better than not, but I’d have to try it :smiley: > > cautious yes, revert if it’s annoying :wink: See merge request !3124
| * Fix specslabel-tooltipRémy Coutable2016-03-181-1/+1
| |
* | Restrict access to references for confidential issuesDouglas Barbosa Alexandre2016-03-171-1/+71
|/
* Be more intelligent about sanitizing links with unsafe protocolsrs-issue-14220Robert Speicher2016-03-141-0/+20
| | | | | | | This prevents false matches on relative links like `[database](database.md)`. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14220
* Merge branch 'feature/cross-project-labels' into 'master' Douwe Maan2016-03-071-1/+26
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support for cross project references for labels ## Summary Support for cross project references for labels. ## Rationale 1. Cross project label references are currently not supported in GitLab 1. `to_reference` method signature in `Label` model breaks the abstraction introduced in `Referable`. `concerns/referable.rb: def to_reference(_from_project = nil)` Signatures: ``` label.rb: def to_reference(format = :id) commit_range.rb: def to_reference(from_project = nil) commit.rb: def to_reference(from_project = nil) external_issue.rb: def to_reference(_from_project = nil) group.rb: def to_reference(_from_project = nil) issue.rb: def to_reference(from_project = nil) merge_request.rb: def to_reference(from_project = nil) milestone.rb: def to_reference(from_project = nil) project.rb: def to_reference(_from_project = nil) snippet.rb: def to_reference(from_project = nil) user.rb: def to_reference(_from_project = nil) ``` This MR suggests using `def to_reference(from_project = nil, format: :id)` which makes use of keyword arguments and preserves abstract interface. 1. We need support for cross project label references when we want to move issue to another project It may happen that issue description, system notes or comments contain reference to label and this reference will be invalid after moving issue to another project and will not be displayed correctly unless we have support for cross project references. Merge request that needs this feature: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2831 I think that cross project label references may be useful, (example: `Hey, see our issues for CI in GitLab CE! - gitab-org/gitlab-ce~"CI"`). cc @JobV @DouweM @rspeicher See merge request !2966
| * Change content of cross project labelGrzegorz Bizon2016-03-031-3/+3
| |
| * Improve cross project label look and feelGrzegorz Bizon2016-03-031-2/+8
| |
| * Add support for cross project references for labelsGrzegorz Bizon2016-03-031-0/+19
| |
| * Add support for keyword arguments in label reference methodGrzegorz Bizon2016-03-031-1/+1
| |
* | Merge branch 'rs-frontmatter-pre' into 'master' Robert Speicher2016-03-051-0/+53
|\ \ | | | | | | | | | | | | Properly display YAML front matter in Markdown See merge request !3072
| * | Add YamlFrontMatterFilter to the PreProcessPipelineRobert Speicher2016-03-041-0/+53
| |/ | | | | | | | | This filter will detect YAML Front Matter and convert it to an HTML table for prettier formatting.
* | Merge branch 'rs-wiki-pipeline-spec' into 'master' Douwe Maan2016-03-042-44/+60
|\ \ | |/ |/| | | | | | | | | | | Add a spec for WikiPipeline Removes the specs from GollumTagsFilter that were more like integration tests for the pipeline than unit tests of the filter. See merge request !3054
| * Replace `[[_TOC_]]` tag even if `toc` result is blankrs-wiki-pipeline-specRobert Speicher2016-03-032-3/+3
| |
| * Add a spec for WikiPipelineRobert Speicher2016-03-012-44/+60
| | | | | | | | | | Removes the specs from GollumTagsFilter that were more like integration tests for the pipeline than unit tests of the filter.
* | Add FilterArray class to Banzairs-filter-arrayRobert Speicher2016-03-011-0/+39
|/
* Merge branch 'rs-wiki-toc' into 'master' Douwe Maan2016-03-011-0/+52
|\ | | | | | | | | | | | | Replace Gollum `[[_TOC_]]` tag with result of TableOfContentsFilter Closes #2494 See merge request !2952
| * Replace Gollum `[[_TOC_]]` tag with result of TableOfContentsFilterrs-wiki-tocRobert Speicher2016-02-231-0/+52
| | | | | | | | Closes #2494
* | Sanitize `vbscript:` linksrs-data-linksRobert Speicher2016-02-231-0/+7
| | | | | | | | Closes https://dev.gitlab.org/gitlab/gitlabhq/issues/2660
* | Sanitize `data:` linksRobert Speicher2016-02-211-1/+8
|/ | | | Closes #13625
* Fix specs expecting `emoji/` in image pathRobert Speicher2016-02-131-2/+2
|
* Make Pipelines responsible for defining their custom whitelistrs-whitelist-in-pipelineRobert Speicher2016-02-032-22/+37
| | | | | This allows for future pipelines to more easily define a custom whitelist.
* Increase the minimum length for commit SHA matching to 7rs-issue-12706Robert Speicher2016-01-291-2/+2
| | | | | | This is the git default and will help to prevent false positive matches. Closes #12706
* Whitelist raw "abbr" elements when parsing MarkdownBenedict Etzel2016-01-231-0/+5
| | | | Closes #12517
* Refactoring Banzai::Filter::GollumTagsFilterDouglas Barbosa Alexandre2016-01-141-4/+0
|
* Add Banzai::Filter::GollumTagsFilter for parsing Gollum's tags in HTMLDouglas Barbosa Alexandre2016-01-141-0/+93
|
* Add spec for single-item task listsrs-single-item-task-list-specRobert Speicher2016-01-071-0/+6
|
* Milestone reference is a Markdown linkmilestone-refDouwe Maan2016-01-071-1/+3
|
* Remove icon from milestone reference.Douwe Maan2016-01-051-2/+2
|
* Merge branch 'master' into milestone-refDouwe Maan2016-01-053-3/+37
|\
| * Merge branch 'rs-relative-links-to-root' into 'master' Douwe Maan2016-01-051-0/+8
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Support a single directory traversal in RelativeLinkFilter Prior, if we were viewing a blob at `https://example.com/namespace/project/blob/master/doc/some-file.md` and it contained a relative link such as `[README](../README.md)`, the resulting link when viewing the blob would be: `https://example.com/namespace/project/blob/README.md` which omits the `master` ref, resulting in a 404. Fixes https://gitlab.com/gitlab-org/release-tools/issues/3 See merge request !2247
| | * Support a single directory traversal in RelativeLinkFilterrs-relative-links-to-rootRobert Speicher2015-12-301-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | Prior, if we were viewing a blob at `https://example.com/namespace/project/blob/master/doc/some-file.md` and it contained a relative link such as `[README](../README.md)`, the resulting link when viewing the blob would be: `https://example.com/namespace/project/blob/README.md` which omits the `master` ref, resulting in a 404.
| * | Optimize CSS expressions produced by Nokogiriautocomplete-performanceYorick Peterse2015-12-311-0/+13
| |/ | | | | | | | | | | | | | | | | Nokogiri produces inefficient XPath expressions when given CSS expressions such as "a.gfm". Luckily these expressions can be optimized quite easily while still achieving the same results. In the two cases where this optimization is applied the run time has been reduced from around 170 ms to around 15 ms.
| * Only allow group/project members to mention `@all`Douwe Maan2015-12-241-3/+16
| |
* | Render milestone links as referencesDouwe Maan2015-12-241-0/+73
|/
* Move Markdown/reference logic from Gitlab::Markdown to BanzaiDouwe Maan2015-12-1520-0/+2235
View Lorry Controller Status