Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove leftover references to coffeescript from comments and docs.decaffeinate-the-docs | Bryce Johnson | 2016-10-31 | 1 | -1/+1 |
| | |||||
* | Do not allow text input in dropdown while loading | Ido Leibovich | 2016-10-28 | 1 | -14/+64 |
| | | | | While loading, the entire dropdown is greyed out. However, The focus is on the text input, so user can input text. Move the focus event to after loading finished to fix this. | ||||
* | Merge branch 'issue-board-welcome-cookie-monster' into 'master' | Robert Speicher | 2016-10-28 | 1 | -1/+4 |
|\ | | | | | | | | | | | | | | | | | | | | | Delete issue board welcome cookie ## What does this MR do? This was seen in the idea to production demo, because the project had already existed on the exact same URL the cookie already existed which meant the blank state wasn't shown. This MR deletes the cookie on project create. See merge request !6899 | ||||
| * | Fixed boards store specissue-board-welcome-cookie-monster | Phil Hughes | 2016-10-28 | 1 | -1/+4 |
| | | |||||
* | | Replace static issue fixtures by script (!6059) | winniehell | 2016-10-28 | 4 | -40/+63 |
| | | |||||
* | | Clean up issue_spec.js | winniehell | 2016-10-28 | 1 | -59/+102 |
|/ | |||||
* | Replaced jquery.cookie with js.cookie | Luke Bennett | 2016-10-27 | 1 | -1/+1 |
| | |||||
* | Enable linting for ES6 files | winniehell | 2016-10-27 | 2 | -0/+2 |
| | |||||
* | Merge branch 'add-todo-toggle-event' into 'master' remove-tooltip-text-truncation-from-pipeline-graph-build-node-tooltips | Fatih Acet | 2016-10-27 | 7 | -1/+198 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add todo toggle event ## What does this MR do? Adds a custom jQuery event `todo:toggle` to detect when a new todo is added so that the respective todo counters (header navigation and sidebar) can update as needed ## Are there points in the code the reviewer needs to double check? * I wasn't sure whether each `spec` should be modularized based on the html templates or whether they should be separated based on function. There are some crossovers between the `dashboard_spec` and the `header_spec`. * The naming conventions for `sidebar` and `right_sidebar` were a little confusing since they were named the opposite in their `specs`. I made a few assumptions and named a few files based on what I thought they should be named. I'd be happy to change it to something else though :smile: ## Why was this MR needed? This resolves an existing issue where the todo count on the sidebar would not update (until refresh) and refactors the existing methods that are used to update the todo counters (header navigation and sidebar) ## What are the relevant issue numbers? Closes #20140 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5724 | ||||
| * | Add todo toggle event | Clement Ho | 2016-10-26 | 7 | -1/+198 |
| | | |||||
* | | disable ESLint for all JavaScript files | winniehell | 2016-10-26 | 39 | -0/+39 |
| | | |||||
* | | Merge branch 'replace-jquery-cookie-plugin' into 'master' | Alfredo Sumaran | 2016-10-26 | 6 | -30/+7 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace jquery-cookie plugin with js-cookie ## What does this MR do? Removes an outdated and unmaintained dependency [jquery.cookie](https://github.com/carhartl/jquery-cookie) with its successor [js.cookie](https://github.com/js-cookie/js-cookie) which is not dependent on jQuery. Also this MR adds a global default cookie `path` setting which defaults to the GitLab root directory. Now, setting a cookie to any path other than `gon.relative_url_root` requires an explicit opt-out. This is a sensible default and should prevent accidental omission going forward. ## Are there points in the code the reviewer needs to double check? Double check that all instances of `$.cookie(x)` have been replaced by `Cookies.get(x)` and all instances of `$.cookie(x, y, z)` are replaced with `Cookies.set(x, y, z)`. All javascripts which set or retrieve cookie values should function just as before. ## Why was this MR needed? One more step toward shaking off jQuery as a dependency (#23022), also [jquery.cookie](https://github.com/carhartl/jquery-cookie) is no longer maintained and hasn't seen an update in 2+ years. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added - Tests - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? #23022 See merge request !7085 | ||||
| * | | remove manual Cookie.set "path" option in favor of global setting | Mike Greiling | 2016-10-24 | 1 | -23/+0 |
| | | | |||||
| * | | replace jquery.cookie vendor script with js.cookie | Mike Greiling | 2016-10-24 | 6 | -10/+10 |
| |/ | |||||
* | | Update gl_field_error tests for better input filtering.scope-input-errors | Bryce Johnson | 2016-10-20 | 1 | -2/+2 |
|/ | |||||
* | Add tests for gl_field_errors. | Bryce Johnson | 2016-10-15 | 2 | -0/+126 |
| | |||||
* | Make UX upgrades to SignIn/Register views. | Bryce Johnson | 2016-10-15 | 1 | -1/+1 |
| | | | | | | | - Tab between register and sign in forms - Add individual input validation error messages - Validate username - Update many styles for all login-box forms | ||||
* | Merge branch 'mr-tabs-affix' into 'master' | Fatih Acet | 2016-10-14 | 1 | -0/+1 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Merge request tabs stick when scrolling page ## What does this MR do? When scrolling merge requests this sticks the tabs to below the navigation for easy access. ## Screenshots (if relevant)  ## What are the relevant issue numbers? Closes #20548 See merge request !6382 | ||||
| * | Fixed merge request tab JS spec | Phil Hughes | 2016-10-06 | 1 | -0/+1 |
| | | |||||
* | | Fixed conflict and corrected teaspoon test | Luke Bennett | 2016-10-14 | 1 | -2/+3 |
| | | |||||
* | | Moved ci_status environments logic to new action ci_envrionments_status and ↵ | Luke Bennett | 2016-10-14 | 1 | -23/+37 |
| | | | | | | | | set up frontend polling | ||||
* | | Show what time ago a MR was deployed | Z.J. van de Weg | 2016-10-14 | 1 | -5/+22 |
| | | |||||
* | | Fixed JS tests | Phil Hughes | 2016-10-11 | 4 | -7/+7 |
| | | |||||
* | | Prevent conflict b/w search field and its dropdown | Brennan Roberts | 2016-10-10 | 1 | -1/+20 |
| | | | | | | | | | | | | | | | | | | Stop the global search form's default "action" from fighting with dropdown items when using the keyboard to navigate the dropdown. `e.preventDefault()` is now called on the enter key when a dropdown item is already selected. Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | | Fix inconsistent highlighting of already selected activity nav-links | Clement Ho | 2016-10-05 | 2 | -0/+82 |
|/ | |||||
* | Fix test for SearchAutocomplete. | Bryce Johnson | 2016-10-05 | 1 | -1/+1 |
| | |||||
* | Send ajax request for label update only if they are changed (#19472 !5071)label-update-check-new | Phil Hughes | 2016-09-27 | 1 | -7/+6 |
| | |||||
* | Merge branch 'add-remember-option-u2f' into 'master' | Robert Speicher | 2016-09-09 | 1 | -1/+1 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pass the remember_me option into the u2f form and support it while authenticating ## What does this MR do? Adds remember me support in the u2f authentication, and makes sure the flag gets passed from the login form to the u2f form. Based on the changes for the same thing done for regular 2fa: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4369 ## Why was this MR needed? The remember me option wasn't working for u2f devices (yubikey) ## What are the relevant issue numbers? Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/18103 See merge request !5918 | ||||
| * | Pass the remember_me option into the u2f form and support it while ↵add-remember-option-u2f | DJ Mountney | 2016-09-01 | 1 | -1/+1 |
| | | | | | | | | | | | | authenticating Matches the changes done for non-u2f two-factor auth | ||||
* | | Require comments must be included before code | Jared Deckard | 2016-09-08 | 1 | -5/+5 |
| | | |||||
* | | Restore comments lost when converting CoffeeScript to JavaScript | Jared Deckard | 2016-09-08 | 13 | -69/+48 |
| | | |||||
* | | Merge branch 'fix-textarea-expansion' into 'master' | Fatih Acet | 2016-09-07 | 2 | -12/+66 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add textarea autoresize after comment ## What does this MR do? Adds an autoresize after a comment is posted ## Are there points in the code the reviewer needs to double check? Shouldn't be ## Why was this MR needed? To keep the UI consistent (the same as if you were to refresh it) ## Screenshots (if relevant) Before:  After:  ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #21667 See merge request !6152 | ||||
| * | | Add textarea autoresize after comment | Clement Ho | 2016-09-01 | 2 | -12/+66 |
| | | | |||||
* | | | Convert datetime coffeescript spec to ES6 | Clement Ho | 2016-09-01 | 2 | -50/+64 |
| |/ |/| | |||||
* | | Merge branch 'issue-boards-issues-total-count' into 'master' | Fatih Acet | 2016-09-01 | 1 | -6/+9 |
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | Add the total number of issues in the JSON response in issue board lists ## What does this MR do? Add the total number of issues in the JSON response in issue board lists ## Why was this MR needed? The issue board lists should always show the total number of issues in the list, not the current amount fetched by endless scroll. Closes #21327 See merge request !5904 | ||||
| * | Shows count at bottom of list | Phil Hughes | 2016-08-31 | 1 | -6/+9 |
| | | | | | | | | Only visible when scrollable area is larger than height | ||||
* | | Merge branch 'improve-application_spec' into 'master' | Fatih Acet | 2016-08-31 | 1 | -3/+7 |
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Check for existance of elements under test in application_spec.js ## What does this MR do? Checks that the elements under test in `application_spec.js` actually exist. ## Why was this MR needed? ``` $ echo 'just garbage' > spec/javascripts/fixtures/application.html.haml $ bundle exec teaspoon spec/javascripts/application_spec.js 2 examples, 0 failures ``` See merge request !6051 | ||||
| * | Check for existence of elements under test in application_spec.js (!6051) | winniehell | 2016-08-26 | 1 | -3/+7 |
| | | |||||
* | | Added search for all lists on issue boards | Phil Hughes | 2016-08-30 | 1 | -9/+0 |
| | | | | | | | | Closes #21139 | ||||
* | | Merge branch 'reduce-contributions-calendar-payload' into 'master' | Jacob Schatz | 2016-08-26 | 1 | -0/+19 |
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reduce contributions calendar data payload ## What does this MR do? Reduces the contributions calendar data payload by only passing contribution dates and counts ## Are there points in the code the reviewer needs to double check? Please double check my javascript code :smiley: ## Why was this MR needed? Reduce user's bandwidth and decrease website loading time ## What are the relevant issue numbers? Closes #20862 ## Screenshots (if relevant) Before:  ``` new Calendar( {"1439269200":0,"1439355600":0,"1439442000":0,"1439528400":0,"1439614800":0,"1439701200":0,"1439787600":0,"1439874000":0,"1439960400":0,"1440046800":0,"1440133200":0,"1440219600":0,"1440306000":0,"1440392400":0,"1440478800":0,"1440565200":0,"1440651600":0,"1440738000":0,"1440824400":0,"1440910800":0,"1440997200":0,"1441083600":0,"1441170000":0,"1441256400":0,"1441342800":0,"1441429200":0,"1441515600":0,"1441602000":0,"1441688400":0,"1441774800":0,"1441861200":0,"1441947600":0,"1442034000":0,"1442120400":0,"1442206800":0,"1442293200":0,"1442379600":0,"1442466000":0,"1442552400":0,"1442638800":0,"1442725200":0,"1442811600":0,"1442898000":0,"1442984400":0,"1443070800":0,"1443157200":0,"1443243600":0,"1443330000":0,"1443416400":0,"1443502800":0,"1443589200":0,"1443675600":0,"1443762000":0,"1443848400":0,"1443934800":0,"1444021200":0,"1444107600":0,"1444194000":0,"1444280400":0,"1444366800":0,"1444453200":0,"1444539600":0,"1444626000":0,"1444712400":0,"1444798800":0,"1444885200":0,"1444971600":0,"1445058000":0,"1445144400":0,"1445230800":0,"1445317200":0,"1445403600":0,"1445490000":0,"1445576400":0,"1445662800":0,"1445749200":0,"1445835600":0,"1445922000":0,"1446008400":0,"1446094800":0,"1446181200":0,"1446267600":0,"1446354000":0,"1446444000":0,"1446530400":0,"1446616800":0,"1446703200":0,"1446789600":0,"1446876000":0,"1446962400":0,"1447048800":0,"1447135200":0,"1447221600":0,"1447308000":0,"1447394400":0,"1447480800":0,"1447567200":0,"1447653600":0,"1447740000":0,"1447826400":0,"1447912800":0,"1447999200":0,"1448085600":0,"1448172000":0,"1448258400":0,"1448344800":0,"1448431200":0,"1448517600":0,"1448604000":0,"1448690400":0,"1448776800":0,"1448863200":0,"1448949600":0,"1449036000":0,"1449122400":0,"1449208800":0,"1449295200":0,"1449381600":0,"1449468000":0,"1449554400":0,"1449640800":0,"1449727200":0,"1449813600":0,"1449900000":0,"1449986400":0,"1450072800":0,"1450159200":0,"1450245600":0,"1450332000":0,"1450418400":0,"1450504800":0,"1450591200":0,"1450677600":0,"1450764000":0,"1450850400":0,"1450936800":0,"1451023200":0,"1451109600":0,"1451196000":0,"1451282400":0,"1451368800":0,"1451455200":0,"1451541600":0,"1451628000":0,"1451714400":0,"1451800800":0,"1451887200":0,"1451973600":0,"1452060000":0,"1452146400":0,"1452232800":0,"1452319200":0,"1452405600":0,"1452492000":0,"1452578400":0,"1452664800":0,"1452751200":0,"1452837600":0,"1452924000":0,"1453010400":0,"1453096800":0,"1453183200":0,"1453269600":0,"1453356000":0,"1453442400":0,"1453528800":0,"1453615200":0,"1453701600":0,"1453788000":0,"1453874400":0,"1453960800":0,"1454047200":0,"1454133600":0,"1454220000":0,"1454306400":0,"1454392800":0,"1454479200":0,"1454565600":0,"1454652000":0,"1454738400":0,"1454824800":0,"1454911200":0,"1454997600":0,"1455084000":0,"1455170400":0,"1455256800":0,"1455343200":0,"1455429600":0,"1455516000":0,"1455602400":0,"1455688800":0,"1455775200":0,"1455861600":0,"1455948000":0,"1456034400":0,"1456120800":0,"1456207200":0,"1456293600":0,"1456380000":0,"1456466400":0,"1456552800":0,"1456639200":0,"1456725600":0,"1456812000":0,"1456898400":0,"1456984800":0,"1457071200":0,"1457157600":0,"1457244000":0,"1457330400":0,"1457416800":0,"1457503200":0,"1457589600":0,"1457676000":0,"1457762400":0,"1457848800":0,"1457931600":0,"1458018000":0,"1458104400":0,"1458190800":0,"1458277200":0,"1458363600":0,"1458450000":0,"1458536400":0,"1458622800":0,"1458709200":0,"1458795600":0,"1458882000":0,"1458968400":0,"1459054800":0,"1459141200":0,"1459227600":0,"1459314000":0,"1459400400":0,"1459486800":0,"1459573200":0,"1459659600":0,"1459746000":0,"1459832400":0,"1459918800":0,"1460005200":0,"1460091600":0,"1460178000":0,"1460264400":0,"1460350800":0,"1460437200":0,"1460523600":0,"1460610000":0,"1460696400":0,"1460782800":0,"1460869200":0,"1460955600":0,"1461042000":0,"1461128400":0,"1461214800":0,"1461301200":0,"1461387600":0,"1461474000":0,"1461560400":0,"1461646800":0,"1461733200":0,"1461819600":0,"1461906000":0,"1461992400":0,"1462078800":0,"1462165200":0,"1462251600":0,"1462338000":0,"1462424400":0,"1462510800":0,"1462597200":0,"1462683600":0,"1462770000":0,"1462856400":0,"1462942800":0,"1463029200":0,"1463115600":0,"1463202000":0,"1463288400":0,"1463374800":0,"1463461200":0,"1463547600":0,"1463634000":0,"1463720400":0,"1463806800":0,"1463893200":0,"1463979600":0,"1464066000":0,"1464152400":0,"1464238800":0,"1464325200":0,"1464411600":0,"1464498000":0,"1464584400":0,"1464670800":0,"1464757200":0,"1464843600":0,"1464930000":0,"1465016400":0,"1465102800":0,"1465189200":0,"1465275600":0,"1465362000":0,"1465448400":0,"1465534800":0,"1465621200":0,"1465707600":0,"1465794000":0,"1465880400":0,"1465966800":0,"1466053200":0,"1466139600":0,"1466226000":0,"1466312400":0,"1466398800":0,"1466485200":0,"1466571600":0,"1466658000":0,"1466744400":0,"1466830800":0,"1466917200":0,"1467003600":0,"1467090000":0,"1467176400":0,"1467262800":0,"1467349200":0,"1467435600":0,"1467522000":0,"1467608400":0,"1467694800":0,"1467781200":0,"1467867600":0,"1467954000":0,"1468040400":0,"1468126800":0,"1468213200":0,"1468299600":0,"1468386000":0,"1468472400":0,"1468558800":0,"1468645200":0,"1468731600":0,"1468818000":0,"1468904400":0,"1468990800":0,"1469077200":0,"1469163600":17,"1469250000":0,"1469336400":0,"1469422800":3,"1469509200":14,"1469595600":54,"1469682000":0,"1469768400":4,"1469854800":1,"1469941200":0,"1470027600":0,"1470114000":0,"1470200400":1,"1470286800":0,"1470373200":1,"1470459600":0,"1470546000":0,"1470632400":0,"1470718800":0,"1470805200":0,"1470891600":2}, '/u/root/calendar_activities' ); ``` After:  ``` new Calendar( {"1469163600":17,"1469422800":3,"1469509200":14,"1469595600":54,"1469768400":4,"1469854800":1,"1470200400":1,"1470373200":1,"1470891600":2}, '/u/root/calendar_activities' ); ``` ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5784 | ||||
| * | Reduce contributions calendar data payload | Clement Ho | 2016-08-25 | 1 | -0/+19 |
| | | |||||
* | | Add hover color to emoji icon | Clement Ho | 2016-08-25 | 1 | -1/+1 |
| | | |||||
* | | use gitlab global root url as canonical base url for all javascript set ↵ | Mike Greiling | 2016-08-24 | 1 | -2/+30 |
|/ | | | | cookies (closes #20435) | ||||
* | expose 'only_allow_merge_if_build_succeeds' project setting in the API | Marc Dequènes (Duck) | 2016-08-24 | 1 | -1/+1 |
| | |||||
* | Merge branch 'lbennett/gitlab-ce-17465-search-for-project-with-cursor-keys' ↵ | Jacob Schatz | 2016-08-19 | 3 | -4/+139 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' 17465 Fixed dropdown cursor key navigation ## What does this MR do? This MR fixes the use of cursor/arrow/enter key events with search dropdowns, allowing a user to navigate up and down the list with the arrow keys and then select their item with the enter key. It also applies some *minor* scroll user experience fixes, such as resetting the selected dropdown item every time it opens/closes (also stops multiple dropdowns conflicting) and forcing the dropdown scroll to scroll right to the top or bottom depending on whether they have selected the first or last item, respectively. ## Are there points in the code the reviewer needs to double check? I would like someone with GitLab experience to check over whether this would harm any unique implementations of the GitLabDropdown or SearchAutocomplete. ## Why was this MR needed? The current version has incorrectly behaving search dropdowns in the navbar, they either do not navigate using the keyboard or do not use the enter keystroke to select a highlighted item. ## What are the relevant issue numbers? Fixes #17465. Closes #20752. Closes #21014. **Contributes** to #20754. ## Screenshots (if relevant)  See merge request !4781 | ||||
| * | Fixed conflicts | Luke Bennett | 2016-08-18 | 1 | -2/+2 |
| | | |||||
| * | Fixed specs | Luke Bennett | 2016-08-18 | 1 | -4/+4 |
| | | |||||
| * | Fixed spec and improved formatting | Luke Bennett | 2016-08-18 | 1 | -28/+25 |
| | | |||||
| * | Improved spec, waiting on sprockets-es6 to work with rspec.... | Luke Bennett | 2016-08-18 | 1 | -92/+94 |
| | | |||||
| * | Moved changes across to es5 and changed spec to es6 | Luke Bennett | 2016-08-18 | 2 | -97/+120 |
| | |