summaryrefslogtreecommitdiff
path: root/spec/javascripts
Commit message (Collapse)AuthorAgeFilesLines
* fix eslint for spec global needed in pagination spec for 'fixture'auto-pipelines-vueRegis2017-01-091-0/+1
|
* Merge branch 'master' into auto-pipelines-vueRegis2017-01-0946-104/+635
|\
| * Merge branch ↵Alfredo Sumaran2017-01-0643-103/+590
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | '26226-generate-all-haml-fixtures-within-teaspoon-fixtures-task' into 'master' Precompile all frontend test fixtures Closes #26226 See merge request !8384
| | * fix right_sidebar_spec ajax call26226-generate-all-haml-fixtures-within-teaspoon-fixtures-taskMike Greiling2017-01-051-1/+2
| | |
| | * replace Teaspoon fixture methods with jasmine-jquery methods to reduce ↵Mike Greiling2017-01-0541-97/+108
| | | | | | | | | | | | dependency on Teaspoon
| | * Merge branch 'fix-u2f-fixtures' into ↵Mike Greiling2017-01-053-22/+34
| | |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 26226-generate-all-haml-fixtures-within-teaspoon-fixtures-task * fix-u2f-fixtures: generate u2f frontend fixtures dynamically force utf-8 encoding for prior to fixture parsing to prevent nokogiri issues exclude script type=text/template from dom scrubbing
| | * | make projects.json easier to readMike Greiling2017-01-031-1/+445
| | | |
| | * | fix dynamic u2f fixturesMike Greiling2017-01-035-5/+37
| | | |
| | * | update all frontend tests to point to precompiled fixturesMike Greiling2017-01-0328-54/+54
| | | |
| | * | create catch-all fixture generator for all static fixturesMike Greiling2017-01-031-0/+31
| | | |
| * | | Merge branch 'fix-u2f-fixtures' into 'master' Alfredo Sumaran2017-01-055-5/+49
| |\ \ \ | | | |/ | | |/| | | | | | | | | Replace static JavaScript fixtures for u2f See merge request !8426
| | * | generate u2f frontend fixtures dynamicallyMike Greiling2017-01-055-5/+49
| | |/
* | | move param helper to common utilsRegis2017-01-091-0/+1
| | |
* | | namespace getParametersByName to gl.utils instead of just glRegis2017-01-091-4/+4
| | |
* | | Merge branch 'master' into auto-pipelines-vueFilipa Lacerda2017-01-053-50/+8
|\ \ \ | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (35 commits) Adds back removed class in merge request pipelines table Fix dropdown icon alignment Simplify HTML of mini pipeline graph and dropdown Creates individual html for dropdown Adds simplified CSS for the new dropdown Removes old CSS Improves dropdown item in Chrome, Firefox and Safari Use SCSS variables for colors. Fix scss linter errors Adds animation when the stage is hovered. Adds back tooltip on dropdown toggle Fixes broken tests additional css changes to get more into direction of mockups Adds CHANGELOG entry Removes unneeded `window` declaration Decreases font-size on login page Ensure internal Gitlab::Git references use the namespace Absorb gitlab_git Fix review comments. Add spec for note edit and fix one commented spec. Review fixes. Use gl.utils.isInViewport and improve gl.utils.animateToElement. Make sure elements share the same scope Hide edit warning element when form reverted. Remove unnecessary styling came from merge conflicts. Fix single note edit form specs. Separate edit form in Changes and Discussions tab. Fix warning styling for responsive design. Fix task list for single edit note widget changes. Fix notes spec. ...
| * | Merge branch 'single-edit-comment-widget-2' into 'master' Alfredo Sumaran2017-01-052-7/+8
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | Refactor discussion edit widget to have only one at a time. Closes #23227 See merge request !8356
| | * | Use gl.utils.isInViewport and improve gl.utils.animateToElement.Fatih Acet2017-01-041-1/+1
| | | |
| | * | Make sure elements share the same scopeAlfredo Sumaran2017-01-041-6/+6
| | | | | | | | | | | | | | | | Since there are multiple instances of text editors on the current fixture file we will use the one that creates a comment.
| | * | Fix single note edit form specs.Fatih Acet2017-01-041-0/+1
| | |/
| * | Removes CustomEvent polyfill and testsremove-custom-event-polyfillFilipa Lacerda2017-01-021-43/+0
| |/
* | fix pipelines/index.html.haml merge conflictRegis2017-01-023-12/+14
|\ \ | |/
| * Merge branch '18556-polish-up-the-u2f-flow' into 'master' 26172-stages-icons-on-pipelines-page-skewedFatih Acet2016-12-301-11/+12
| |\ | | | | | | | | | | | | | | | | | | Improved the u2f flow Closes #18556 See merge request !8304
| | * Improved the u2f flow18556-polish-up-the-u2f-flowLuke "Jared" Bennett2016-12-271-11/+12
| | | | | | | | | | | | Added tests
| * | Merge branch '18786-go-to-a-project-order' into 'master' Alfredo Sumaran2016-12-272-1/+2
| |\ \ | | |/ | |/| | | | | | | | | | | | | Go to a project order Closes #18786 See merge request !7737
| | * Go to a project orderJacopo2016-12-152-1/+2
| | | | | | | | | | | | The order of "Go to a project" dropdown is based on last_activity_at
* | | merge master and fix application.rb conflictRegis2016-12-232-0/+89
|\ \ \ | |/ /
| * | Maintain milestone filter option when updating filter25561-maintain-milestone-filter-paramSam Rose2016-12-212-0/+89
| | | | | | | | | | | | Setup teaspoon tests for Issuable
* | | Merge branch 'master' into auto-pipelines-vueGrzegorz Bizon2016-12-213-5/+63
|\ \ \ | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (367 commits) Set “Remove branch” button to default size remove unused helper method reduce common code even further to satisfy rake flay remove button class size alteration from revert and cherry pick links factor out common code to satisfy rake flay homogenize revert and cherry-pick button styles generated by commits_helper apply margin on alert banners only when there is one or more alerts Rename MattermostNotificationService back to MattermostService Rename SlackNotificationService back to SlackService Fix stage and pipeline specs and rubocop offenses Added QueryRecorder to test N+1 fix on Milestone#show Use gitlab-workhorse 1.2.1 Make 'unmarked as WIP' message more consistent Improve specs for Files API Allow unauthenticated access to Repositories Files API GET endpoints Add isolated view spec for pipeline stage partial Move test for HTML stage endpoint to controller specs Fix sizing of avatar circles; add border Fix broken test Fix broken test Changes after review ... Conflicts: app/assets/stylesheets/pages/pipelines.scss app/controllers/projects/pipelines_controller.rb app/views/projects/pipelines/index.html.haml spec/features/projects/pipelines/pipelines_spec.rb
| * | Adds tests for the MiniPipelineGraph classFilipa Lacerda2016-12-202-0/+59
| | |
| * | Make CI badge hitboxes better match containerMitchell Hentges2016-12-191-5/+4
| | |
* | | add paramHelper testsRegis2016-12-161-0/+22
| | |
* | | Merge branch 'master' into auto-pipelines-vueRegis2016-12-164-34/+72
|\ \ \ | |/ /
| * | Merge branch 'abuse_report-fixture' into 'master' Kamil Trzciński2016-12-163-34/+47
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace static fixture for abuse_reports_spec ## What does this MR do? Replace static HAML fixture for `abuse_reports_spec` by dynamically created one. ## What are the relevant issue numbers? #24753 See merge request !7644
| | * | Replace static fixture for abuse_reports_spec (!7644)winniehell2016-12-153-34/+47
| | | |
| * | | Merge branch 'add-object-assign-polyfill' into 'master' Fatih Acet2016-12-151-0/+25
| |\ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | Add Object.assign polyfill Because PhantomJS See merge request !8090
| | * | Add Object.assign polyfillAlfredo Sumaran2016-12-141-0/+25
| | | |
* | | | change test to reflect camelCase methodRegis2016-12-151-6/+6
| | | |
* | | | Merge branch 'master' into auto-pipelines-vueGrzegorz Bizon2016-12-1530-31/+129
|\ \ \ \ | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (73 commits) Remove pages/snippets css Remove unused bootstrap imports Shift emojis and icons styles into framework Introduce deployment services, starting with a KubernetesService Username exists check respects the relative root URL add node_modules to our eslintignore settings Remove white space between nav items fix transient timing failure adding timecop Improve build status specs contexts descriptions Add some missing tests for detailed status methods Fix wrong error message expectation in API::Commits spec resolve all instances of no-undef eslint rule violations Remove trailing blank line from Allowable module expand remaining non-explicit eslint-disable blocks and factor ... Introduce $CI_BUILD_REF_SLUG Finish refactoring grays Combining more grays Remove duplicate shades of gray and black Encode when migrating ProcessCommitWorker jobs Prevent overflow with vertical scroll when we have space to show ... ...
| * | | Merge branch 'clean-no-undef' into 'master' Alfredo Sumaran2016-12-1529-31/+86
| |\ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Explicitly declare all javascript globals and all eslint rule violations This merge request takes every single external global variable referenced within a javascript file and explicitly marks it with a `/* global Foo */` comment block at the top of the script. This also expands all blanket instances of `/* eslint-disable */` with an explicit list of disabled rules. This is useful because if we need to search for violations of a particular rule we can simply grep the codebase for something like `no-unused-vars` or `semi` and find all of the places where this rule has yet to be fixed. Lastly, it also removes and resolves any existing `no-undef` eslint violations. This is useful for catching mistakes like forgetting to declare a variable with `var`/`let`/`const` which can cause hard to find bugs. ## What does this MR do? 1. Looks for generic uses of `/* eslint-disable */` and refactors them into individual rule exceptions. 2. Looks for all occurrences of `/* eslint-disable ... no-undef */` and resolves them by either fixing bugs or declaring globals with `/* global Foo */`. ## Are there points in the code the reviewer needs to double check? This touches a lot of files, most changes touch nothing other than comment blocks or whitespace. The exceptions are the following 14 files which required some small bug fixes after removing `no-undef`: - api.js - breakpoints.js - build.js - commits.js - diff_notes/components/jump_to_discussion.js.es6 - gfm_auto_complete.js.es6 - gl_dropdown.js - groups_select.js - importer_status.js - namespace_select.js - notes.js - preview_markdown.js - projects_list.js - single_file_diff.js ## Why was this MR needed? Removal of ~"technical debt" and some necessary changes to help !7288 ## Screenshots (if relevant) N/A ## Does this MR meet the acceptance criteria? - [ ] ~~[Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added~~ - [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - [ ] ~~API support added~~ - Tests - [ ] ~~Added for this feature/bug~~ - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? N/A See merge request !8043
| | * | resolve all instances of no-undef eslint rule violationsclean-no-undefMike Greiling2016-12-1417-18/+46
| | | |
| | * | expand remaining non-explicit eslint-disable blocks and factor out globals ↵Mike Greiling2016-12-1313-14/+41
| | |/ | | | | | | | | | when no-undef encountered
| * | Merge branch '24927-custom-event-polyfill-test' into 'master' Alfredo Sumaran2016-12-141-0/+43
| |\ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds tests for Custom Event polyfill ## What does this MR do? Adds tests for CustomEvent polyfill. ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #24927 See merge request !7996
| | * Fix broken test in chrome24927-custom-event-polyfill-testFilipa Lacerda2016-12-131-3/+3
| | |
| | * Fix broken testFilipa Lacerda2016-12-091-3/+3
| | |
| | * Adds tests for Custom Event polyfillFilipa Lacerda2016-12-081-0/+43
| | | | | | | | | | | | Update changelog with MR ID
* | | merge masterRegis2016-12-137-71/+94
|\ \ \ | |/ /
| * | Merge branch 'awards_handler-fixture' into 'master' Alfredo Sumaran2016-12-132-57/+5
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace static fixture for awards_handler_spec ## What does this MR do? Use the already existing dynamic fixture `issues/open-issue.html` (!6059) in `awards_handler_spec.js` instead of the static fixture `awards_handler.html.haml`. ## What are the relevant issue numbers? #24753 See merge request !7661
| | * | Replace static fixture for awards_handler_spec (!7661)winniehell2016-12-122-57/+5
| | | |
| * | | Merge branch 'fix-eslint-warnings' into 'master' Alfredo Sumaran2016-12-131-7/+9
| |\ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed lint warning and propose fail or warning ## What does this MR do? 1. Fixes a linter warning that is currently on `master`. 2. Proposes the use of `--max-warnings 0` with `eslint` to make sure the CI build fails on any warnings. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? See merge request !8025
| | * | Fixed lint warning and propose fail or warningfix-eslint-warningsLuke "Jared" Bennett2016-12-101-7/+9
| | | |
View Lorry Controller Status