| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Cached markdown version is composed both from global and local
markdown version. This allows admins to bump version locally when
needed (e.g. when external URL is changed).
|
| |\
| |
| |
| |
| | |
Convert note_app_spec.js to Vue test utils
See merge request gitlab-org/gitlab-ce!24900
|
| | | |
|
| |/ |
|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| |
| |
| | |
'master'
Refactor/56369 extract jump to next discussion button
Closes #56369
See merge request gitlab-org/gitlab-ce!24506
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
own component
fix #56369
chore(changelog): Added changelog entry
chore(prettier): Formated with prettier
test(JumpToNextDiscussionButton): Added test for new component
test(Refactored tests to use vue test-utils):
chore(translations): Added newly generated locales
Update spec/javascripts/notes/components/discussion_jump_to_next_button_spec.js
chore(prettier): Formated with prettier
test(JumpToNextDiscussionButton): Updated tests to use a local vue instance
test(JumpToNextDiscussionButton): Running tests in async to prevent maximum stack overflow
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Bump CI image to use Chrome 71.0 and Golang 1.11
Closes #56614 and #55578
See merge request gitlab-org/gitlab-ce!24572
|
| | |/
| |
| |
| |
| |
| | |
To me it seems like the mock data does not match the actual data
anymore. I checked the actual data and to me it seems like the resolved
property actually should live in the overall discussion object.
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
Before, diff file `higlighted_diff_lines`/`parallel_diff_lines` and
diff discussion `truncated_diff_lines` were inconsistent: `text` and
`rich_text` on the latter included the leading +/-/<space> character,
like on the backend, while the former had no `text` and its `rich_text`
had dropped this char.
This resulted in a bug when the suggestions feature expected these diff
line objects to be identical in format and thus interchangeable, which
was not the case.
|
| | |
|
| |
|
|
|
| |
Removed the button and associated tests form notes
on Issues and Merge request page.
|
| |
|
|
|
|
|
| |
Discussion filters will be hidden on Commits, Pipelines, and
Changes tabs on merge requests page.
This does not affect its behavior on issues page
|
| |
|
|
|
|
| |
Fixes a bug where merge request comments made
in the context of a specific commit no longer specify
which commit they were created on
|
| |\
| |
| |
| |
| |
| |
| | |
Fixed emoji awards not being added to notes
Closes #55141
See merge request gitlab-org/gitlab-ce!23720
|
| | |
| |
| |
| | |
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55141
|
| | | |
|
| |/
|
|
|
|
|
|
|
| |
**What was the issue?**
Notes can be unresolved, but not resolvable. Without this, the
unresolvedDiscussionsCount was inflated.
**References**
https://gitlab.com/gitlab-org/gitlab-ce/issues/55138
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53600
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Improve the renderign of new and existing discussions
by reducing the number of watchers on each object & array.
Previously every discussion change would trigger an update for every
discussion component.
Also tidied up some components to get them closer to our docs.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51506
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
This caused many pain points when working with it.
Part of the data was camel cased the other snake case.
Other parts where snake case & then getting converted in components,
this conversion has the potential for leaking memory.
This changes that & makes it consistent with what it returned from the
API, snake case.
|
| | |
|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Re-implemented image commenting on diffs
Closes #48956
See merge request gitlab-org/gitlab-ce!22443
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This re-implements image commenting in merge request diffs.
This feature was previously lost when the merge request
page was refactored into Vue.
With this, we create an overlay component. The overlay
component handles displaying the comment badges
and the comment form badge.
Badges are displayed based on the position attribute
sent with the discussion.
Comment forms for diff files are controlled through
a different state property. This is so we don't
tie comment forms to diff files directly creating
deep nested state. Instead we create a flat array
which holds the file hash & the X & Y position of
the comment form.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
|
| |/ |
|
| |\
| |
| |
| |
| | |
Fix typos in comments and specs
See merge request gitlab-org/gitlab-ce!22683
|
| | | |
|
| |/ |
|
| |
|
|
| |
requests"
|
| | |
|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Fix MR discussion not loaded issue
Closes #51958
See merge request gitlab-org/gitlab-ce!21982
|
| | |
| |
| |
| |
| |
| | |
Display `formatter` as the sole content of `position` object.
This means `diff_file` data is not referenced, which is the
caseu of "IOError: not opened for reading".
|
| |/ |
|
| | |
|
| |\
| |
| |
| |
| | |
Fixed MR widget unresolved discussions state
See merge request gitlab-org/gitlab-ce!21705
|
| | |
| |
| |
| |
| | |
Instead of relying on a global method, we now emit an event on the MR
widget that tells it to check the status
|
| | |
| |
| |
| |
| |
| |
| |
| | |
After resolving a discussion on a merge request page the merge request
widget state would not get updated meaning users would need to refresh
the page to merge (if that option is enabled in the projects settings)
https://gitlab.com/gitlab-org/gitlab-ce/issues/42882
|
| |/
|
|
| |
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51370
|
| | |
|
