| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53019
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This caused many pain points when working with it.
Part of the data was camel cased the other snake case.
Other parts where snake case & then getting converted in components,
this conversion has the potential for leaking memory.
This changes that & makes it consistent with what it returned from the
API, snake case.
|
|
|
|
|
|
|
| |
This fixes files that are collapsed by default not expanding
when the expand all button is clicked.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53866
|
|\
| |
| |
| |
| |
| |
| | |
Comment on any expanded diff line on MRs (with feature-flag)
Closes #13950
See merge request gitlab-org/gitlab-ce!22914
|
| | |
|
|/
|
|
|
|
|
| |
Previously it was using name which could make it hard
to filter for the file you want in a certain folder.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53781
|
|
|
|
|
| |
This reverts commit a82a595728d54bdc12e51dfcfb22e9eddc449143, reversing
changes made to e7df959b8f99875edd246c7ac7779c3203e8755e.
|
|
|
|
|
|
|
|
| |
This restores the behaviour of showing the expand all button on diffs
even when only a single file is collapsed.
Previously the button would only show when all files are collapsed.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51737
|
|\
| |
| |
| |
| | |
Comment on any expanded diff line on MRs
See merge request gitlab-org/gitlab-ce!22398
|
| | |
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This re-implements image commenting in merge request diffs.
This feature was previously lost when the merge request
page was refactored into Vue.
With this, we create an overlay component. The overlay
component handles displaying the comment badges
and the comment form badge.
Badges are displayed based on the position attribute
sent with the discussion.
Comment forms for diff files are controlled through
a different state property. This is so we don't
tie comment forms to diff files directly creating
deep nested state. Instead we create a flat array
which holds the file hash & the X & Y position of
the comment form.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bug where a discussion on a none changed line
would not get fully removed and therefore leave the comment row
empty. This was caused by the discussiob being added
to the right when it shouldnt of been
This also fixes a very rare edge case where discussions would get added
twice to diff lines causing a Vue rendering warning
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53317
|
| |
|
| |
|
|
|
|
| |
Pre-request to https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
|
|
|
|
| |
Added tests to file row truncated text computed prop
|
|
|
|
|
|
|
|
|
|
|
| |
This adds toggle buttons to switch between file & tree list.
For file list, it renders the truncated paths with the ellipsis
at the start of the path.
When focusing the input, it hides the toggle buttons.
On blur, the buttons get shown again.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51859
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Add signature badge and pipeline status to commit details in MR diff
Closes #49329
See merge request gitlab-org/gitlab-ce!22079
|
| |
| |
| |
| |
| | |
**Notes:**
- Also exposes commit.pipeline_status_path in diffs.json
|
| |
| |
| |
| |
| | |
**Notes:**
- Also exposes commit.signature_html in diffs.json
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix MR discussion not loaded issue
Closes #51958
See merge request gitlab-org/gitlab-ce!21982
|
| | |
| | |
| | |
| | |
| | |
| | | |
Display `formatter` as the sole content of `position` object.
This means `diff_file` data is not referenced, which is the
caseu of "IOError: not opened for reading".
|
|\ \ \
| |_|/
|/| |
| | |
| | |
| | |
| | | |
Fix showing diff file header for renamed files
Closes #48887
See merge request gitlab-org/gitlab-ce!22089
|
| |/ |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This file tree displays all the diff files in a tree like format
Each file is taken and converted into a tree with folders
Each folder can be toggled open & closed
Clicking a file will scroll to the diff file & highlight with a glow affect
Searching the tree list will search only files & return a list of the
files without any folders
Each file row contains an icon to show changed, new file or deleted
Each row will also contain the added & removed lines count
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14249
|
| |
|
| |
|
|
|
|
| |
Fixed toBeTruthy to toBe(true) in spec
|
|
|
|
| |
Fixed toggling new notes caused by not returning the stores discussion
|
|
|
|
|
|
|
| |
We now use the returned discussion instead of re-fetching
all of the discussions and filtering out the ones we don't need.
This speeds up the process of creating a diff discussions
by saving us another API request before we can render the discussion
|
|
|
|
| |
after incremental rendering improvement"
|
| |
|
|
|
|
| |
It now tests for the latest diff check
|
| |
|
|
|
|
| |
Un-commented out expect checks in mutation spec
|
|
|
|
| |
Updated diff mutations and utils spec to check for legacy notes
|
|
|
|
| |
functions
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
Vue MR Page - Data structure update
See merge request gitlab-org/gitlab-ce!21062
|
| |
| |
| |
| | |
always against state
|
| | |
|