| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Prevent URL concatenation for avatars
Closes #38189
See merge request gitlab-org/gitlab-ce!14437
|
| | | |
|
| |/
|
|
|
| |
This was caused by the `@projects` value being empty when the current
user does not have any personal projects.
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Fixes project denial of service via gitmodules using Extended ASCII.
Closes #34259
See merge request gitlab-org/gitlab-ce!14301
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
'37576-renamed-files-have-escaped-html-for-the-inline-diff-in-the-header' into 'master'
Resolve "Renamed files have escaped HTML for the inline diff in the header"
Closes #37576
See merge request gitlab-org/gitlab-ce!14121
|
| | | |
| | |
| | |
| | | |
updated the spec
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Extends the helper method to no show the banner as soon as the project
has a `.gitlab-ci.yml` file on the default branch.
Fixes gitlab-org/gitlab-ce#37652
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Allow all AutoDevOps banners to be disabled
Closes #37653
See merge request !14218
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | | |
Given the default in the development and production environment is
false, the negation of enabling is used in the flag to signal you'd turn
it off. It reads a bit awkward, but makes us have a migration less.
Fixes gitlab-org/gitlab-ce#37653
|
| |/ /
| |
| | |
This reverts merge request !14148
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Rework how recent push events are retrieved
Closes #35990
See merge request !13995
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Whenever you push to a branch GitLab will show a button to create a
merge request (should one not exist already). The underlying code to
display this data was quite inefficient. For example, it involved
multiple slow queries just to figure out what the most recent push event
was.
This commit changes the way this data is retrieved so it's much faster.
This is achieved by caching the ID of the last push event on every push,
which is then retrieved when loading certain pages. Database queries are
only executed if necessary and the cached data is removed automatically
once a merge request has been created, or 2 hours after being stored.
A trade-off of this approach is that we _only_ track the last event.
Previously if you were to push to branch A and B then create a merge
request for branch B we'd still show the widget for branch A. As of this
commit this is no longer the case, instead we will only show the widget
for the branch you pushed to most recently. Once a merge request exists
the widget is no longer displayed. Alternative solutions are either too
complex and/or too slow, hence the decision was made to settle for this
trade-off.
Performance Impact
------------------
In the best case scenario (= a user didn't push anything for more than 2
hours) we perform a single Redis GET per page. Should there be cached
data we will run a single (and lightweight) SQL query to get the
event data from the database. If a merge request already exists we will
run an additional DEL to remove the cache key.
The difference in response timings can vary a bit per project. On
GitLab.com the 99th percentile of time spent in User#recent_push hovers
between 100 milliseconds and 1 second, while the mean hovers around 50
milliseconds. With the changes in this MR the expected time spent in
User#recent_push is expected to be reduced down to just a few
milliseconds.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/35990
|
| | |
| |
| |
| |
| | |
'35012-navigation-add-option-to-change-navigation-color-palette' into 'master'"
This reverts merge request !13619
|
| |/
|
|
|
| |
[9.5] Prevent a persistent XSS in the commit author block
See merge request gitlab/gitlabhq!2180
|
| |\
| |
| |
| |
| |
| |
| | |
Improve "Share with group lock" feature for subgroups
Closes #30550
See merge request !13944
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Resolve "Banner to enable Auto DevOps at project level"
Closes #37158
See merge request !13991
|
| | |\ \ |
|
| | |\ \ \
| | | | |
| | | | |
| | | | | |
37158-autodevops-banner
|
| | | |_|/
| |/| | |
|
| |\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
'master'
Decrease Cyclomatic Complexity threshold to 14
See merge request !13972
|
| | | | |
| | | |
| | | |
| | | | |
`app/helpers/projects_helper.rb`
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | |/
| |/| |
|
| |\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | | |
'35012-navigation-add-option-to-change-navigation-color-palette' into 'master'
Add option to change navigation color palette
Closes #35012
See merge request !13619
|
| | | | |
|
| | | | |
|
| | | | |
|
| | |/ |
|
| |/ |
|
| |\
| |
| |
| |
| |
| |
| |
| |
| | |
'34509-improves-markdown-rendering-performance-for-commits-list' into 'master'
Resolve "Projects::CommitsController#show is slow partially due to SQL queries"
Closes #34509
See merge request !13762
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
First time contributor badge
Closes #35161
See merge request !13902
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
this will remove the need make N queries (per-note) at the
cost of having to mark notes with an attribute
this opens up the possibility for other special roles for notes
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| | |
a new badge will be added when an user that doesn't yet
have any merged merge request is discussing on either issues or
merge requests that he created.
this is indented for people to use extra care when discussing with
a new contributor.
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix division by zero for blame age map
Closes #35441
See merge request !13803
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Profile updates from providers
See merge request !12968
|
| | | |/
| |/| |
|
