summaryrefslogtreecommitdiff
path: root/spec/helpers
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch '82-add-new-onboarding-to-flipper-a-b-testing' into 'master'Nick Thomas2019-07-011-0/+38
|\ | | | | | | | | Add new onboarding to flipper A/B testing See merge request gitlab-org/gitlab-ce!30125
| * Add new OnboardingExperimentHelper modulesAsh McKenzie2019-06-281-0/+38
| | | | | | | | | | | | OnboardingExperimentHelpers take care of determining if the current_user should or should not see the new onboarding feature.
* | Fix attachments using the wrong URLs in e-mailssh-fix-issue-63910Stan Hu2019-06-281-0/+37
|/ | | | | | | | | | | | | | | | | | | | | Prior to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29889, only the project context were set for the Markdown renderer. For a note on an issuable, the group context was set to `nil` because `note.noteable.try(:group)` attempted to get the issuable's group, which doesn't exist. To make group notifications work, now both the project and group context are set. The context gets passed to `RelativeLinkFilter`, which previously assumed that it wasn't possible to have both a group and a project in the Markdown context. However, if a group were defined, it would take precedence, and the URL rendered for uploads would be `/group/-/uploads` instead of `/group/project/uploads/`. This led to 404s in e-mails. However, now that we have both project and group in the context, we render the Markdown giving priority to the project context if is set. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63910
* New RecaptchaExperimentHelper modulesAsh McKenzie2019-06-251-0/+23
| | | | | RecaptchaExperimentHelper contains helper methods to assist in the controller and view layers.
* Remove baseEndpoint from search dropdwon63177-follow-up-from-use-scoped-routes-for-labels-and-milestonesDmitriy Zaporozhets2019-06-241-3/+3
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Memoize non-existent custom appearancessh-strong-memoize-appearancesStan Hu2019-06-231-0/+16
| | | | | This saves about 5 SQL calls per page if no custom appearance is specified.
* Fix missing deployment rockets in monitor dashboardDhiraj Bodicherla2019-06-141-1/+1
| | | | | | Fixed inconsistencies in variable names for deployment endpoints for monitoring dashboard which causes deployment rocket icons to disappear
* Use scoped routes for labels and milestonesDmitriy Zaporozhets2019-06-131-3/+9
| | | | | | Update frontend code to use /-/ scope for milestones and labels routes Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Set project default visibility to max allowedStan Hu2019-06-051-0/+45
| | | | | | | | | | If the default, instance-wide visibility were set to internal but a group were private, the radio button would be set on internal even though that setting were not allowed. We now consider the allowed visibility setting for the group in determining what the default should be. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62298
* Merge branch '54140-non-ar-cache-commit-markdown' into 'master'Douwe Maan2019-06-051-1/+2
|\ | | | | | | | | | | | | Use Redis for CacheMarkDownField on non AR models Closes #54140 See merge request gitlab-org/gitlab-ce!29054
| * Use Redis for CacheMarkDownField on non AR modelsPatrick Bajao2019-06-051-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows using `CacheMarkdownField` for models that are not backed by ActiveRecord. When the including class inherits `ActiveRecord::Base` we include `Gitlab::MarkdownCache::ActiveRecord::Extension`. This will cause the markdown fields to be rendered and the generated HTML stored in a `<field>_html` attribute on the record. We also store the version used for generating the markdown. All other classes that include this model will include the `Gitlab::MarkdownCache::Redis::Extension`. This add the `<field>_html` attributes to that model and will generate the html in them. The generated HTML will be cached in redis under the key `markdown_cache:<class>:<id>`. The class this included in must therefore respond to `id`.
* | Add snowplow haml attr helperLuke Bennett2019-06-051-0/+11
|/ | | | | Helps build a hash of snowplow tracking data attrs. Updates import project pane to use new helper.
* Change s_() calls to _() callsMichał Zając2019-06-041-4/+4
| | | | There are no namespaces in the strings so we don't need those
* Merge branch 'dz-scope-project-routes-3' into 'master'Lin Jen-Shin2019-05-311-1/+1
|\ | | | | | | | | Move some project routes under - scope See merge request gitlab-org/gitlab-ce!28830
| * Fix specs after routing changeDmitriy Zaporozhets2019-05-291-1/+1
| | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | Add wiki size to project statisticsPeter Marko2019-05-291-1/+2
| |
* | Make external_dashboard_url available to frontendReuben Pereira2019-05-292-0/+71
|/ | | | | - On Operations settings page - On Metrics dashboard page
* Fix display of promote to group labelJan Provaznik2019-05-281-1/+18
| | | | | | | | | | | | | Since label presenter is used in label index view, label class check doesn't work as expected because the class is now LabelPresenter. Also `label.subject` doesn't work as expected now because Label's model `subject` method is shadowed by Gitlab's presenter's method which uses `subject` for referencing the original object. Instead we use a presenter's method for both checks now. `label_deletion_confirm_text` is not used anywhere so it's removed
* Fix page_description helper performance62116-performance-issue-502-errors-on-rendering-of-issues-with-heavy-markdown-contentsSean McGivern2019-05-221-0/+8
| | | | | | | | | | | | | | | This helper is used for extracting part of the issue / MR / whatever description for use in the description meta tag: 1. To do that, we look at the source of the Markdown description. 2. We then strip out all HTML tags. 3. And then take the first 30 words. Doing that can be really slow - especially as Markdown is supposed to be treated as plain text. There are many better ways to do this, but the immediate performance fix is to swap steps 2 and 3. This does mean that the description may be less than 30 words (or even empty), but it is much faster when the description is very long.
* Resolve CE/EE diffs in new group member viewnew-group-member-scbLuke Bennett2019-05-201-0/+17
| | | | Part of single codebase changes.
* Include MR information if possible when emailing notification of closing an ↵Michał Zając2019-05-161-0/+39
| | | | issue
* Merge branch 'new-proj-member-scb' into 'master'Phil Hughes2019-05-151-0/+20
|\ | | | | | | | | Resolve CE/EE diffs in new proj member import See merge request gitlab-org/gitlab-ce!28254
| * Resolve CE/EE diffs in new proj member importnew-proj-member-scbLuke Bennett2019-05-101-0/+20
| | | | | | | | Part of single codebase changes.
* | Merge branch 'layouts-scb' into 'master'Phil Hughes2019-05-151-0/+12
|\ \ | | | | | | | | | | | | | | | | | | Resolve CE/EE diffs in app/views/layouts view Closes gitlab-ee#6647 See merge request gitlab-org/gitlab-ce!28197
| * | Resolve CE/EE diffs in app/views/layouts viewlayouts-scbLuke Bennett2019-05-111-0/+12
| |/ | | | | | | Part of single codebase changes.
* | Resolve CE/EE diffs in zero_authorized_projectszero-auth-proj-scbLuke Bennett2019-05-111-0/+6
|/ | | | Part of single codebase changes.
* Added blank lines to meet style guideEzekiel Kigbo2019-05-061-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Un-nest title variable output Update spec test names Rename sort_value_most_stars -> sort_value_stars_desc Rename sorted_by_stars -> sorted_by_stars_desc Renname sort_value_most_stars_asc -> sort_value_stars_asc Invert feature check, assign feature condition to a variable Inline conditional nav bar rendering Invert conditional label Added follow up task Fix filters returning 0 projects show the wrong view Move click action out of test expectation Use proper variable name for project in before block Rename projects_sort_admin_options_hash Renamed projects_sort_admin_options_has to old_projects_sort_options_hash as its not only used on the admin screen Fix extra whitespace errors Stub project_list_filter_bar in the projects_helper specs Added follow up task for `show_projects?` Removed url test expectations
* Add packages_size to ProjectStatisticsAlessio Caiazza2019-05-021-0/+24
| | | | | This new field will allow to keep track of the storage used by the packages features, it provides also aggregation at namespace level.
* Move scoped_label into label presenterJan Provaznik2019-04-231-19/+29
| | | | | | | When rendering a label we want to check 'scoped_label' feature availability on a project/group where label is being used. For this reason a label presenter is used in UI and information about context project/group is passed to this presenter.
* Add part of needed codeGosia Ksionek2019-04-051-3/+69
| | | | | | | | | | | | | | | | | Add columns to store project creation settings Add project creation level column in groups and default project creation column in application settings Remove obsolete line from schema Update migration with project_creation_level column existence check Rename migrations to avoid conflicts Update migration methods Update migration method
* Merge branch 'keyval-labels' into 'master'Sean McGivern2019-04-051-0/+20
|\ | | | | | | | | [CE] Add mutually exclusive labels See merge request gitlab-org/gitlab-ce!26804
| * Fix scoped_labels feature checkJan Provaznik2019-04-041-0/+20
| | | | | | | | | | Check this feature per project/group instead of globally. Also do not show tooltip if it's disabled.
* | Autocorrect with RSpec/ExampleWording copThong Kuah2019-04-053-8/+8
| | | | | | | | | | | | | | - rewords examples starting with 'should' - rewords examples starting with 'it' Note: I had to manually fixup "onlies" to "only"
* | Allow to sort wiki pages by date and titleIgor2019-04-041-0/+52
|/ | | | | - Add controls for sorting by title and date - Execute Gitaly call which now accepts sorting params for wikis
* Merge branch 'feature/webide_escaping' of gitlab.com:hiddentiger/gitlab-ce ↵Kieran Andrews2019-04-031-0/+13
| | | | into feature/webide_escaping
* Fix group transfer selection possibilitiesPeter Marko2019-04-021-0/+33
|
* [CE] Reduce the diff with EE in spec/helpers/projects_helper_spec.rbRémy Coutable2019-03-281-0/+2
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* [CE] Reduce the diff with EE in spec/helpers/merge_requests_helper_spec.rbRémy Coutable2019-03-281-0/+2
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* [CE] Reduce the diff with EE in spec/helpers/issuables_helper_spec.rbRémy Coutable2019-03-281-2/+4
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* [CE] Reduce the diff with EE in spec/helpers/group_helper_spec.rbRémy Coutable2019-03-281-0/+2
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* [CE] Reduce the diff with EE in spec/helpers/auth_helper_spec.rbRémy Coutable2019-03-281-0/+2
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* [CE] Reduce the diff with EE in spec/helpers/appearances_helper_spec.rbRémy Coutable2019-03-281-5/+3
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Improvements for Knative installationMayra Cabrera2019-03-251-0/+33
| | | | | | | Displays Knative domain field automatically after Helm is successfully installed. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56954
* Move out link\unlink ability checks to a policyPavel Shutsin2019-03-191-9/+29
| | | | We can extend the policy in EE for additional behavior
* Enable/disable Auto DevOps at Group levelMayra Cabrera2019-03-121-3/+135
| | | | | | | | | | | | - Includes instance methods on Group model to detect when a group has AutoDevOps explicitly/implicitly enabled/disabled. - Includes migration to add a new column to namespaces table - Add UI necessary modifications - Add service and controller to update auto devops related instances - Updates project and groups auto devops badges Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52447
* Add Saturday to first day of the weekhaghighi_ahmad2019-03-041-4/+12
| | | | | | | | | | | | | | | | | | | | fix #58023 docs for adding Saturday for first day of the week add related settings for Saturday as first day of the week firstDayOfWeek: Use enumeration, replace day's numbers with corresponding names make some variables lowercase (follow camelCase) add CHANGELOG entry Author: haghighi_ahmad <haghighi.ahmad@gmail.com> modified: app/assets/javascripts/pages/users/activity_calendar.js modified: app/helpers/preferences_helper.rb new file: changelogs/unreleased/58023-add-Saturday-to-localization-first-day-of-the-week.yml modified: doc/api/settings.md modified: doc/user/profile/preferences.md modified: locale/gitlab.pot modified: spec/helpers/preferences_helper_spec.rb
* Refactor model and specReuben Pereira2019-03-011-0/+50
| | | | | | - Move some specs into contexts - Let get_slugs method take a parameter and return a specific slug. - Add rescues when using Addressable::URI.
* Show header and footer system messages in emailAlexandru Croitor2019-02-271-0/+54
| | | | | | | | | | | * Add email_header_and_footer_enabled flag to appearances table * Set email_header_and_footer_enabled default value to false * Add checkbox to appearance to toggle show header and footer in emails * Add email_header_and_footer_enabled to allowed params in controller * Add header and footer messages to the html and text email layouts * Remove the color styling for emails header and footer * Add empty_mailer layout for emails without layout, to have the header and footer applied
* Makes the Web IDE the default editorPhil Hughes2019-02-261-0/+8
| | | | Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/42382
* Merge branch '55057-system-message-to-core' into 'master'Sean McGivern2019-02-221-0/+76
|\ | | | | | | | | | | | | Port EE System Header And Footer feature to CE Closes #55057 See merge request gitlab-org/gitlab-ce!25241