summaryrefslogtreecommitdiff
path: root/spec/helpers
Commit message (Collapse)AuthorAgeFilesLines
* Include child projects a user can manage in namespace dropdownsBob Van Landuyt2017-11-141-0/+25
| | | | These dropdown options are used for creating and transfering projects.
* Merge branch 'tz-no-cdn-for-svg-sprites' into 'master'Douwe Maan2017-11-101-3/+25
|\ | | | | | | | | Icon Sprite URL needs to be local even if asset_host is set See merge request gitlab-org/gitlab-ce!15289
| * Removed Bracketstz-no-cdn-for-svg-spritesTim Zallmann2017-11-091-1/+1
| |
| * Fixed Function + Test based on MRTim Zallmann2017-11-091-9/+7
| |
| * Missing the local urlTim Zallmann2017-11-091-2/+2
| |
| * Put Icons Path in HelperTim Zallmann2017-11-091-6/+9
| |
| * Fixed URL Matching in TestsTim Zallmann2017-11-091-6/+6
| |
| * Icon Sprite URL is also local even if asset_host is setTim Zallmann2017-11-091-0/+21
| |
* | Always return full avatar URL for private/internal groups/projects when ↵Douwe Maan2017-11-092-98/+7
|/ | | | asset host is set
* Free up some group reserved wordsBob Van Landuyt2017-11-071-1/+1
|
* Resolve "DashboardController#activity.json is slow due to SQL"Francisco Javier López2017-11-062-114/+127
|
* Merge branch 'icons-ci-icons' into 'master'Filipa Lacerda2017-11-021-8/+4
|\ | | | | | | | | Convert Icons in CI to SVG Sprite Icons See merge request gitlab-org/gitlab-ce!14567
| * Now one test works lets get the other one greenTim Zallmann2017-10-301-1/+1
| |
| * CHanged to String StatusesTim Zallmann2017-10-301-4/+4
| |
| * Need to render it into String cause its a content_tagTim Zallmann2017-10-301-2/+2
| |
| * Fixed SVG Output TestTim Zallmann2017-10-301-8/+4
| |
* | CE port of code changed for epicsjk-epic-changes-ce-portJarka Kadlecova2017-11-022-0/+58
|/
* Added ssh fingerprint, gitlab ci and pages information in an instance ↵Francisco Lopez2017-10-251-0/+51
| | | | | | configuration page Closes #25142
* Prevent ApplicationHelper specs from polluting later ones39253-jobs-fail-because-of-brazilian-portuguese-translationsSean McGivern2017-10-181-3/+3
| | | | | We don't want the locale to be set to Brazilian Portuguese for any subsequent specs!
* Build the locale path with an `_` instead of a `-`Bob Van Landuyt2017-10-181-0/+8
| | | | | | | | | The locale code is turned into an asset path with an underscore instead of a dash. The language codes are transformed by `I18n.locale` into a code with a dash. But the resources for translating are always stored in a path using a `_` separating the language and the region code.
* Merge branch '38245-private-avatars-are-not-cdn-compatible' into 'master'Douwe Maan2017-10-102-5/+48
|\ | | | | | | | | | | | | Resolve "Private Avatars are not CDN compatible" Closes #38245 and gitlab-com/support-forum#2476 See merge request gitlab-org/gitlab-ce!14443
| * Fixed TestsTim Zallmann2017-10-042-3/+3
| |
| * Fixed TestTim Zallmann2017-10-041-2/+1
| |
| * Fixed Linting errors + testsTim Zallmann2017-10-042-9/+10
| |
| * Created group_icon and group_icon_urlTim Zallmann2017-10-041-2/+45
| | | | | | | | Tests for these new helper methods
* | Replaces `tag: true` into `:tag` in the specsJacopo2017-10-071-1/+1
| | | | | | | | | | | | Replaces all the explicit include metadata syntax in the specs (tag: true) into the implicit one (:tag). Added a cop to prevent future errors and handle autocorrection.
* | Add a project forks spec helperBob Van Landuyt2017-10-071-3/+4
|/ | | | | The helper creates a fork of a project with all provided attributes, but skipping the creation of the repository on disk.
* Resolve "Precompiled assets with digest strings are ignored in CI"Mike Greiling2017-10-032-4/+4
|
* Update projects_helper_specLuke "Jared" Bennett2017-09-281-2/+2
|
* Merge branch '38189-fix-user-avatar-url-cdn' into 'master'Douwe Maan2017-09-251-40/+62
|\ | | | | | | | | | | | | Prevent URL concatenation for avatars Closes #38189 See merge request gitlab-org/gitlab-ce!14437
| * Update tests to reflect `user_avatar_without_link` helper changes38189-fix-user-avatar-url-cdnkushalpandya2017-09-251-40/+62
| |
* | Fixes dashboard/projects empty state showing when viewing personal projectsPhil Hughes2017-09-221-4/+8
|/ | | | | This was caused by the `@projects` value being empty when the current user does not have any personal projects.
* Resolve "Better SVG Usage in the Frontend"Tim Zallmann2017-09-221-0/+19
|
* Merge branch '34259-project-denial-of-service-via-gitmodules-fix' into 'master'Robert Speicher2017-09-191-0/+6
|\ | | | | | | | | | | | | Fixes project denial of service via gitmodules using Extended ASCII. Closes #34259 See merge request gitlab-org/gitlab-ce!14301
| * Fixes project denial of service via gitmodules using Extended ASCII.34259-project-denial-of-service-via-gitmodules-fixTiago Botelho2017-09-151-0/+6
| |
* | Merge branch ↵Douwe Maan2017-09-141-2/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | '37576-renamed-files-have-escaped-html-for-the-inline-diff-in-the-header' into 'master' Resolve "Renamed files have escaped HTML for the inline diff in the header" Closes #37576 See merge request gitlab-org/gitlab-ce!14121
| * | changed InlineDiffMarker to make it html_safe its output37576-renamed-files-have-escaped-html-for-the-inline-diff-in-the-headermicael.bergeron2017-09-121-2/+2
| | | | | | | | | | | | updated the spec
* | | escape characters in git user nameBrandon Everett2017-09-131-0/+11
| | |
* | | Fix extra space in YAML arrayZeger-Jan van de Weg2017-09-131-1/+1
| | |
* | | AutoDevOps banner hidden on explicit CI configZeger-Jan van de Weg2017-09-131-0/+16
| | | | | | | | | | | | | | | | | | | | | Extends the helper method to no show the banner as soon as the project has a `.gitlab-ci.yml` file on the default branch. Fixes gitlab-org/gitlab-ce#37652
* | | Merge branch 'zj-feature-flipper-disable-banner' into 'master'Kamil Trzciński2017-09-131-0/+10
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Allow all AutoDevOps banners to be disabled Closes #37653 See merge request !14218
| * | | Allow all AutoDevOps banners to be disabledZeger-Jan van de Weg2017-09-121-0/+10
| | |/ | |/| | | | | | | | | | | | | | | | | | | Given the default in the development and production environment is false, the negation of enabling is used in the flag to signal you'd turn it off. It reads a bit awkward, but makes us have a migration less. Fixes gitlab-org/gitlab-ce#37653
* | | Revert "Merge branch 'revert-f2421b2b' into 'master'"revert-2f46c3a8Annabel Dunstone Gray2017-09-111-2/+28
|/ / | | | | This reverts merge request !14148
* | Merge branch 'user-recent-push' into 'master'Douwe Maan2017-09-111-14/+1
|\ \ | | | | | | | | | | | | | | | | | | Rework how recent push events are retrieved Closes #35990 See merge request !13995
| * | Rework how recent push events are retrieveduser-recent-pushYorick Peterse2017-09-081-14/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Whenever you push to a branch GitLab will show a button to create a merge request (should one not exist already). The underlying code to display this data was quite inefficient. For example, it involved multiple slow queries just to figure out what the most recent push event was. This commit changes the way this data is retrieved so it's much faster. This is achieved by caching the ID of the last push event on every push, which is then retrieved when loading certain pages. Database queries are only executed if necessary and the cached data is removed automatically once a merge request has been created, or 2 hours after being stored. A trade-off of this approach is that we _only_ track the last event. Previously if you were to push to branch A and B then create a merge request for branch B we'd still show the widget for branch A. As of this commit this is no longer the case, instead we will only show the widget for the branch you pushed to most recently. Once a merge request exists the widget is no longer displayed. Alternative solutions are either too complex and/or too slow, hence the decision was made to settle for this trade-off. Performance Impact ------------------ In the best case scenario (= a user didn't push anything for more than 2 hours) we perform a single Redis GET per page. Should there be cached data we will run a single (and lightweight) SQL query to get the event data from the database. If a merge request already exists we will run an additional DEL to remove the cache key. The difference in response timings can vary a bit per project. On GitLab.com the 99th percentile of time spent in User#recent_push hovers between 100 milliseconds and 1 second, while the mean hovers around 50 milliseconds. With the changes in this MR the expected time spent in User#recent_push is expected to be reduced down to just a few milliseconds. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/35990
* | Revert "Merge branch ↵revert-f2421b2bRubén Dávila2017-09-081-28/+2
| | | | | | | | | | '35012-navigation-add-option-to-change-navigation-color-palette' into 'master'" This reverts merge request !13619
* | Merge branch 'fix-escape-commit-block' into 'security-9-5'Douwe Maan2017-09-071-0/+22
|/ | | | | [9.5] Prevent a persistent XSS in the commit author block See merge request gitlab/gitlabhq!2180
* Merge branch 'improve-share-locking-feature-for-subgroups' into 'master'Douwe Maan2017-09-071-0/+93
|\ | | | | | | | | | | | | Improve "Share with group lock" feature for subgroups Closes #30550 See merge request !13944
| * Refer to “Share with group lock” consistentlyimprove-share-locking-feature-for-subgroupsMichael Kozono2017-09-061-5/+5
| |
| * Link or not link depending on permissionsMichael Kozono2017-09-061-3/+13
| |
View Lorry Controller Status