| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
These are not required because MySQL is not
supported anymore
|
| |
|
|
| |
This is part of migration of Folder View to Vue
|
| |
|
|
|
|
|
|
|
|
|
|
| |
A new `discussion_id` argument on the `createNote` mutation allows
people to create a note within that discussion.
The ability to lazy-load Discussions has been added, so
GraphQL.object_from_id can treat Discussions the same as AR objects and
batch load them.
https://gitlab.com/gitlab-org/gitlab-ce/issues/62826
https://gitlab.com/gitlab-org/gitlab-ee/issues/9489
|
| |
|
|
| |
https://gitlab.com/gitlab-org/gitlab-ee/issues/9489
|
| |
|
|
|
|
| |
- Remove Gitaly call check for fields that have a constant complexity
declared
- Add associated test
|
| |
|
|
|
|
| |
- Add 1 for all fields that call Gitaly (with resolvers or without)
- Clarify comment regarding Gitaly call alert
- Expose predicate `calls_gitaly?` instead of ivar
|
| |
|
|
|
|
|
| |
- Move `calls_gitaly_check` to public
- Add instrumentation for flagging missing CallsGitaly declarations
- Wrap resolver proc in before-and-after Gitaly counts to get the net
Gitaly call count for the resolver.
|
| |
|
|
|
| |
- If Gitaly calls are missing, it could be due to a conditional and
may just become noise
|
| |
|
|
|
|
| |
- Add a complexity of 1 if Gitaly is called at least once
- Add an error notification if `calls_gitaly` isn't right for a
particular field
|
| |\ |
|
| | |\
| | |
| | |
| | |
| | | |
Added commit type to tree GraphQL type
See merge request gitlab-org/gitlab-ce!29412
|
| | | | |
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Adding new `AddAwardEmoji`, `RemoveAwardEmoji` and `ToggleAwardEmoji`
GraphQL mutations.
Adding new `#authorized_find_with_pre_checks!` and (unused, but for
completeness `#authorized_find_with_post_checks!`) authorization
methods. These allow us to perform an authorized find, and run our own
additional checks before or after the authorization runs.
https://gitlab.com/gitlab-org/gitlab-ce/issues/62826
|
| |/
|
|
| |
This also disables the cop with a reasoning in types where appropriate
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a `markdown_field` to our types.
Using this helper will render a model's markdown field using the
existing `MarkupHelper` with the context of the GraphQL query
available to the helper.
Having the context available to the helper is needed for redacting
links to resources that the current user is not allowed to see.
Because rendering the HTML can cause queries, the complexity of a
these fields is raised by 5 above the default.
The markdown field helper can be used as follows:
```
markdown_field :note_html, null: false
```
This would generate a field that will render the markdown field `note`
of the model. This could be overridden by adding the `method:`
argument. Passing a symbol for the method name:
```
markdown_field :body_html, null: false, method: :note
```
It will have this description by default:
> The GitLab Flavored Markdown rendering of `note`
This could be overridden by passing a `description:` argument.
The type of a `markdown_field` is always `GraphQL::STRING_TYPE`.
|
| |
|
|
|
|
|
|
|
| |
This exposes `Note`s on Issues & MergeRequests using a
`Types::Notes::NoteableType` in GraphQL.
Exposing notes on a new type can be done by implementing the
`NoteableType` interface on the type. The presented object should
be a `Noteable`.
|
| | |
|
| |\
| |
| |
| |
| |
| |
| |
| |
| | |
'master'
Reduce GraphQL complexity for non-connection fields
Closes #62706
See merge request gitlab-org/gitlab-ce!29165
|
| | |
| |
| |
| | |
This helps reduce complexity for non-connections
|
| |\ \
| | |
| | |
| | |
| | | |
Add web_url to tree entry in GraphQL API
See merge request gitlab-org/gitlab-ce!28646
|
| | |/ |
|
| |\ \
| |/
|/|
| |
| |
| |
| | |
Use global IDs when exposing GraphQL resources
Closes #62650
See merge request gitlab-org/gitlab-ce!29080
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This exposes all fields named `id` as GlobalIDs so they can be used
across our entire GraphQL implementation.
When the objects loaded are `ApplicationRecord`s. We'll use our
existing batchloading to find them. Otherwise, we'll fall back to the
default implementation of `GlobalID`: Calling the `.find` method on
the class.
|
| |/ |
|
| |
|
|
|
|
| |
We can query namespaces, and nested projects.
Projects now exposes statistics
|
| |
|
|
|
| |
and allow passing of child_complexity to the
'resolver_complexity' metho
|
| |
|
|
|
|
|
|
|
| |
Enabling GraphQL batch requests allows for multiple queries
to be sent in 1 request reducing the amount of requests
we send to the server.
Responses come come back in the same order as the queries were
provided.
|
| |\
| |
| |
| |
| | |
Added repository files to GraphQL API
See merge request gitlab-org/gitlab-ce!28325
|
| | | |
|
| |/ |
|
| |\
| |
| |
| |
| |
| |
| | |
58404 - setup max depth for graphql
Closes #58404
See merge request gitlab-org/gitlab-ce!25737
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
58404 - add change log
58404 - add spec
58404 - add more spec to test depth 2
58404 - fix spec
58404 - fix rubocop
58404 - refactor the code by Bob's advice
58404 - revert changes of all_graphql_fields_for
58404 - change text only
58404 - fix rspec according to gitlab's standard
58404 - revert previous spec
58404 - fix rubocop
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a field is a resolver, its complexity is automatically
increased. By default we add extra points for sort and search
arguments (which will be common for various resolvers).
For specific resolvers we add field-specific complexity, e.g.
for Issues complexity is increased if we filter issues by `labelName`
(because then SQL query is more complex). We may want to tune these
values in future depending on real-life results.
Complexity is also dependent on the number of loaded nodes, but only
if we don't search by specific ID(s). Also added complexity is limited
(by default only twice more than child complexity) - the reason is
that although it's more complex to process more items, the complexity
increase is not linear (there is not so much difference between loading
10, 20 or 100 records from DB).
|
| |\
| |
| |
| |
| |
| |
| | |
Add basic GraphQL for a Group
Closes #60786
See merge request gitlab-org/gitlab-ce!27492
|
| | |
| |
| |
| |
| | |
Add new query for Groups, with new
GroupType and NamespaceType
|
| |/
|
|
|
|
| |
This ports the changes from
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10462/
to CE
|
| |
|
|
|
| |
With this we only check abilities on the rendered edges of a GraphQL
connection instead of all the nodes in it.
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Allow GraphQL Scalar-fields to be authorized
Closes #57831
See merge request gitlab-org/gitlab-ce!26338
|
| | | |
|
| |/
|
|
|
|
|
|
| |
It makes all Types::BaseField default to a complexity of 1.
Queries themselves now have limited complexity, scaled
to the type of user: no user, authenticated user, or an
admin user.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enables authorizations to be defined on GraphQL Types.
module Types
class ProjectType < BaseObject
authorize :read_project
end
end
If a field has authorizations defined on it, and the return type of the
field also has authorizations defined on it. then all of the combined
permissions in the authorizations will be checked and must pass.
Connection fields are checked by "digging" to find the type class of the
"node" field in the expected location of edges->node.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54417
|
| |
|
|
|
|
|
|
|
| |
Allow extra permissions for the `Types::ProjectType` and
`Types:IssueType` GraphQL types. As we'll be adding more permissions
in CE.
Now this spec only validates if all the expected permissions are
present, but it will not fail if there are more.
|
| |
|
|
|
|
|
|
|
| |
- Show pipeline status, title, MR Status and project path
- Popover attached to gitlab flavored markdown everywhere, including:
+ MR/Issue Title
+ MR/Issue description
+ MR/Issue comments
+ Rendered markdown files
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously GraphQL field authorization happened like this:
class ProjectType
field :my_field, MyFieldType do
authorize :permission
end
end
This change allowed us to authorize like this instead:
class ProjectType
field :my_field, MyFieldType, authorize: :permission
end
A new initializer registers the `authorize` metadata keyword on GraphQL
Schema Objects and Fields, and we can collect this data within the
context of Instrumentation like this:
field.metadata[:authorize]
The previous functionality of authorize is still being used for
mutations, as the #authorize method here is called at during the code
that executes during the mutation, rather than when a field resolves.
https://gitlab.com/gitlab-org/gitlab-ce/issues/57828
|
| |
|
|
| |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| | |
|
| |
|
|
| |
And add tests
|
